fix(model-evals): rename SDK attr project_id → project (URL slug)

Pairs with roboflow#11636 dropping `projectId` from the public response.

The SDK previously read `info["projectId"]` (the Firestore doc id) into
`ModelEval.project_id`. That field was a doc-id leak — the API now only
returns `project` (the URL slug) on the principle that public APIs
should not expose storage-layer ids.

Rename: `ModelEval.project_id` → `ModelEval.project`. Accept legacy
`projectId` from cached older-server responses for forward-compat.
CLI list/get handlers also pull from `project` first.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: leeclemnet

roboflow/cli/handlers/eval.py

@@ -225,7 +225,9 @@ def _list_evals(args):  # noqa: ANN001
             # Prefer DNA's `evalId`; tolerate legacy `id` from older server versions.
             "id": e.get("evalId", e.get("id", "")),
             "status": e.get("status", ""),
-            "project": e.get("projectId", ""),
+            # `project` is the URL slug; the public API does not expose the doc id.
+            # Tolerate legacy `projectId` for forward-compat against older deploys.
+            "project": e.get("project") or e.get("projectId", ""),
             "version": e.get("versionId", ""),
             "model": e.get("modelId", "") or "",
             "created": e.get("createdAt", ""),
@@ -259,7 +261,8 @@ def _get_eval(args):  # noqa: ANN001
         # Prefer DNA's `evalId`; tolerate legacy `id`.
         f"Eval: {info.get('evalId', info.get('id', args.eval_id))}",
         f"  Status:  {info.get('status', '')}",
-        f"  Project: {info.get('projectId', '')}",
+        # `project` is the URL slug; tolerate legacy `projectId` for forward-compat.
+        f"  Project: {info.get('project') or info.get('projectId', '')}",
         f"  Version: {info.get('versionId', '')}",
         f"  Model:   {info.get('modelId', '') or '(none)'}",
         f"  Created: {info.get('createdAt', '')}",

roboflow/core/model_eval.py

@@ -53,7 +53,11 @@ def _apply(self, info: Dict[str, Any]) -> None:
         if info.get("evalId"):
             self.id = info["evalId"]
         self.status: Optional[str] = info.get("status")
-        self.project_id: Optional[str] = info.get("projectId")
+        # `project` is the project URL slug — the same identifier the REST API
+        # uses in URL paths. The internal Firestore doc id is intentionally
+        # never exposed in the public API. Accept legacy `projectId` for
+        # forward-compat with older server versions.
+        self.project: Optional[str] = info.get("project") or info.get("projectId")
         self.version_id: Optional[str] = info.get("versionId")
         self.model_id: Optional[str] = info.get("modelId")
         self.created_at: Optional[str] = info.get("createdAt")
@@ -132,12 +136,11 @@ def to_dict(self) -> Dict[str, Any]:
         # back to attributes when only the constructor was called with no info.
         if self._raw:
             return {**self._raw, "evalId": self.id}
-        for key in ("status", "projectId", "versionId", "modelId", "createdAt", "summary"):
+        for key in ("status", "project", "versionId", "modelId", "createdAt", "summary"):
             attr = (
                 key
-                if key in {"status", "summary"}
+                if key in {"status", "project", "summary"}
                 else {
-                    "projectId": "project_id",
                     "versionId": "version_id",
                     "modelId": "model_id",
                     "createdAt": "created_at",
@@ -149,7 +152,7 @@ def to_dict(self) -> Dict[str, Any]:
         return data
 
     def __repr__(self) -> str:  # pragma: no cover - debug helper
-        return f"ModelEval(id={self.id!r}, status={self.status!r}, project={self.project_id!r})"
+        return f"ModelEval(id={self.id!r}, status={self.status!r}, project={self.project!r})"
 
 
 __all__: List[str] = ["ModelEval"]

tests/cli/test_eval_handler.py

@@ -75,22 +75,35 @@ def test_list_text_calls_adapter_with_filters(self, _key, _ws, mock_list):
                 {
                     "id": "e1",
                     "status": "done",
-                    "projectId": "p1",
+                    "project": "my-project-slug",
                     "versionId": "3",
                     "modelId": None,
                     "createdAt": "2025-01-01",
                 }
             ]
         }
-        args = _args(workspace=None, project="p1", version="3", model=None, status="done", limit=5)
+        args = _args(
+            workspace=None,
+            project="my-project-slug",
+            version="3",
+            model=None,
+            status="done",
+            limit=5,
+        )
 
         from roboflow.cli.handlers.eval import _list_evals
 
         with patch("builtins.print") as mock_print:
             _list_evals(args)
 
         mock_list.assert_called_once_with(
-            "key", "lee-sandbox", project="p1", version="3", model=None, status="done", limit=5
+            "key",
+            "lee-sandbox",
+            project="my-project-slug",
+            version="3",
+            model=None,
+            status="done",
+            limit=5,
         )
         printed = mock_print.call_args[0][0]
         self.assertIn("e1", printed)
@@ -136,11 +149,10 @@ def test_get_text(self, _key, _ws, mock_get):
         mock_get.return_value = {
             "id": "e1",
             "status": "done",
-            "projectId": "p1",
+            "project": "my-project-slug",
             "versionId": "3",
             "modelId": "m1",
             "createdAt": "2025-01-01",
-            "config": {"overlap": 30, "iouThreshold": 50},
             "summary": {"mAP": 0.91, "precision": 0.85, "recall": 0.8},
         }
         args = _args(workspace=None, eval_id="e1")

tests/test_model_eval.py

@@ -28,7 +28,7 @@ def test_apply_info_populates_attributes(self):
         info = {
             "evalId": "e1",
             "status": "done",
-            "projectId": "p1",
+            "project": "my-project-slug",  # URL slug — the public API only returns the slug
             "versionId": "3",
             "modelId": "m1",
             "createdAt": "2025-01-01",
@@ -38,7 +38,7 @@ def test_apply_info_populates_attributes(self):
 
         self.assertEqual(ev.id, "e1")
         self.assertEqual(ev.status, "done")
-        self.assertEqual(ev.project_id, "p1")
+        self.assertEqual(ev.project, "my-project-slug")
         self.assertEqual(ev.version_id, "3")
         self.assertEqual(ev.model_id, "m1")
         self.assertEqual(ev.created_at, "2025-01-01")
@@ -174,8 +174,8 @@ def test_evals_returns_modeleval_instances(self, mock_list):
 
         mock_list.return_value = {
             "evals": [
-                {"evalId": "e1", "status": "done", "projectId": "p1"},
-                {"evalId": "e2", "status": "running", "projectId": "p1"},
+                {"evalId": "e1", "status": "done", "project": "my-project-slug"},
+                {"evalId": "e2", "status": "running", "project": "my-project-slug"},
             ]
         }
         ws = _make_workspace()