Merge pull request #224 from robbievanleeuwen/overlap_polys_fix

Update implementation of geometry.check_geometry_disjoint()

Author: connorferster

sectionproperties/pre/geometry.py

@@ -1949,7 +1949,8 @@ def check_geometry_disjoint(lop: List[Polygon]) -> bool:
     Returns True if all polygons in 'lop' are disjoint. Returns
     False, otherwise.
     """
-    geom_acc = Polygon()
-    for poly in lop:
-        geom_acc = geom_acc & poly
-    return geom_acc.is_empty
+    bool_acc = []
+    for idx, poly1 in enumerate(lop):
+        for poly2 in lop[idx + 1 :]:
+            bool_acc.append(poly1.intersection(poly2))
+    return not all(bool_acc)

sectionproperties/tests/test_sections.py

@@ -442,8 +442,10 @@ def test_check_geometry_disjoint():
     small_sq = rectangular_section(d=100, b=75)
     small_hole = rectangular_section(d=40, b=30).align_center(small_sq)
 
+    rect2 = rectangular_section(d=50, b=50).shift_section(x_offset=50)
+    assert check_geometry_disjoint([rect.geom, rect2.geom]) == False
+
     assert check_geometry_disjoint([rect.geom, circ.geom]) == True
-    assert check_geometry_overlaps([small_sq.geom, small_hole.geom]) == True
 
     rect2 = rectangular_section(d=50, b=50).shift_section(x_offset=50)
     assert check_geometry_disjoint([rect.geom, rect2.geom]) == False