Getting ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error again and again in a interval of around 1 hour

[Srijan67]

I am getting the below attached error in my electronjs app while using this package. Can you please tell me what is the issue here as by the error it looks like its firebase-electron package issue.
Also, this error is not consistent with all the devices and only a few device is getting it in a interval of around 1 hour.

Versions:
nodejs : 22.20
firebase-electron: 1.1.0

Let me know if you need any more info.

Thanks

[bmedenwald]

I'm not currently using this library, but I am seeing the same error in the library I'm using (https://github.com/javajuice1337/push-receiver-v2). This is the first report anywhere I've seen, and it seems to be picking up (only a few users last week, double that starting today.

[bmedenwald]

I discovered the problem in the library we are using and I've patched our implementation. I'm not submitting PRs into your library, but I can point you to the answer.

The problem is this line right here. When we were getting these errors, FCM is sending the crypto-key in a different format.

When it works: dh=xxxxxxxxxxxxxxxxxx
When it is broken and throws this error: dh=xxxxxxxxxxxxxxxxxx; p256ecdsa=xxxxxxxxxxxxxxxxxx

My understanding of the specification is that both of these is legal, but the latter is nothing we've seen before so none of our third party libraries were written to deal with it. I removed the simple slice in favor of a regular expression that can handle either the above cases.

My PR.

[Srijan67]

@bmedenwald so its not something which came in recent times but if its a logical issue which was there from years in that case do you have any idea why it started to appear just now ? Could be some recent changes to dh=xxxxxxxxxxxxxxxxxx; p256ecdsa=xxxxxxxxxxxxxxxxxx by firebase though.

So, haven't you published the version in npm yet for using ?

Thanks for the fix!