Commit 0202e38
authored
Fix worker-level stuck job timeout (#1133)
Fix a bug that came in with #1126 in which we we were correctly
calculating timeout, but then not passing it down to the stuck job
function when starting the stuck detection goroutine.
There is a test that was checking this worked, but due to the nature of
the bug, it was in effect detecting a stuck job after 0s and therefore
passing by accident. I looked into ways to add additional testing here,
but elected not to add more because they'd involve the sort of test I
really hate, which has to wait arbitrarily wait to try and check that
something did not happen, introducing both slowness and intermittency.
After the fix here lands, this is the sort of thing that's not too
likely to regress, and should be noticed quickly in case it does.
Fixes #1125.1 parent dfc8826 commit 0202e38
2 files changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
| 234 | + | |
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
| 269 | + | |
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| |||
281 | 281 | | |
282 | 282 | | |
283 | 283 | | |
284 | | - | |
| 284 | + | |
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| |||
0 commit comments