fix: make legacy HybridViewModel identical to main

Author: mfazekas

android/src/legacy/java/com/margelo/nitro/rive/HybridViewModel.kt

@@ -13,11 +13,9 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
     get() = viewModel.propertyCount.toDouble()
   override val instanceCount: Double
     get() = viewModel.instanceCount.toDouble()
-
   override val modelName: String
     get() = viewModel.name
 
-  // Deprecated: Use createInstanceByNameAsync instead
   override fun createInstanceByIndex(index: Double): HybridViewModelInstanceSpec? {
     if (index < 0) return null
     try {
@@ -28,7 +26,6 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
     }
   }
 
-  // Deprecated: Use createInstanceByNameAsync instead
   override fun createInstanceByName(name: String): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createInstanceFromName(name)
@@ -38,18 +35,6 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
     }
   }
 
-  override fun createInstanceByNameAsync(name: String): Promise<HybridViewModelInstanceSpec?> {
-    return Promise.async {
-      try {
-        val vmi = viewModel.createInstanceFromName(name)
-        HybridViewModelInstance(vmi)
-      } catch (e: ViewModelException) {
-        null
-      }
-    }
-  }
-
-  // Deprecated: Use createDefaultInstanceAsync instead
   override fun createDefaultInstance(): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createDefaultInstance()
@@ -59,18 +44,6 @@ class HybridViewModel(private val viewModel: ViewModel) : HybridViewModelSpec()
     }
   }
 
-  override fun createDefaultInstanceAsync(): Promise<HybridViewModelInstanceSpec?> {
-    return Promise.async {
-      try {
-        val vmi = viewModel.createDefaultInstance()
-        HybridViewModelInstance(vmi)
-      } catch (e: ViewModelException) {
-        null
-      }
-    }
-  }
-
-  // Deprecated: Use createBlankInstanceAsync instead
   override fun createInstance(): HybridViewModelInstanceSpec? {
     try {
       val vmi = viewModel.createBlankInstance()

ios/legacy/HybridViewModel.swift

@@ -14,46 +14,27 @@ class HybridViewModel: HybridViewModelSpec {
 
   var modelName: String { viewModel?.name ?? "" }
 
-  // Deprecated: Use createInstanceByNameAsync instead
   func createInstanceByIndex(index: Double) throws -> (any HybridViewModelInstanceSpec)? {
-    guard index >= 0, let viewModel = viewModel,
+    guard index >= 0 else { return nil }
+    guard let viewModel = viewModel,
           let vmi = viewModel.createInstance(fromIndex: UInt(index)) else { return nil }
     return HybridViewModelInstance(viewModelInstance: vmi)
   }
 
-  // Deprecated: Use createInstanceByNameAsync instead
   func createInstanceByName(name: String) throws -> (any HybridViewModelInstanceSpec)? {
     guard let viewModel = viewModel,
           let vmi = viewModel.createInstance(fromName: name) else { return nil }
     return HybridViewModelInstance(viewModelInstance: vmi)
   }
-
-  func createInstanceByNameAsync(name: String) throws -> Promise<(any HybridViewModelInstanceSpec)?> {
-    return Promise.async {
-      guard let viewModel = self.viewModel,
-            let vmi = viewModel.createInstance(fromName: name) else { return nil }
-      return HybridViewModelInstance(viewModelInstance: vmi)
-    }
-  }
-
-  // Deprecated: Use createDefaultInstanceAsync instead
+  
   func createDefaultInstance() throws -> (any HybridViewModelInstanceSpec)? {
     guard let viewModel = viewModel,
           let vmi = viewModel.createDefaultInstance() else {
       return nil
     }
     return HybridViewModelInstance(viewModelInstance: vmi)
   }
-
-  func createDefaultInstanceAsync() throws -> Promise<(any HybridViewModelInstanceSpec)?> {
-    return Promise.async {
-      guard let viewModel = self.viewModel,
-            let vmi = viewModel.createDefaultInstance() else { return nil }
-      return HybridViewModelInstance(viewModelInstance: vmi)
-    }
-  }
-
-  // Deprecated: Use createBlankInstanceAsync instead
+  
   func createInstance() throws -> (any HybridViewModelInstanceSpec)? {
     guard let viewModel = viewModel,
           let vmi = viewModel.createInstance() else { return nil }