Skip to content

Commit 0b98073

Browse files
ritunjaymclaude
andcommitted
fix: remove dead stub, add Python coverage, update Codecov docs
- Remove ShardRouter.ResolveShardKeys() placeholder (fan-out not implemented; single-shard path via ResolveShardKey is sufficient and already used) - Add pytest-cov to CI python-test job; upload coverage.xml to Codecov with flags: python (alongside existing C# dotnet coverage upload) - Add Codecov activation instructions to README badge section Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f48a331 commit 0b98073

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,20 @@ jobs:
9595
run: |
9696
python -m grpc_tools.protoc -I./protos --python_out=. --grpc_python_out=. protos/vector_service.proto
9797
98-
- name: Run pytest
98+
- name: Run pytest with coverage
9999
working-directory: ./sidecar
100100
run: |
101-
python -m pytest tests/ -v --tb=short --color=yes
101+
pip install pytest-cov
102+
python -m pytest tests/ -v --tb=short --color=yes \
103+
--cov=. --cov-report=xml:coverage.xml --cov-report=term-missing \
104+
--ignore=tests
105+
106+
- name: Upload Python coverage to Codecov
107+
uses: codecov/codecov-action@v4
108+
with:
109+
files: ./sidecar/coverage.xml
110+
flags: python
111+
fail_ci_if_error: false
102112

103113
# ══════════════════════════════════════════════════════════════════════════
104114
# Job 3: Docker Build (API)

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
[![codecov](https://codecov.io/gh/ritunjaym/vector-catalog-service/branch/main/graph/badge.svg)](https://codecov.io/gh/ritunjaym/vector-catalog-service)
55
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
66

7+
> **Coverage:** C# and Python tracked via Codecov. To activate the badge: visit [codecov.io](https://codecov.io), log in with GitHub, enable this repository, then re-run CI — the badge updates automatically after the first successful upload.
8+
79
> **Production-ready microservice for vector search over 100M+ NYC Taxi records**
810
> Demonstrates C#/.NET 8, Python gRPC, FAISS, Delta Lake, OpenTelemetry, and cloud-native architecture
911

src/VectorCatalog.Api/Services/ShardRouter.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,4 @@ public string ResolveShardKey(string? requestedShardKey, string defaultShardKey)
3737
return defaultShardKey;
3838
}
3939

40-
/// <summary>
41-
/// For multi-shard fan-out: returns all shard keys to query in parallel.
42-
/// Currently returns a single shard. Fan-out merge is not yet implemented.
43-
/// </summary>
44-
public IReadOnlyList<string> ResolveShardKeys(string? requestedShardKey, string defaultShardKey)
45-
{
46-
var key = ResolveShardKey(requestedShardKey, defaultShardKey);
47-
return [key]; // Fan-out across multiple shards is not yet implemented
48-
}
4940
}

0 commit comments

Comments
 (0)