Avoid autorelease

Author: groverlynn

SquirrelInputController.m

@@ -24,7 +24,6 @@ @implementation SquirrelInputController {
   NSUInteger _caretPos;
   NSArray *_candidates;
   NSUInteger _lastModifier;
-  NSEventType _lastEventType;
   uint32_t _lastEventCount;
   RimeSessionId _session;
   NSString *_schemaId;
@@ -52,9 +51,8 @@ - (BOOL)handleEvent:(NSEvent*)event client:(id)sender
   // Returning NO means the original key down will be passed on to the client.
 
   _currentClient = sender;
-
-  CGEventFlags modifiers = CGEventGetFlags(event.CGEvent);
-
+  NSEventModifierFlags modifiers = event.modifierFlags & NSEventModifierFlagDeviceIndependentFlagsMask;
+  uint32_t eventCount = CGEventSourceCounterForEventType(kCGEventSourceStateCombinedSessionState, kCGAnyInputEventType);
   BOOL handled = NO;
 
   @autoreleasepool {
@@ -82,35 +80,32 @@ - (BOOL)handleEvent:(NSEvent*)event client:(id)sender
         int release_mask = 0;
         NSUInteger changes = _lastModifier ^ modifiers;
         int rime_modifiers = osx_modifiers_to_rime_modifiers(modifiers);
-        int64_t keyCode = CGEventGetIntegerValueField(event.CGEvent, kCGKeyboardEventKeycode);
-        int rime_keycode = osx_keycode_to_rime_keycode((int)keyCode, 0, 0, 0);
+        CGKeyCode keyCode = CGEventGetIntegerValueField(event.CGEvent, kCGKeyboardEventKeycode);
+        int rime_keycode = osx_keycode_to_rime_keycode(keyCode, 0, 0, 0);
         _lastModifier = modifiers;
-        uint32_t eventCount = CGEventSourceCounterForEventType(kCGEventSourceStateCombinedSessionState, kCGAnyInputEventType);
         if (changes & OSX_CAPITAL_MASK) {
           rime_modifiers ^= kLockMask;
           [self processKey:rime_keycode modifiers:rime_modifiers];
         }
         if (changes & OSX_SHIFT_MASK) {
-          release_mask = modifiers & OSX_SHIFT_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount <= 1 ? 0 : kIgnoredMask);
+          release_mask = modifiers & OSX_SHIFT_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount == 1 ? 0 : kIgnoredMask);
           [self processKey:rime_keycode modifiers:(rime_modifiers | release_mask)];
         }
         if (changes & OSX_CTRL_MASK) {
-          release_mask = modifiers & OSX_CTRL_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount <= 1 ? 0 : kIgnoredMask);
+          release_mask = modifiers & OSX_CTRL_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount == 1 ? 0 : kIgnoredMask);
           [self processKey:rime_keycode modifiers:(rime_modifiers | release_mask)];
         }
         if (changes & OSX_ALT_MASK) {
-          release_mask = modifiers & OSX_ALT_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount <= 1 ? 0 : kIgnoredMask);
+          release_mask = modifiers & OSX_ALT_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount == 1 ? 0 : kIgnoredMask);
           [self processKey:rime_keycode modifiers:(rime_modifiers | release_mask)];
         }
         if (changes & OSX_COMMAND_MASK) {
-          release_mask = modifiers & OSX_COMMAND_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount <= 1 ? 0 : kIgnoredMask);
+          release_mask = modifiers & OSX_COMMAND_MASK ? 0 : kReleaseMask | (eventCount - _lastEventCount == 1 ? 0 : kIgnoredMask);
           [self processKey:rime_keycode modifiers:(rime_modifiers | release_mask)];
-          _lastEventCount = eventCount;
           // do not update UI when using Command key
-          break;
+          goto saveStatus;
         }
         [self rimeUpdate];
-        _lastEventCount = eventCount;
       } break;
       case NSEventTypeKeyDown: {
         // ignore Command+X hotkeys.
@@ -139,10 +134,10 @@ - (BOOL)handleEvent:(NSEvent*)event client:(id)sender
         break;
     }
   }
-
-  _lastModifier = modifiers;
-  _lastEventType = event.type;
-
+  saveStatus: if (event.type == NSEventTypeFlagsChanged) {
+    _lastModifier = modifiers;
+    _lastEventCount = eventCount;
+  }
   return handled;
 }