Fix null message regression after quiet logger addition (#44)

The `Microsoft.Build.Utilities.Core` LogError requires a non-null
string. In the refactoring, the usages of LogError fell into a new
overload of LogError which was passing a null message as the first two
arguments of LogError signature were the same.

This removes the old logger and adds more protections for this case.

Author: richardsondev

src/Task/AggregateConfig.cs

@@ -97,15 +97,15 @@ public override bool Execute()
                 if (!Enum.TryParse(OutputType, true, out FileType outputType) ||
                     !Enum.IsDefined(typeof(FileType), outputType))
                 {
-                    logger.LogError("Invalid FileType: {0}. Available options: {1}", OutputType, string.Join(", ", Enum.GetNames(typeof(FileType))));
+                    logger.LogError(message: "Invalid FileType: {0}. Available options: {1}", OutputType, string.Join(", ", Enum.GetNames(typeof(FileType))));
                     return false;
                 }
 
                 FileType inputType = FileType.Yaml;
                 if (!string.IsNullOrEmpty(InputType) &&
                     (!Enum.TryParse(InputType, true, out inputType) || !Enum.IsDefined(typeof(FileType), inputType)))
                 {
-                    logger.LogError("Invalid FileType: {0}. Available options: {1}", InputType, string.Join(", ", Enum.GetNames(typeof(FileType))));
+                    logger.LogError(message: "Invalid FileType: {0}. Available options: {1}", InputType, string.Join(", ", Enum.GetNames(typeof(FileType))));
                     return false;
                 }
 
@@ -121,7 +121,7 @@ public override bool Execute()
 
                 if (finalResult == null)
                 {
-                    logger.LogError("No input was found! Check the input directory.");
+                    logger.LogError(message: "No input was found! Check the input directory.");
                     return false;
                 }
 
@@ -136,7 +136,7 @@ public override bool Execute()
             }
             catch (Exception ex)
             {
-                logger.LogError("An unknown exception occurred: {0}", ex.Message);
+                logger.LogError(message: "An unknown exception occurred: {0}", ex.Message);
                 logger.LogErrorFromException(ex, true, true, null);
                 return false;
             }

src/Task/Logger/ITaskLogger.cs

@@ -16,31 +16,6 @@ public interface ITaskLogger
         /// <param name="messageArgs">Optional arguments for formatting the message.</param>
         void LogError(string message = null, params object[] messageArgs);
 
-        /// <summary>
-        /// Logs an error message with additional parameters.
-        /// </summary>
-        /// <param name="subcategory">The subcategory of the error.</param>
-        /// <param name="errorCode">The error code.</param>
-        /// <param name="helpKeyword">The help keyword associated with the error.</param>
-        /// <param name="file">The file in which the error occurred.</param>
-        /// <param name="lineNumber">The line number where the error occurred.</param>
-        /// <param name="columnNumber">The column number where the error occurred.</param>
-        /// <param name="endLineNumber">The end line number of the error.</param>
-        /// <param name="endColumnNumber">The end column number of the error.</param>
-        /// <param name="message">The error message to log.</param>
-        /// <param name="messageArgs">Optional arguments for formatting the message.</param>
-        void LogError(
-            string subcategory = null,
-            string errorCode = null,
-            string helpKeyword = null,
-            string file = null,
-            int lineNumber = 0,
-            int columnNumber = 0,
-            int endLineNumber = 0,
-            int endColumnNumber = 0,
-            string message = null,
-            params object[] messageArgs);
-
         /// <summary>
         /// Logs an error message from an exception.
         /// </summary>

src/Task/Logger/QuietTaskLogger.cs

@@ -24,35 +24,9 @@ public QuietTaskLogger(TaskLoggingHelper task)
         }
 
         /// <inheritdoc />
-        public void LogError(string message = null, params object[] messageArgs)
+        public void LogError(string message, params object[] messageArgs)
         {
-            Log.LogError(message, messageArgs);
-        }
-
-        /// <inheritdoc />
-        public void LogError(
-            string subcategory = null,
-            string errorCode = null,
-            string helpKeyword = null,
-            string file = null,
-            int lineNumber = 0,
-            int columnNumber = 0,
-            int endLineNumber = 0,
-            int endColumnNumber = 0,
-            string message = null,
-            params object[] messageArgs)
-        {
-            Log.LogError(
-                subcategory,
-                errorCode,
-                helpKeyword,
-                file,
-                lineNumber,
-                columnNumber,
-                endLineNumber,
-                endColumnNumber,
-                message,
-                messageArgs);
+            Log.LogError(message ?? "Unknown Error", messageArgs);
         }
 
         /// <inheritdoc />

src/Task/Logger/TaskLogger.cs

@@ -22,35 +22,9 @@ public TaskLogger(TaskLoggingHelper task)
         }
 
         /// <inheritdoc />
-        public void LogError(string message = null, params object[] messageArgs)
+        public void LogError(string message, params object[] messageArgs)
         {
-            Log.LogError(message, messageArgs);
-        }
-
-        /// <inheritdoc />
-        public void LogError(
-            string subcategory = null,
-            string errorCode = null,
-            string helpKeyword = null,
-            string file = null,
-            int lineNumber = 0,
-            int columnNumber = 0,
-            int endLineNumber = 0,
-            int endColumnNumber = 0,
-            string message = null,
-            params object[] messageArgs)
-        {
-            Log.LogError(
-                subcategory,
-                errorCode,
-                helpKeyword,
-                file,
-                lineNumber,
-                columnNumber,
-                endLineNumber,
-                endColumnNumber,
-                message,
-                messageArgs);
+            Log.LogError(message ?? "Unknown Error", messageArgs);
         }
 
         /// <inheritdoc />

src/Task/ObjectManager.cs

@@ -53,7 +53,7 @@ await fileGroups.ForEachAsync(Environment.ProcessorCount,
                         catch (ArgumentException ex)
                         {
                             hasError = true;
-                            log.LogError("No reader found for file {0}: {1} Stacktrace: {2}", file, ex.Message, ex.StackTrace);
+                            log.LogError(message: "No reader found for file {0}: {1} Stacktrace: {2}", file, ex.Message, ex.StackTrace);
                             continue;
                         }
 
@@ -65,7 +65,7 @@ await fileGroups.ForEachAsync(Environment.ProcessorCount,
                         catch (Exception ex)
                         {
                             hasError = true;
-                            log.LogError("Could not parse {0}: {1}", file, ex.Message);
+                            log.LogError(message: "Could not parse {0}: {1}", file, ex.Message);
                             log.LogErrorFromException(ex, true, true, file);
                             continue;
                         }