FileParameter: Mark the obsoleted property as NOT CLSCompliant to reduce warnings..

RequestContent: Don't use obsoleted property.
RestClientOptions*: use new RedirectOptions class instead for FollowRedirects.

Author: rassilon

src/RestSharp/Options/RestClientOptions.cs

@@ -60,7 +60,7 @@ public RestClientOptions(string baseUrl) : this(new Uri(Ensure.NotEmptyString(ba
             ? ResponseStatus.Completed
             : ResponseStatus.Error;
 
-    /// <summary>
+    /// <summary>s
     /// Authenticator that will be used to populate request with necessary authentication data
     /// </summary>
     public IAuthenticator? Authenticator { get; set; }
@@ -131,10 +131,22 @@ public RestClientOptions(string baseUrl) : this(new Uri(Ensure.NotEmptyString(ba
     /// </summary>
     public CacheControlHeaderValue? CachePolicy { get; set; }
 
+    /// <summary>
+    /// Policy settings for redirect processing
+    /// </summary>
+    public RestClientRedirectionOptions RedirectOptions { get; set; } = new RestClientRedirectionOptions();
+
     /// <summary>
     /// Instruct the client to follow redirects. Default is true.
     /// </summary>
-    public bool FollowRedirects { get; set; } = true;
+    public bool FollowRedirects {
+        get {
+            return RedirectOptions.FollowRedirects;
+        }
+        set {
+            RedirectOptions.FollowRedirects = value;
+        }
+    }
 
     /// <summary>
     /// Gets or sets a value that indicates if the <see langword="Expect" /> header for an HTTP request contains Continue.

src/RestSharp/Options/RestClientRedirectionOptions.cs

@@ -1,36 +1,34 @@
 using RestSharp.Extensions;
-using System;
-using System.Collections.Generic;
 using System.Net;
 using System.Reflection;
-using System.Text;
 
-namespace RestSharp.Options {
-    [GenerateImmutable]
-    public class RestClientRedirectionOptions {
-        static readonly Version Version = new AssemblyName(typeof(RestClientOptions).Assembly.FullName!).Version!;
+namespace RestSharp;
 
-        public bool FollowRedirects { get; set; } = true;
-        public bool FollowRedirectsToInsecure { get; set; } = false;
-        public bool ForwardHeaders { get; set; } = true;
-        public bool ForwardAuthorization { get; set; } = false;
-        public bool ForwardCookies { get; set; } = true;
-        public bool ForwardBody { get; set; } = true;
-        public bool ForwardQuery { get; set; } = true;
-        public int MaxRedirects { get; set; }
-        public bool ForwardFragment { get; set; } = true;
-        public IReadOnlyList<HttpStatusCode> RedirectStatusCodes { get; set; }
+[GenerateImmutable]
+public class RestClientRedirectionOptions {
+    static readonly Version Version = new AssemblyName(typeof(RestClientOptions).Assembly.FullName!).Version!;
 
-        public RestClientRedirectionOptions() {
-            RedirectStatusCodes = new List<HttpStatusCode>() {
-                HttpStatusCode.MovedPermanently,
-                HttpStatusCode.SeeOther,
-                HttpStatusCode.TemporaryRedirect,
-                HttpStatusCode.Redirect,
-    #if NET
-                HttpStatusCode.PermanentRedirect,
-    #endif
-            }.AsReadOnly();
-        }
+    public bool FollowRedirects { get; set; } = true;
+    public bool FollowRedirectsToInsecure { get; set; } = false;
+    public bool ForwardHeaders { get; set; } = true;
+    public bool ForwardAuthorization { get; set; } = false;
+    public bool ForwardCookies { get; set; } = true;
+    public bool ForwardBody { get; set; } = true;
+    public bool ForwardQuery { get; set; } = true;
+    public int MaxRedirects { get; set; }
+    public bool ForwardFragment { get; set; } = true;
+    public IReadOnlyList<HttpStatusCode> RedirectStatusCodes { get; set; }
+
+    public RestClientRedirectionOptions() {
+        RedirectStatusCodes = new List<HttpStatusCode>() {
+            HttpStatusCode.MovedPermanently,
+            HttpStatusCode.SeeOther,
+            HttpStatusCode.TemporaryRedirect,
+            HttpStatusCode.Redirect,
+#if NET
+            HttpStatusCode.PermanentRedirect,
+#endif
+        }.AsReadOnly();
     }
 }
+

src/RestSharp/Parameters/FileParameter.cs

@@ -114,6 +114,7 @@ public static FileParameter FromFile(
 [PublicAPI]
 public class FileParameterOptions {
     [Obsolete("Use DisableFilenameStar instead")]
+    [CLSCompliant(false)]
     public bool DisableFileNameStar {
         get => DisableFilenameStar;
         set => DisableFilenameStar = value;

src/RestSharp/Request/RequestContent.cs

@@ -83,7 +83,7 @@ StreamContent ToStreamContent(FileParameter fileParameter) {
         var dispositionHeader = fileParameter.Options.DisableFilenameEncoding
             ? ContentDispositionHeaderValue.Parse($"form-data; name=\"{fileParameter.Name}\"; filename=\"{fileParameter.FileName}\"")
             : new ContentDispositionHeaderValue("form-data") { Name = $"\"{fileParameter.Name}\"", FileName = $"\"{fileParameter.FileName}\"" };
-        if (!fileParameter.Options.DisableFileNameStar) dispositionHeader.FileNameStar = fileParameter.FileName;
+        if (!fileParameter.Options.DisableFilenameStar) dispositionHeader.FileNameStar = fileParameter.FileName;
         streamContent.Headers.ContentDisposition = dispositionHeader;
 
         return streamContent;