cluster_jewels stats ids match wrong translations

[Kojoley]

I have issues converting stat ids in cluster_jewels.json to text.

      {
        "id": "affliction_physical_damage",
        "name": "Physical Damage",
        "stats": {
          "physical_damage_+%": 12
        },
        "tag": "affliction_physical_damage"
      },

physical_damage_+% in stat_translations.json corresponds to % increased Global Physical Damage while expected % increased Physical Damage.

      {
        "id": "affliction_critical_chance",
        "name": "Critical Chance",
        "stats": {
          "critical_strike_chance_+%": 15
        },
        "tag": "affliction_critical_chance"
      },

critical_strike_chance_+% in stat_translations.json corresponds to % increased Global Critical Strike Chance while expected % increased Physical Damage.

[lvlvllvlvllvlvl]

You need to use context clues to guess which stat_translations file to get stat text from. l've added stat text to the cluster jewels json by assuming that it's passive_skill_stat_translations.txt - please let me know if this looks correct.

[Kojoley]

You need to use context clues to guess which stat_translations file to get stat text from. l've added stat text to the cluster jewels json by assuming that it's passive_skill_stat_translations.txt - please let me know if this looks correct.

I've checked stat_text values against poe.ninja and they seem to match.

But the issue with stat_translations.json seems to be bigger than I though. % increased Physical Damage on clusters corresponds to trade stat_3948993189 which is not presented in stat_translations.json at all.

[lvlvllvlvllvlvl]

that is how it works. the same stat id can have different wording depending on where the stat is used, so whenever you look up stat text you need to know which translations file to choose based on what type of thing (passive, gem, item, etc) the stat is granted by. only by looking in the correct file will you find the correct text.

[Kojoley]

I kind of understand what you are saying, but I'm not sure you are talking about parsing game files or using repoe? I don't see any other translation files besides stat_translations.json. I think readme entry about stat_translations.json needs some clarification if gems and cluster jewels are not considered items.

[Kojoley]

          "Mace or Sceptre Attacks deal 12% increased Damage with Hits and Ailments",
          "Staff Attacks deal 12% increased Damage with Hits and Ailments"

          "Dagger Attacks deal 12% increased Damage with Hits and Ailments",
          "Claw Attacks deal 12% increased Damage with Hits and Ailments"

are in reversed order to what is in game,

Item Class: Jewels
Rarity: Normal
Large Cluster Jewel
--------
Item Level: 70
--------
Adds 11 Passive Skills (enchant)
2 Added Passive Skills are Jewel Sockets (enchant)
Added Small Passive Skills grant: Staff Attacks deal 12% increased Damage with Hits and Ailments (enchant)
Added Small Passive Skills grant: Mace or Sceptre Attacks deal 12% increased Damage with Hits and Ailments (enchant)

Item Class: Jewels
Rarity: Normal
Large Cluster Jewel
--------
Item Level: 78
--------
Adds 9 Passive Skills (enchant)
2 Added Passive Skills are Jewel Sockets (enchant)
Added Small Passive Skills grant: Claw Attacks deal 12% increased Damage with Hits and Ailments (enchant)
Added Small Passive Skills grant: Dagger Attacks deal 12% increased Damage with Hits and Ailments (enchant)

on trade site https://www.pathofexile.com/api/trade/data/stats

{"id":2,"text":"Staff Attacks deal 12% increased Damage with Hits and Ailments\nMace or Sceptre Attacks deal 12% increased Damage with Hits and Ailments"},
{"id":3,"text":"Claw Attacks deal 12% increased Damage with Hits and Ailments\nDagger Attacks deal 12% increased Damage with Hits and Ailments"},

on poeninja

{"id":63998,"name":"Staff Attacks deal 12% increased Damage with Hits and Ailments, Mace or Sceptre Attacks deal 12% increased Damage with Hits and Ailments",...
{"id":64014,"name":"Claw Attacks deal 12% increased Damage with Hits and Ailments, Dagger Attacks deal 12% increased Damage with Hits and Ailments",...