chore(test): remove flaky unit test (#3262)

Author: JGAntunes

api/pkg/template/execute_test.go

@@ -2,9 +2,7 @@ package template
 
 import (
 	"encoding/base64"
-	"fmt"
 	"testing"
-	"time"
 
 	"github.com/replicatedhq/embedded-cluster/api/types"
 	ecv1beta1 "github.com/replicatedhq/embedded-cluster/kinds/apis/v1beta1"
@@ -993,147 +991,6 @@ func TestEngine_RecordDependency(t *testing.T) {
 	assert.ElementsMatch(t, []string{"dependency1", "dependency2"}, engine.depsTree["item1"]) // item1 unchanged
 }
 
-func TestEngine_ConfigMode_TLSGeneration(t *testing.T) {
-	// Helper function to create config values for a hostname
-	configValuesFor := func(hostname string) types.AppConfigValues {
-		return types.AppConfigValues{
-			"ingress_hostname": {Value: hostname},
-		}
-	}
-
-	// Helper function to time an execution
-	timeExecution := func(name string, fn func() (string, error)) (time.Duration, string) {
-		start := time.Now()
-		result, err := fn()
-		duration := time.Since(start)
-		require.NoError(t, err, "execution %s failed", name)
-		return duration, result
-	}
-
-	// Create config with TLS certificate generation templates
-	config := &kotsv1beta1.Config{
-		TypeMeta: metav1.TypeMeta{
-			APIVersion: "kots.io/v1beta1",
-			Kind:       "Config",
-		},
-		Spec: kotsv1beta1.ConfigSpec{
-			Groups: []kotsv1beta1.ConfigGroup{
-				{
-					Name:  "tls_settings",
-					Title: "TLS Configuration",
-					Items: []kotsv1beta1.ConfigItem{
-						{
-							Name:     "ingress_hostname",
-							Title:    "Ingress Hostname",
-							HelpText: "Enter a DNS hostname to use as the cert's CN.",
-							Type:     "text",
-						},
-						{
-							Name:   "tls_json",
-							Title:  "TLS JSON",
-							Type:   "textarea",
-							Hidden: true,
-							Default: multitype.FromString(`repl{{ $ca := genCA (ConfigOption "ingress_hostname") 365 }}
-repl{{ $tls := dict "ca" $ca }}
-repl{{ $cert := genSignedCert (ConfigOption "ingress_hostname") (list ) (list (ConfigOption "ingress_hostname")) 365 $ca }}
-repl{{ $_ := set $tls "cert" $cert }}
-repl{{ toJson $tls }}`),
-						},
-						{
-							Name:    "tls_ca",
-							Title:   "Signing Authority",
-							Type:    "textarea",
-							Default: multitype.FromString(`repl{{ fromJson (ConfigOption "tls_json") | dig "ca" "Cert" "" }}`),
-						},
-						{
-							Name:    "tls_cert",
-							Title:   "TLS Cert",
-							Type:    "textarea",
-							Default: multitype.FromString(`repl{{ fromJson (ConfigOption "tls_json") | dig "cert" "Cert" "" }}`),
-						},
-						{
-							Name:    "tls_key",
-							Title:   "TLS Key",
-							Type:    "textarea",
-							Default: multitype.FromString(`repl{{ fromJson (ConfigOption "tls_json") | dig "cert" "Key" "" }}`),
-						},
-					},
-				},
-			},
-		},
-	}
-
-	engine := NewEngine(config, WithMode(ModeConfig))
-
-	// Test 1: First execution with hostname - should be slow (certificate generation)
-	firstHostname := "example.com"
-	firstDuration, firstResult := timeExecution("first", func() (string, error) {
-		return engine.Execute(configValuesFor(firstHostname))
-	})
-
-	// Verify basic YAML structure
-	assert.Contains(t, firstResult, "apiVersion: kots.io/v1beta1")
-	assert.Contains(t, firstResult, "kind: Config")
-
-	// Verify TLS config items are present
-	expectedTLSItems := []string{"tls_json", "tls_ca", "tls_cert", "tls_key"}
-	for _, item := range expectedTLSItems {
-		assert.Contains(t, firstResult, fmt.Sprintf("name: %s", item))
-	}
-
-	// Test 2: First cached execution - should be fast
-	firstCachedDuration, firstCachedResult := timeExecution("first cached", func() (string, error) {
-		return engine.Execute(configValuesFor(firstHostname))
-	})
-
-	// Verify performance characteristics: non-cached should be in ms, cached much faster
-	assert.Greater(t, firstDuration, time.Millisecond*50, "First execution should take at least 50ms (cert generation)")
-	assert.Less(t, firstCachedDuration, time.Millisecond*20, "First cached execution should be under 20ms")
-
-	// Verify caching provides significant speedup
-	assert.True(t, firstCachedDuration < firstDuration/5,
-		"Cached execution should be at least 5x faster. First: %v, Cached: %v",
-		firstDuration, firstCachedDuration)
-
-	// Verify cached result is identical to first execution
-	assert.Equal(t, firstResult, firstCachedResult, "Cached execution should return identical result")
-
-	// Test 3: Second execution with different hostname - should be slow again (new certificate generation)
-	secondHostname := "test.example.com"
-	secondDuration, secondResult := timeExecution("second", func() (string, error) {
-		return engine.Execute(configValuesFor(secondHostname))
-	})
-
-	// Verify different certificates are generated for different hostnames
-	assert.NotEqual(t, firstResult, secondResult, "Different hostnames should generate different certificates")
-
-	// Test 4: Second cached execution - should be fast again
-	secondCachedDuration, secondCachedResult := timeExecution("second cached", func() (string, error) {
-		return engine.Execute(configValuesFor(secondHostname))
-	})
-
-	// Verify performance characteristics for second hostname
-	assert.Greater(t, secondDuration, time.Millisecond*50, "Second execution should take at least 50ms (cert generation)")
-	assert.Less(t, secondCachedDuration, time.Millisecond*20, "Second cached execution should be under 20ms")
-
-	// Verify caching provides significant speedup
-	assert.True(t, secondCachedDuration < secondDuration/5,
-		"Cached execution should be at least 5x faster. Second: %v, Cached: %v",
-		secondDuration, secondCachedDuration)
-
-	// Verify second cached result is identical to second execution
-	assert.Equal(t, secondResult, secondCachedResult, "Second cached execution should return identical result")
-
-	// Log performance metrics
-	t.Logf("TLS Generation Cache Performance:")
-	t.Logf("  First execution (%s): %.1fms", firstHostname, float64(firstDuration)/float64(time.Millisecond))
-	t.Logf("  First cached execution (%s): %.1fµs (%.1fx speedup)", firstHostname, float64(firstCachedDuration)/float64(time.Microsecond),
-		float64(firstDuration)/float64(firstCachedDuration))
-	t.Logf("  Second execution (%s): %.1fms", secondHostname, float64(secondDuration)/float64(time.Millisecond))
-	t.Logf("  Second cached execution (%s): %.1fµs (%.1fx speedup)", secondHostname, float64(secondCachedDuration)/float64(time.Microsecond),
-		float64(secondDuration)/float64(secondCachedDuration))
-}
-
 func TestEngine_ConfigMode_BasicTemplating(t *testing.T) {
 	config := &kotsv1beta1.Config{
 		TypeMeta: metav1.TypeMeta{