From c121ae3d52cb134e695df44d53eb548c1c934a14 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 28 Mar 2025 12:20:06 -0300 Subject: [PATCH 1/4] fix: disable coverscreen on root modal to solve issues with expo-router --- .changeset/thin-files-play.md | 18 ++++++++++++++++++ .../scaffold/src/modal/w3m-modal/index.tsx | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 .changeset/thin-files-play.md diff --git a/.changeset/thin-files-play.md b/.changeset/thin-files-play.md new file mode 100644 index 000000000..b5f7606e6 --- /dev/null +++ b/.changeset/thin-files-play.md @@ -0,0 +1,18 @@ +--- +'@reown/appkit-scaffold-react-native': patch +'@reown/appkit-auth-ethers-react-native': patch +'@reown/appkit-auth-wagmi-react-native': patch +'@reown/appkit-coinbase-ethers-react-native': patch +'@reown/appkit-coinbase-wagmi-react-native': patch +'@reown/appkit-common-react-native': patch +'@reown/appkit-core-react-native': patch +'@reown/appkit-ethers-react-native': patch +'@reown/appkit-ethers5-react-native': patch +'@reown/appkit-scaffold-utils-react-native': patch +'@reown/appkit-siwe-react-native': patch +'@reown/appkit-ui-react-native': patch +'@reown/appkit-wagmi-react-native': patch +'@reown/appkit-wallet-react-native': patch +--- + +fix: disable coverscreen on root modal to solve issues with expo-router diff --git a/packages/scaffold/src/modal/w3m-modal/index.tsx b/packages/scaffold/src/modal/w3m-modal/index.tsx index 678942ec0..70ee9b424 100644 --- a/packages/scaffold/src/modal/w3m-modal/index.tsx +++ b/packages/scaffold/src/modal/w3m-modal/index.tsx @@ -121,7 +121,7 @@ export function AppKit() { Date: Fri, 28 Mar 2025 12:46:35 -0300 Subject: [PATCH 2/4] chore: removed unused code --- packages/scaffold/src/modal/w3m-modal/index.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/scaffold/src/modal/w3m-modal/index.tsx b/packages/scaffold/src/modal/w3m-modal/index.tsx index 70ee9b424..7a39c4915 100644 --- a/packages/scaffold/src/modal/w3m-modal/index.tsx +++ b/packages/scaffold/src/modal/w3m-modal/index.tsx @@ -16,7 +16,6 @@ import { TransactionsController, type CaipAddress, type AppKitFrameProvider, - WebviewController, ThemeController } from '@reown/appkit-core-react-native'; import { SIWEController } from '@reown/appkit-siwe-react-native'; @@ -31,7 +30,6 @@ export function AppKit() { const { open, loading } = useSnapshot(ModalController.state); const { connectors, connectedConnector } = useSnapshot(ConnectorController.state); const { caipAddress, isConnected } = useSnapshot(AccountController.state); - const { frameViewVisible, webviewVisible } = useSnapshot(WebviewController.state); const { themeMode, themeVariables } = useSnapshot(ThemeController.state); const { height } = useWindowDimensions(); const { isLandscape } = useCustomDimensions(); From 71777870b9f506e342bb7dd278c8663b5d205b6c Mon Sep 17 00:00:00 2001 From: nacho <25931366+ignaciosantise@users.noreply.github.com> Date: Mon, 31 Mar 2025 17:14:46 -0300 Subject: [PATCH 3/4] chore: changed expo sample id --- .tool-versions | 1 - apps/native/app.json | 18 +++++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) delete mode 100644 .tool-versions diff --git a/.tool-versions b/.tool-versions deleted file mode 100644 index d8eb21019..000000000 --- a/.tool-versions +++ /dev/null @@ -1 +0,0 @@ -nodejs 18.20.0 diff --git a/apps/native/app.json b/apps/native/app.json index ef942fa71..af128602c 100644 --- a/apps/native/app.json +++ b/apps/native/app.json @@ -1,7 +1,7 @@ { "expo": { "name": "native", - "slug": "appkit-expo-sample", + "slug": "appkit", "version": "1.0.0", "orientation": "default", "icon": "./assets/icon.png", @@ -19,9 +19,13 @@ "runtimeVersion": { "policy": "appVersion" }, - "owner": "nacho.walletconnect", - "assetBundlePatterns": ["**/*"], - "plugins": ["./expo-plugins/installed-wallets.js"], + "owner": "nacho.reown", + "assetBundlePatterns": [ + "**/*" + ], + "plugins": [ + "./expo-plugins/installed-wallets.js" + ], "ios": { "buildNumber": "1", "bundleIdentifier": "com.walletconnect.web3modal.rnsdk", @@ -68,7 +72,7 @@ }, "android": { "versionCode": 1, - "package": "com.walletconnect.web3modal.rnsdk", + "package": "com.reown.appkit.expo", "adaptiveIcon": { "foregroundImage": "./assets/adaptive-icon.png", "backgroundColor": "#FFFFFF" @@ -84,8 +88,8 @@ }, "extra": { "eas": { - "projectId": "2d3ad657-c612-4f65-ba0f-62c277388fa6" + "projectId": "2325cd86-ac2f-4ecc-a094-6bb2276f2e8a" } } } -} +} \ No newline at end of file From 620a1570c283694ebdffe3dc3b8b1c775a974906 Mon Sep 17 00:00:00 2001 From: nacho <25931366+ignaciosantise@users.noreply.github.com> Date: Mon, 12 May 2025 15:26:12 -0300 Subject: [PATCH 4/4] chore: added prettierignore --- .prettierignore | 2 ++ apps/native/app.json | 10 +++------- 2 files changed, 5 insertions(+), 7 deletions(-) create mode 100644 .prettierignore diff --git a/.prettierignore b/.prettierignore new file mode 100644 index 000000000..196f1a34b --- /dev/null +++ b/.prettierignore @@ -0,0 +1,2 @@ +/apps +.yarn \ No newline at end of file diff --git a/apps/native/app.json b/apps/native/app.json index af128602c..95e1fe6db 100644 --- a/apps/native/app.json +++ b/apps/native/app.json @@ -20,12 +20,8 @@ "policy": "appVersion" }, "owner": "nacho.reown", - "assetBundlePatterns": [ - "**/*" - ], - "plugins": [ - "./expo-plugins/installed-wallets.js" - ], + "assetBundlePatterns": ["**/*"], + "plugins": ["./expo-plugins/installed-wallets.js"], "ios": { "buildNumber": "1", "bundleIdentifier": "com.walletconnect.web3modal.rnsdk", @@ -92,4 +88,4 @@ } } } -} \ No newline at end of file +}