Skip to content

Commit 006151b

Browse files
grencezcodex
andcommitted
qual(test): test case requests are always lists
Co-authored-by: Codex <codex@openai.com>
1 parent b98413e commit 006151b

File tree

2 files changed

+49
-51
lines changed

2 files changed

+49
-51
lines changed

test/server_test.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@
55
from typing import Any, Dict, List, cast
66

77

8-
def normalize_list(obj: Any) -> List[Any]:
9-
if obj is None:
10-
return []
11-
if isinstance(obj, list):
12-
return obj
13-
return [obj]
14-
15-
168
class TestServerSxPB(unittest.TestCase):
179
def test_sxpb_cases(self):
1810
sxpb_path = os.path.join(os.path.dirname(__file__), "server_test_cases.sxpb")
@@ -32,8 +24,7 @@ def test_sxpb_cases(self):
3224
# Setup phase
3325
setup_block = case.get("setup", {})
3426
if setup_block:
35-
setup_requests = normalize_list(setup_block.get("request"))
36-
for req in setup_requests:
27+
for req in cast(List[Dict[str, Any]], setup_block.get("requests", [])):
3728
self._run_request(impl, req, now_ms)
3829

3930
# Request phase
@@ -79,7 +70,7 @@ def _run_request(self, impl: RendezqueueImpl, req: Dict[str, Any], now_ms: float
7970
msg["b64"] = req["b64"]
8071

8172
if "values" in req:
82-
msg["values"] = normalize_list(req["values"])
73+
msg["values"] = req["values"]
8374

8475
return impl.tryswap(msg, now_ms=now_ms)
8576

@@ -109,9 +100,8 @@ def _verify_response(self, actual, expected, case_name):
109100
pass
110101

111102
if "values" in expected:
112-
expected_values = normalize_list(expected["values"])
113103
self.assertEqual(
114-
actual.values, expected_values, f"Case {case_name}: Values mismatch"
104+
actual.values, expected["values"], f"Case {case_name}: Values mismatch"
115105
)
116106
else:
117107
# Expect no values

test/server_test_cases.sxpb

Lines changed: 46 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@
2121
(()
2222
(name "2. Match existing offer")
2323
(setup
24-
(request
25-
(key "k1")
26-
(sid "s1")
27-
(offset 0)
28-
(values (()) "val1")
29-
(ttl 10)
24+
(requests (())
25+
(()
26+
(key "k1")
27+
(sid "s1")
28+
(offset 0)
29+
(values (()) "val1")
30+
(ttl 10)
31+
)
3032
)
3133
)
3234
(now_ms 1000)
@@ -48,19 +50,21 @@
4850
(()
4951
(name "3. Poll matched offer (s1)")
5052
(setup
51-
(request
52-
(key "k1")
53-
(sid "s1")
54-
(offset 0)
55-
(values (()) "val1")
56-
(ttl 10)
57-
)
58-
(request
59-
(key "k1")
60-
(sid "s2")
61-
(offset 0)
62-
(values (()) "val2")
63-
(ttl 10)
53+
(requests (())
54+
(()
55+
(key "k1")
56+
(sid "s1")
57+
(offset 0)
58+
(values (()) "val1")
59+
(ttl 10)
60+
)
61+
(()
62+
(key "k1")
63+
(sid "s2")
64+
(offset 0)
65+
(values (()) "val2")
66+
(ttl 10)
67+
)
6468
)
6569
)
6670
(now_ms 1000)
@@ -80,12 +84,14 @@
8084
(()
8185
(name "4. Partial match / Append")
8286
(setup
83-
(request
84-
(key "k1")
85-
(sid "s1")
86-
(offset 0)
87-
(values (()) "v1")
88-
(ttl 10)
87+
(requests (())
88+
(()
89+
(key "k1")
90+
(sid "s1")
91+
(offset 0)
92+
(values (()) "v1")
93+
(ttl 10)
94+
)
8995
)
9096
)
9197
(now_ms 1000)
@@ -138,19 +144,21 @@
138144
(()
139145
(name "7. Multiple values swap")
140146
(setup
141-
(request
142-
(key "k_multi")
143-
(sid "s_multi_1")
144-
(offset 0)
145-
(values (()) "val_a1")
146-
(ttl 10)
147-
)
148-
(request
149-
(key "k_multi")
150-
(sid "s_multi_1")
151-
(offset 1)
152-
(values (()) "val_a2")
153-
(ttl 10)
147+
(requests (())
148+
(()
149+
(key "k_multi")
150+
(sid "s_multi_1")
151+
(offset 0)
152+
(values (()) "val_a1")
153+
(ttl 10)
154+
)
155+
(()
156+
(key "k_multi")
157+
(sid "s_multi_1")
158+
(offset 1)
159+
(values (()) "val_a2")
160+
(ttl 10)
161+
)
154162
)
155163
)
156164
(now_ms 1000)

0 commit comments

Comments
 (0)