Skip to content

Commit 52c7e4a

Browse files
committed
We still don't want moduledoc false in modules without it
1 parent 93dc8e4 commit 52c7e4a

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

lib/style/module_directives.ex

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ defmodule Styler.Style.ModuleDirectives do
2121
2222
* `Credo.Check.Consistency.MultiAliasImportRequireUse` (force expansion)
2323
* `Credo.Check.Readability.AliasOrder` (we sort `__MODULE__`, which credo doesn't)
24-
* `Credo.Check.Readability.ModuleDoc` (adds `@moduledoc false` if missing. includes `*.exs` files)
2524
* `Credo.Check.Readability.MultiAlias`
2625
* `Credo.Check.Readability.StrictModuleLayout` (see section below for details)
2726
* `Credo.Check.Readability.UnnecessaryAliasExpansion`
@@ -50,7 +49,6 @@ defmodule Styler.Style.ModuleDirectives do
5049
@directives ~w(alias import require use)a
5150
@attr_directives ~w(moduledoc shortdoc behaviour)a
5251
@defstruct ~w(schema embedded_schema defstruct)a
53-
@moduledoc_false {:@, [line: nil], [{:moduledoc, [line: nil], [{:__block__, [line: nil], [false]}]}]}
5452

5553
def run({{:defmodule, _, children}, _} = zipper, ctx) do
5654
[name, [{{:__block__, do_meta, [:do]}, _body}]] = children
@@ -132,14 +130,6 @@ defmodule Styler.Style.ModuleDirectives do
132130

133131
def run(zipper, ctx), do: {:cont, zipper, ctx}
134132

135-
defp moduledoc({:__aliases__, m, aliases}) do
136-
name = aliases |> List.last() |> to_string()
137-
# module names ending with these suffixes will not have a default moduledoc appended
138-
if !String.ends_with?(name, ~w(Test Mixfile MixProject Controller Endpoint Repo Router Socket View HTML JSON)) do
139-
Style.set_line(@moduledoc_false, m[:line] + 1)
140-
end
141-
end
142-
143133
# a dynamic module name, like `defmodule my_variable do ... end`
144134
defp moduledoc(_), do: nil
145135

0 commit comments

Comments
 (0)