Complex write reference evaluators removed

Author: remorhaz

src/Pointer/Evaluate/Advancer.php

@@ -44,6 +44,14 @@ abstract public function advance();
      */
     abstract public function write($data);
 
+
+    public function canWrite()
+    {
+        return $this
+            ->getReference()
+            ->isLast();
+    }
+
     /**
      * @return $this
      * @throws EvaluateException

src/Pointer/Evaluate/AdvancerNonNumericIndex.php

@@ -29,6 +29,12 @@ public function canAdvance()
     }
 
 
+    public function canWrite()
+    {
+        return $this->isAllowed && parent::canWrite();
+    }
+
+
     public function fail()
     {
         if ($this->isAllowed) {

src/Pointer/Evaluate/AdvancerNumericIndex.php

@@ -5,6 +5,22 @@
 class AdvancerNumericIndex extends AdvancerIndex
 {
 
+    protected $areAllowedGaps = false;
+
+
+    public function allowGaps()
+    {
+        $this->areAllowedGaps = true;
+        return $this;
+    }
+
+
+    public function forbidGaps()
+    {
+        $this->areAllowedGaps = true;
+        return $this;
+    }
+
 
     public function getValue()
     {
@@ -16,4 +32,18 @@ public function getValueDescription()
     {
         return "{$this->getValue()}";
     }
+
+
+    public function canWrite()
+    {
+        if (!parent::canWrite()) {
+            return false;
+        }
+        if ($this->areAllowedGaps) {
+            return true;
+        }
+        return
+            0 == $this->getValue() && empty($this->getDataCursor()) ||
+            array_key_exists($this->getValue() - 1, $this->getDataCursor());
+    }
 }

src/Pointer/Evaluate/ReferenceAdvanceable.php

@@ -20,10 +20,6 @@ protected function getAdvancer()
     {
         if (null === $this->advancer) {
             throw new LogicException("Advancer is not set in reference evaluator");
-            /*$this->advancer = $this
-                ->createAdvancer()
-                ->setReference($this->getReference())
-                ->setDataCursor($this->getDataCursor());*/
         }
         return $this->advancer;
     }

src/Pointer/Evaluate/ReferenceWrite.php

@@ -2,9 +2,9 @@
 
 namespace Remorhaz\JSONPointer\Pointer\Evaluate;
 
-abstract class ReferenceWrite extends ReferenceAdvanceable
+class ReferenceWrite extends ReferenceAdvanceable
 {
-    
+
     protected $value;
 
     protected $isValueSet = false;
@@ -25,4 +25,34 @@ protected function getValue()
         }
         return $this->value;
     }
+
+
+    protected function performNonExisting()
+    {
+        $canWrite = $this
+            ->getAdvancer()
+            ->canWrite();
+        return $canWrite
+            ? $this->write()
+            : $this->failWrite();
+    }
+
+
+    protected function write()
+    {
+        $this
+            ->getAdvancer()
+            ->write($this->getValue());
+        $result = null;
+        return $this->setResult($result);
+    }
+
+
+    protected function failWrite()
+    {
+        $this
+            ->getAdvancer()
+            ->fail();
+        return $this;
+    }
 }

src/Pointer/Evaluate/ReferenceWriteAllowedNonNumericIndex.php

@@ -27,38 +27,42 @@ public function forbidNumericIndexGaps()
 
     protected function createProperty()
     {
-        return ReferenceWriteProperty::factory()
+        return ReferenceWrite::factory()
             ->setAdvancer(AdvancerProperty::factory());
     }
 
 
     protected function createNextIndex()
     {
-        return ReferenceWriteNextIndex::factory()
+        return ReferenceWrite::factory()
             ->setAdvancer(AdvancerNextIndex::factory());
     }
 
 
     protected function createNumericIndex()
     {
-        return $this->numericIndexGaps
-            ? ReferenceWriteNumericIndexWithGaps::factory()
-                ->setAdvancer(AdvancerNumericIndex::factory())
-            : ReferenceWriteNumericIndexWithoutGaps::factory()
-                ->setAdvancer(AdvancerNumericIndex::factory());
+        $advancer = AdvancerNumericIndex::factory();
+        if ($this->numericIndexGaps) {
+            $advancer->allowGaps();
+        }
+        return ReferenceWrite::factory()
+            ->setAdvancer($advancer);
     }
 
 
     protected function createAllowedNonNumericIndex()
     {
-        return ReferenceWriteAllowedNonNumericIndex::factory()
-            ->setAdvancer(AdvancerNonNumericIndex::factory());
+        $advancer = AdvancerNonNumericIndex::factory()
+            ->allow();
+        return ReferenceWrite::factory()
+            ->setAdvancer($advancer);
     }
 
 
     protected function createNotAllowedNonNumericIndex()
     {
-        return ReferenceWriteNotAllowedNonNumericIndex::factory();
+        return ReferenceWrite::factory()
+            ->setAdvancer(AdvancerNonNumericIndex::factory());
     }