refactor(sse-test-client): use existing coaching data or create if needed

calebbourg · calebbourg · commit 54303f059012 · 2025-12-16T08:56:22.000-05:00
Update test client to query for existing coaching relationships and sessions
before attempting to create new ones. This prevents errors when using seeded
database with pre-existing coaching relationships.

Changes:
- Add get_coaching_relationships() and get_coaching_sessions() methods
- Update setup_test_environment() to check for existing data first
- Fall back to creating new relationships/sessions only if needed
- Update messaging to reflect "Using" instead of "Created"
- Update README to clarify that seeded data is preferred and will be used
diff --git a/sse-test-client/README.md b/sse-test-client/README.md
@@ -7,16 +7,16 @@ A standalone Rust binary for testing Server-Sent Events (SSE) functionality with
 This tool validates the SSE infrastructure by:
 1. Authenticating two users (typically a coach and coachee)
 2. Establishing SSE connections for both users
-3. Optionally creating a test coaching relationship and session (for action tests)
+3. Using existing coaching relationships/sessions or creating them if needed (for action tests)
 4. Triggering events (create/update/delete actions, force logout)
 5. Verifying that the correct SSE events are received by the appropriate users
 
 ## Prerequisites
 
 - Backend server running (default: `http://localhost:4000`)
-- Two valid user accounts with credentials
-- **For action tests only**: Users must have admin permission to create coaching relationships
-- **For connection test**: No special permissions required
+- Two valid user accounts with credentials (seeded users recommended)
+- **For action tests**: An existing coaching relationship between the users (will be created if it doesn't exist)
+- **For connection test**: No special permissions or relationships required
 
 ## Usage
 
@@ -82,12 +82,12 @@ cargo run -p sse-test-client -- \
 
 ## Available Scenarios
 
-- `connection-test` - Tests basic SSE connectivity without creating any data (no admin permissions required)
-- `action-create` - Tests SSE events for action creation (requires admin permissions)
-- `action-update` - Tests SSE events for action updates (requires admin permissions)
-- `action-delete` - Tests SSE events for action deletion (requires admin permissions)
-- `force-logout-test` - Tests SSE events for force logout (requires admin permissions, NOT YET IMPLEMENTED)
-- `all` - Runs all test scenarios sequentially (requires admin permissions for action tests)
+- `connection-test` - Tests basic SSE connectivity without creating any data
+- `action-create` - Tests SSE events for action creation (uses existing coaching relationship or creates one)
+- `action-update` - Tests SSE events for action updates (uses existing coaching relationship or creates one)
+- `action-delete` - Tests SSE events for action deletion (uses existing coaching relationship or creates one)
+- `force-logout-test` - Tests SSE events for force logout (NOT YET IMPLEMENTED)
+- `all` - Runs all test scenarios sequentially
 
 ## Command-Line Arguments
 
@@ -103,7 +103,7 @@ cargo run -p sse-test-client -- \
 
 ### Setup Phase
 1. Authenticates both users and obtains session cookies
-2. For action tests: Creates a coaching relationship and session between the users
+2. For action tests: Finds existing coaching relationship/session or creates new ones if needed
 3. For connection test: Skips coaching data setup
 4. Establishes SSE connections for both users
 
@@ -153,16 +153,16 @@ Results: 1 passed, 0 failed
 All tests passed! ✓
 ```
 
-### Action Test (Requires Admin)
+### Action Test
 ```
 === SETUP PHASE ===
 → Authenticating users...
 ✓ User 1 authenticated (ID: 123e4567-e89b-12d3-a456-426614174000)
 ✓ User 2 authenticated (ID: 234e5678-e89b-12d3-a456-426614174001)
 
-→ Creating test coaching relationship and session...
-✓ Coaching relationship created (ID: 345e6789-e89b-12d3-a456-426614174002)
-✓ Coaching session created (ID: 456e789a-e89b-12d3-a456-426614174003)
+→ Setting up test coaching relationship and session...
+✓ Using coaching relationship (ID: 345e6789-e89b-12d3-a456-426614174002)
+✓ Using coaching session (ID: 456e789a-e89b-12d3-a456-426614174003)
 
 → Establishing SSE connections...
 ✓ User 1 SSE connection established
diff --git a/sse-test-client/src/api_client.rs b/sse-test-client/src/api_client.rs
@@ -31,25 +31,56 @@ impl ApiClient {
             .as_str()
             .context("No organization ID found")?;
 
-        // Create coaching relationship
-        let relationship = self
-            .create_coaching_relationship(coach_session, organization_id, coach_id, coachee_id)
+        // Query for existing coaching relationships
+        let relationships = self
+            .get_coaching_relationships(coach_session, organization_id)
             .await?;
 
-        let relationship_id = relationship["id"]
-            .as_str()
-            .context("No relationship ID in response")?
-            .to_string();
-
-        // Create coaching session
-        let session = self
-            .create_coaching_session(coach_session, &relationship_id)
+        // Find existing relationship or create new one
+        let relationship_id = if let Some(relationship) = relationships.as_array().and_then(|arr| {
+            arr.iter().find(|rel| {
+                rel["coach_id"].as_str() == Some(coach_id)
+                    && rel["coachee_id"].as_str() == Some(coachee_id)
+            })
+        }) {
+            relationship["id"]
+                .as_str()
+                .context("No relationship ID in existing relationship")?
+                .to_string()
+        } else {
+            // Create new coaching relationship
+            let relationship = self
+                .create_coaching_relationship(coach_session, organization_id, coach_id, coachee_id)
+                .await?;
+
+            relationship["id"]
+                .as_str()
+                .context("No relationship ID in response")?
+                .to_string()
+        };
+
+        // Query for existing coaching sessions
+        let sessions = self
+            .get_coaching_sessions(coach_session, &relationship_id)
             .await?;
 
-        let session_id = session["id"]
-            .as_str()
-            .context("No session ID in response")?
-            .to_string();
+        // Use existing session or create new one
+        let session_id = if let Some(session) = sessions.as_array().and_then(|arr| arr.first()) {
+            session["id"]
+                .as_str()
+                .context("No session ID in existing session")?
+                .to_string()
+        } else {
+            // Create new coaching session
+            let session = self
+                .create_coaching_session(coach_session, &relationship_id)
+                .await?;
+
+            session["id"]
+                .as_str()
+                .context("No session ID in response")?
+                .to_string()
+        };
 
         Ok(TestEnvironment {
             relationship_id,
@@ -91,6 +122,88 @@ impl ApiClient {
             .map(|arr| Value::Array(arr.clone()))
     }
 
+    async fn get_coaching_relationships(
+        &self,
+        session_cookie: &str,
+        organization_id: &str,
+    ) -> Result<Value> {
+        let url = format!(
+            "{}/organizations/{}/coaching_relationships",
+            self.base_url, organization_id
+        );
+
+        let response = self
+            .client
+            .get(&url)
+            .header("Cookie", format!("id={}", session_cookie))
+            .header("x-version", "1.0.0-beta1")
+            .send()
+            .await
+            .context("Failed to get coaching relationships")?;
+
+        if !response.status().is_success() {
+            let status = response.status();
+            let body = response
+                .text()
+                .await
+                .unwrap_or_else(|_| "Unable to read response body".to_string());
+            anyhow::bail!(
+                "Failed to get coaching relationships: {} - Response: {}",
+                status,
+                body
+            );
+        }
+
+        let api_response: Value = response.json().await.context("Failed to parse response")?;
+
+        // Extract the data array from ApiResponse wrapper
+        api_response["data"]
+            .as_array()
+            .context("No data array in response")
+            .map(|arr| Value::Array(arr.clone()))
+    }
+
+    async fn get_coaching_sessions(
+        &self,
+        session_cookie: &str,
+        relationship_id: &str,
+    ) -> Result<Value> {
+        let url = format!(
+            "{}/coaching_relationships/{}/coaching_sessions",
+            self.base_url, relationship_id
+        );
+
+        let response = self
+            .client
+            .get(&url)
+            .header("Cookie", format!("id={}", session_cookie))
+            .header("x-version", "1.0.0-beta1")
+            .send()
+            .await
+            .context("Failed to get coaching sessions")?;
+
+        if !response.status().is_success() {
+            let status = response.status();
+            let body = response
+                .text()
+                .await
+                .unwrap_or_else(|_| "Unable to read response body".to_string());
+            anyhow::bail!(
+                "Failed to get coaching sessions: {} - Response: {}",
+                status,
+                body
+            );
+        }
+
+        let api_response: Value = response.json().await.context("Failed to parse response")?;
+
+        // Extract the data array from ApiResponse wrapper
+        api_response["data"]
+            .as_array()
+            .context("No data array in response")
+            .map(|arr| Value::Array(arr.clone()))
+    }
+
     async fn create_coaching_relationship(
         &self,
         session_cookie: &str,
diff --git a/sse-test-client/src/main.rs b/sse-test-client/src/main.rs
@@ -99,7 +99,7 @@ async fn main() -> Result<()> {
         }
         _ => {
             println!(
-                "\n{} Creating test coaching relationship and session...",
+                "\n{} Setting up test coaching relationship and session...",
                 "→".blue()
             );
             let env = api_client
@@ -112,12 +112,12 @@ async fn main() -> Result<()> {
                 .await?;
 
             println!(
-                "{} Coaching relationship created (ID: {})",
+                "{} Using coaching relationship (ID: {})",
                 "✓".green(),
                 env.relationship_id
             );
             println!(
-                "{} Coaching session created (ID: {})",
+                "{} Using coaching session (ID: {})",
                 "✓".green(),
                 env.session_id
             );
