fix(ui): avoid stale closure when clearing connectivity error

Always dispatch setConnectivityError(null) on successful API response
instead of conditionally checking connectivityError. This avoids stale
closure issues where the callback captures an outdated value.

Also removes the unused handleRefreshClick callback since onRefreshClicked
is not needed - loadData() is already called via onRefresh.

References: #RI-7761

Author: pawelangelow

redisinsight/ui/src/components/database-overview/DatabaseOverview.tsx

@@ -30,7 +30,6 @@ const DatabaseOverview = () => {
     isBdbPackages,
     lastRefreshTime,
     handleEnableAutoRefresh,
-    handleRefreshClick,
     handleRefresh,
   } = useDatabaseOverview()
 
@@ -102,7 +101,6 @@ const DatabaseOverview = () => {
                       DATABASE_OVERVIEW_MINIMUM_REFRESH_INTERVAL,
                     )}
                     onRefresh={handleRefresh}
-                    onRefreshClicked={handleRefreshClick}
                     onEnableAutoRefresh={handleEnableAutoRefresh}
                   />
                 </FlexItem>

redisinsight/ui/src/components/database-overview/hooks/useDatabaseOverview.spec.ts

@@ -96,7 +96,6 @@ describe('useDatabaseOverview', () => {
     expect(data.isBdbPackages).toBeUndefined()
     expect(data.usedMemoryPercent).toBeUndefined()
     expect(typeof data.handleRefresh).toBe('function')
-    expect(typeof data.handleRefreshClick).toBe('function')
     expect(typeof data.handleEnableAutoRefresh).toBe('function')
   })
 
@@ -157,22 +156,6 @@ describe('useDatabaseOverview', () => {
     expect(actions).toContainEqual(getDatabaseConfigInfo())
   })
 
-  it('should handle refresh click correctly (no-op)', () => {
-    // handleRefreshClick is intentionally a no-op.
-    // AutoRefresh.handleRefreshClick calls onRefresh() before onRefreshClicked(),
-    // so loadData() is already called via handleRefresh.
-    mockedStore.clearActions()
-
-    const data = renderHelper(mockedStore)
-    act(() => {
-      data.handleRefreshClick()
-    })
-
-    const actions = mockedStore.getActions()
-    // handleRefreshClick should not dispatch any actions
-    expect(actions).toHaveLength(0)
-  })
-
   it('should send telemetry event when auto-refresh is enabled', () => {
     const data = renderHelper(mockedStore)
     act(() => {

redisinsight/ui/src/components/database-overview/hooks/useDatabaseOverview.ts

@@ -52,10 +52,10 @@ export const useDatabaseOverview = () => {
     if (connectedInstanceId) {
       dispatch(
         getDatabaseConfigInfoAction(connectedInstanceId, () => {
-          // Clear connectivity error on successful API call
-          if (connectivityError) {
-            dispatch(setConnectivityError(null))
-          }
+          // Clear connectivity error on successful API call.
+          // Always dispatch to avoid stale closure issues - dispatching null
+          // when there's no error is a safe no-op.
+          dispatch(setConnectivityError(null))
         }),
       )
       setLastRefreshTime(Date.now())
@@ -85,11 +85,6 @@ export const useDatabaseOverview = () => {
   const handleRefresh = () => {
     loadData()
   }
-  // Note: handleRefreshClick is intentionally a no-op.
-  // AutoRefresh.handleRefreshClick calls onRefresh() before onRefreshClicked(),
-  // so loadData() is already called via handleRefresh. This callback exists only
-  // for cases where additional side effects are needed on manual click.
-  const handleRefreshClick = () => {}
   const usedMemoryPercent = getUsedMemoryPercent(
     planMemoryLimit,
     usedMemory,
@@ -117,6 +112,5 @@ export const useDatabaseOverview = () => {
     usedMemoryPercent,
     handleEnableAutoRefresh,
     handleRefresh,
-    handleRefreshClick,
   }
 }