Skip to content

Commit a02fcc4

Browse files
Adds ssl min version
Signed-off-by: Elena Kolevska <elena@kolevska.com>
1 parent 6361fe0 commit a02fcc4

File tree

4 files changed

+3
-16
lines changed

4 files changed

+3
-16
lines changed

.env.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ REDIS_SSL_CHECK_HOSTNAME=true
1616
REDIS_SSL_PASSWORD=
1717
REDIS_SSL_VALIDATE_OCSP=false
1818
REDIS_SSL_VALIDATE_OCSP_STAPLED=false
19+
REDIS_SSL_MIN_VERSION=
1920
REDIS_SSL_CIPHERS=
2021
REDIS_RELAXED_TIMEOUT=
2122
REDIS_SOCKET_TIMEOUT=5.0

cli.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,7 @@ def describe_profile(profile_name):
127127
@click.option('--ssl-ca-data', default=lambda: get_env_or_default('REDIS_SSL_CA_DATA', None), help='CA certificate data as string')
128128
@click.option('--ssl-check-hostname', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL_CHECK_HOSTNAME', True, bool), help='Check SSL hostname')
129129
@click.option('--ssl-password', default=lambda: get_env_or_default('REDIS_SSL_PASSWORD', None), help='Password for SSL private key')
130-
@click.option('--ssl-validate-ocsp', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL_VALIDATE_OCSP', False, bool), help='Validate OCSP')
131-
@click.option('--ssl-validate-ocsp-stapled', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL_VALIDATE_OCSP_STAPLED', False, bool), help='Validate OCSP stapled')
130+
@click.option('--ssl-min-version', default=lambda: get_env_or_default('REDIS_SSL_MIN_VERSION', None), help='Minimum SSL/TLS version')
132131
@click.option('--ssl-ciphers', default=lambda: get_env_or_default('REDIS_SSL_CIPHERS', None), help='SSL cipher suite')
133132
@click.option('--socket-timeout', type=float, default=lambda: get_env_or_default('REDIS_SOCKET_TIMEOUT', None), help='Socket timeout in seconds')
134133
@click.option('--socket-connect-timeout', type=float, default=lambda: get_env_or_default('REDIS_SOCKET_CONNECT_TIMEOUT', None), help='Socket connect timeout in seconds')
@@ -301,8 +300,7 @@ def _build_config_from_args(kwargs) -> RunnerConfig:
301300
ssl_ca_data=kwargs['ssl_ca_data'],
302301
ssl_check_hostname=kwargs['ssl_check_hostname'],
303302
ssl_password=kwargs['ssl_password'],
304-
ssl_validate_ocsp=kwargs['ssl_validate_ocsp'],
305-
ssl_validate_ocsp_stapled=kwargs['ssl_validate_ocsp_stapled'],
303+
ssl_min_version=kwargs['ssl_min_version'],
306304
ssl_ciphers=kwargs['ssl_ciphers'],
307305
socket_timeout=kwargs['socket_timeout'],
308306
socket_connect_timeout=kwargs['socket_connect_timeout'],

config.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ class RedisConnectionConfig:
9898
ssl_ca_data: Optional[str] = None
9999
ssl_check_hostname: bool = True
100100
ssl_password: Optional[str] = None
101-
ssl_validate_ocsp: bool = False
102-
ssl_validate_ocsp_stapled: bool = False
103-
ssl_ocsp_context: Optional[Any] = None # OpenSSL.SSL.Context
104-
ssl_ocsp_expected_cert: Optional[str] = None
105101
ssl_min_version: Optional[Any] = None # ssl.TLSVersion
106102
ssl_ciphers: Optional[str] = None
107103

redis_client.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,6 @@ def _build_pool_kwargs(self) -> Dict[str, Any]:
7777
ssl_kwargs['ssl_check_hostname'] = self.config.ssl_check_hostname
7878
if self.config.ssl_password is not None:
7979
ssl_kwargs['ssl_password'] = self.config.ssl_password
80-
if self.config.ssl_validate_ocsp is not None:
81-
ssl_kwargs['ssl_validate_ocsp'] = self.config.ssl_validate_ocsp
82-
if self.config.ssl_validate_ocsp_stapled is not None:
83-
ssl_kwargs['ssl_validate_ocsp_stapled'] = self.config.ssl_validate_ocsp_stapled
84-
if self.config.ssl_ocsp_context is not None:
85-
ssl_kwargs['ssl_ocsp_context'] = self.config.ssl_ocsp_context
86-
if self.config.ssl_ocsp_expected_cert is not None:
87-
ssl_kwargs['ssl_ocsp_expected_cert'] = self.config.ssl_ocsp_expected_cert
8880
if self.config.ssl_min_version is not None:
8981
ssl_kwargs['ssl_min_version'] = self.config.ssl_min_version
9082
if self.config.ssl_ciphers is not None:

0 commit comments

Comments
 (0)