Skip to content

Commit 7d1dbba

Browse files
Updates to beta2
Signed-off-by: Elena Kolevska <elena@kolevska.com>
1 parent 70c95d4 commit 7d1dbba

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

.env.example

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ REDIS_PASSWORD=
55
REDIS_DB=0
66
REDIS_CLUSTER=false
77
REDIS_CLUSTER_NODES=
8-
REDIS_SSL=false
8+
REDIS_SSL_ENABLED=false
99
REDIS_SSL_KEYFILE=
1010
REDIS_SSL_CERTFILE=
1111
REDIS_SSL_CERT_REQS=required
@@ -14,8 +14,6 @@ REDIS_SSL_CA_PATH=
1414
REDIS_SSL_CA_DATA=
1515
REDIS_SSL_CHECK_HOSTNAME=true
1616
REDIS_SSL_PASSWORD=
17-
REDIS_SSL_VALIDATE_OCSP=false
18-
REDIS_SSL_VALIDATE_OCSP_STAPLED=false
1917
REDIS_SSL_MIN_VERSION=
2018
REDIS_SSL_CIPHERS=
2119
REDIS_RELAXED_TIMEOUT=

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ make start
3535

3636
```bash
3737
# Install dependencies
38-
make install-deps
38+
make install-deps-venv
3939

4040
# Test Redis connection
4141
make test-connection

cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def describe_profile(profile_name):
118118
@click.option('--db', type=int, default=lambda: get_env_or_default('REDIS_DB', 0, int), help='Redis database number')
119119
@click.option('--cluster', is_flag=True, default=lambda: get_env_or_default('REDIS_CLUSTER', False, bool), help='Use Redis Cluster mode')
120120
@click.option('--cluster-nodes', default=lambda: get_env_or_default('REDIS_CLUSTER_NODES', None), help='Comma-separated list of cluster nodes (host:port)')
121-
@click.option('--ssl', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL', False, bool), help='Use SSL/TLS connection')
121+
@click.option('--ssl', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL_ENABLED', False, bool), help='Use SSL/TLS connection')
122122
@click.option('--ssl-keyfile', default=lambda: get_env_or_default('REDIS_SSL_KEYFILE', None), help='Path to client private key file')
123123
@click.option('--ssl-certfile', default=lambda: get_env_or_default('REDIS_SSL_CERTFILE', None), help='Path to client certificate file')
124124
@click.option('--ssl-cert-reqs', default=lambda: get_env_or_default('REDIS_SSL_CERT_REQS', 'required'), type=click.Choice(['none', 'optional', 'required']), help='SSL certificate requirements')
@@ -127,7 +127,7 @@ def describe_profile(profile_name):
127127
@click.option('--ssl-ca-data', default=lambda: get_env_or_default('REDIS_SSL_CA_DATA', None), help='CA certificate data as string')
128128
@click.option('--ssl-check-hostname', is_flag=True, default=lambda: get_env_or_default('REDIS_SSL_CHECK_HOSTNAME', True, bool), help='Check SSL hostname')
129129
@click.option('--ssl-password', default=lambda: get_env_or_default('REDIS_SSL_PASSWORD', None), help='Password for SSL private key')
130-
@click.option('--ssl-min-version', default=lambda: get_env_or_default('REDIS_SSL_MIN_VERSION', None), help='Minimum SSL/TLS version (TLSv1, TLSv1_1, TLSv1_2, TLSv1_3 or 1.0, 1.1, 1.2, 1.3)')
130+
@click.option('--ssl-min-version', default=lambda: get_env_or_default('REDIS_SSL_MIN_VERSION', 'TLSv1_2'), help='Minimum SSL/TLS version (TLSv1, TLSv1_1, TLSv1_2, TLSv1_3 or 1.0, 1.1, 1.2, 1.3). Default: TLSv1_2 for Redis Enterprise compatibility')
131131
@click.option('--ssl-ciphers', default=lambda: get_env_or_default('REDIS_SSL_CIPHERS', None), help='SSL cipher suite')
132132
@click.option('--socket-timeout', type=float, default=lambda: get_env_or_default('REDIS_SOCKET_TIMEOUT', None), help='Socket timeout in seconds')
133133
@click.option('--socket-connect-timeout', type=float, default=lambda: get_env_or_default('REDIS_SOCKET_CONNECT_TIMEOUT', None), help='Socket connect timeout in seconds')

redis_client.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import redis
88
import redis.sentinel
99
from redis.cluster import RedisCluster
10+
from redis.maint_notifications import MaintNotificationsConfig
1011
from redis.retry import Retry
1112
from redis.backoff import ExponentialWithJitterBackoff
1213
from redis.exceptions import (
@@ -134,7 +135,11 @@ def _build_pool_kwargs(self) -> Dict[str, Any]:
134135
if self.config.ssl_password is not None:
135136
ssl_kwargs['ssl_password'] = self.config.ssl_password
136137
if self.config.ssl_min_version is not None:
137-
ssl_kwargs['ssl_min_version'] = _convert_ssl_min_version(self.config.ssl_min_version)
138+
# Handle both string and TLSVersion objects
139+
if isinstance(self.config.ssl_min_version, str):
140+
ssl_kwargs['ssl_min_version'] = _convert_ssl_min_version(self.config.ssl_min_version)
141+
else:
142+
ssl_kwargs['ssl_min_version'] = self.config.ssl_min_version
138143
if self.config.ssl_ciphers is not None:
139144
ssl_kwargs['ssl_ciphers'] = self.config.ssl_ciphers
140145

@@ -171,20 +176,20 @@ def _connect_standalone(self):
171176
"""Connect to standalone Redis instance."""
172177
start_time = time.time()
173178

174-
print("\n\n\n ------- Pool kwargs:", {**self._pool_kwargs})
179+
print("\n\n---- Args:" + str(self._pool_kwargs))
175180

176181
if self.config.maintenance_notifications_enabled:
177182
# Build maintenance events config, only passing relaxed_timeouts if not None
178183
maintenance_config_kwargs = {"enabled": self.config.maintenance_notifications_enabled}
179184
if self.config.maintenance_relaxed_timeout is not None:
180-
maintenance_config_kwargs["relaxed_timeouts"] = self.config.maintenance_relaxed_timeout
185+
maintenance_config_kwargs["relaxed_timeout"] = self.config.maintenance_relaxed_timeout
181186

182187

183188
self._client = redis.Redis(
184189
host=self.config.host,
185190
port=self.config.port,
186191
db=self.config.database,
187-
maintenance_events_config=redis.maintenance_events.MaintenanceEventsConfig(**maintenance_config_kwargs),
192+
maint_notifications_config=MaintNotificationsConfig(**maintenance_config_kwargs),
188193
protocol=self.config.protocol,
189194
**self._pool_kwargs
190195
)

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
redis==7.0.0b1
1+
redis==7.0.0b2
22
#redis==6.4.0
33
click>=8.0.0
44
prometheus-client>=0.16.0

0 commit comments

Comments
 (0)