Skip to content

Commit 5f56e4a

Browse files
removes unneeded params
Signed-off-by: Elena Kolevska <elena@kolevska.com>
1 parent 26db974 commit 5f56e4a

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

cli.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,9 @@ def cli():
7979
@click.option('--transaction-size', type=int, default=lambda: get_env_or_default('TEST_TRANSACTION_SIZE', 5, int), help='Number of operations per transaction')
8080
@click.option('--log-level', default=lambda: get_env_or_default('LOG_LEVEL', 'INFO'), type=click.Choice(['DEBUG', 'INFO', 'WARNING', 'ERROR']), help='Logging level')
8181
@click.option('--log-file', default=lambda: get_env_or_default('LOG_FILE', None), help='Log file path')
82-
@click.option('--metrics-enabled/--no-metrics', default=lambda: get_env_or_default('METRICS_ENABLED', True, bool), help='Enable metrics collection')
83-
@click.option('--metrics-port', type=int, default=lambda: get_env_or_default('METRICS_PORT', 8000, int), help='Prometheus metrics server port')
82+
8483
@click.option('--metrics-interval', type=int, default=lambda: get_env_or_default('METRICS_INTERVAL', 5, int), help='Metrics reporting interval in seconds')
85-
@click.option('--otel-enabled', is_flag=True, default=lambda: get_env_or_default('OTEL_ENABLED', True, bool), help='Enable OpenTelemetry')
84+
8685
@click.option('--otel-endpoint', default=lambda: get_env_or_default('OTEL_EXPORTER_OTLP_ENDPOINT', None), help='OpenTelemetry OTLP endpoint')
8786
@click.option('--otel-service-name', default=lambda: get_env_or_default('OTEL_SERVICE_NAME', 'redis-load-test'), help='OpenTelemetry service name')
8887
@click.option('--otel-export-interval', type=int, default=lambda: get_env_or_default('OTEL_EXPORT_INTERVAL', 5000, int), help='OpenTelemetry export interval in milliseconds')
@@ -316,12 +315,9 @@ def _build_config_from_args(kwargs) -> RunnerConfig:
316315
test=test_config,
317316
log_level=kwargs['log_level'],
318317
log_file=kwargs['log_file'],
319-
metrics_enabled=kwargs['metrics_enabled'],
320-
metrics_port=kwargs['metrics_port'],
321318
metrics_interval=kwargs['metrics_interval'],
322319
output_file=kwargs['output_file'],
323320
quiet=kwargs['quiet'],
324-
otel_enabled=kwargs['otel_enabled'],
325321
otel_endpoint=kwargs['otel_endpoint'],
326322
otel_service_name=kwargs['otel_service_name'],
327323
otel_export_interval_ms=kwargs['otel_export_interval'],

config.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,19 +186,16 @@ class RunnerConfig:
186186
redis: RedisConnectionConfig = field(default_factory=RedisConnectionConfig)
187187
test: TestConfig = field(default_factory=TestConfig)
188188

189-
# Logging and metrics (keeping from original implementation)
189+
# Logging and metrics
190190
log_level: str = "INFO"
191191
log_file: Optional[str] = None
192-
metrics_enabled: bool = True
193-
metrics_port: int = 8000
194192
metrics_interval: int = 5
195193

196194
# Output
197195
output_file: Optional[str] = None
198196
quiet: bool = False
199197

200198
# OpenTelemetry configuration
201-
otel_enabled: bool = True
202199
otel_endpoint: Optional[str] = None
203200
otel_service_name: str = "redis-py-test-app"
204201
otel_service_version: str = "1.0.0"
@@ -343,12 +340,9 @@ def save_config_to_file(config: RunnerConfig, file_path: str):
343340
},
344341
'log_level': config.log_level,
345342
'log_file': config.log_file,
346-
'metrics_enabled': config.metrics_enabled,
347-
'metrics_port': config.metrics_port,
348343
'metrics_interval': config.metrics_interval,
349344
'output_file': config.output_file,
350345
'quiet': config.quiet,
351-
'otel_enabled': config.otel_enabled,
352346
'otel_endpoint': config.otel_endpoint,
353347
'otel_service_name': config.otel_service_name,
354348
'otel_service_version': config.otel_service_version,

main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Features:
99
- Multi-threaded architecture supporting 100K+ ops/sec
1010
- Support for standalone and cluster Redis deployments
11-
- Comprehensive metrics collection with OpenTelemetry and Prometheus
11+
- Comprehensive metrics collection with OpenTelemetry
1212
- Configurable workload profiles
1313
- Connection resilience and retry logic
1414
- Environment variable configuration support

0 commit comments

Comments
 (0)