fix(LoginHelper): increase GitHub login timeout and handle GitHub popup re-authorization

[dom-aug]

This pull request improves the reliability and robustness of the GitHub login automation in the Playwright test helper by increasing timeouts and refactoring the GitHub reauthorization flow. The main enhancements include handling both automatic logins and popup-based reauthorization, increasing timeouts to accommodate slower responses, and extracting popup handling logic for clarity and reuse.

Login flow robustness and reauthorization handling:

• Refactored the GitHub login logic in LoginHelper.loginAsGithubUser to wait for either the sidebar (auto-login) or a popup (reauthorization required) after clicking "Sign In," and to handle the popup if it appears. This improves resilience against session staleness and unexpected authentication states.
• Extracted popup reauthorization logic into a dedicated handleGithubPopupReauth method, improving code clarity and reusability.

Timeout adjustments for reliability:

• Increased the test timeout for the 2FA step from 130 seconds to 260 seconds to accommodate slower authentication flows.
• Increased the wait after entering the 2FA code from 3 seconds to 30 seconds to better handle slow network or UI responses.

Assisted-By: Claude Code

[jrichter1]

what exactly are we waiting for here? 30 seconds unconditional wait seems excessive

[jrichter1]

if this is just to wait for the github login to finish, make it a conditional wait for some element on the github home page, like the heading

[dom-aug]

I believe I have increased this timeout to wait for the GitHub login to finish as the login timed-out on GitHub homepage. Though, I cannot find the Playwright Test Report from my PR that timed-out here; maybe it was during local tests against RHDH in a cluster.
The time it took the tests to return to RHDH from GitHub was quite random, which I assumed, this would cover. Is my understanding correct?
Should the suggested conditional wait be targeting GitHub homepage content or rather RHDH homepage/login screen?

[jrichter1]

Should the suggested conditional wait be targeting GitHub homepage content or rather RHDH homepage/login screen?

RHDH login is hanled outside this function, go for the github page

[dom-aug]

I have changed it to wait for Home heading

[jrichter1]

using waitForSelector is discouraged by playwright

I'd suggest using a user-facing locator like page.getByRole("heading", { name: "text" })
and waitFor

[dom-aug]

Oh, I missed that one. I have fixed that.

In fact, the waitForSelector warning does not appear for me in this rhdh-e2e-test-utils repo, but in rhdh-plugin-export-overlays it does. What can cause the different behavior?