Skip to content

Commit 83a52c2

Browse files
committed
cleanup and upversion
Signed-off-by: Jan Richter <jrichter@redhat.com>
1 parent 7434897 commit 83a52c2

10 files changed

Lines changed: 23 additions & 18 deletions

File tree

docs/.vitepress/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default defineConfig({
3333
{ text: "Examples", link: "/examples/" },
3434
{ text: "Overlay Testing", link: "/overlay/" },
3535
{
36-
text: "v1.1.12",
36+
text: "v1.1.13",
3737
items: [{ text: "Changelog", link: "/changelog" }],
3838
},
3939
],

docs/changelog.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,23 @@
22

33
All notable changes to this project will be documented in this file.
44

5+
## [1.1.13] - Current
6+
7+
### Added
8+
- Support for GitHub authentication provider
9+
10+
### Changed
11+
- `LoginHelper.loginAsGithubUser` now pulls default user credentials from the following vault keys: `VAULT_GH_USER_ID`, `VAULT_GH_USER_PASS`, `VAULT_GH_2FA_SECRET`
12+
- `APIHelper.githubRequest` pulls default user token from vault key `VAULT_GITHUB_USER_TOKEN`
13+
14+
### Environment Variables
15+
- `VAULT_GITHUB_OAUTH_OVERLAYS_APP_ID` - ID for GitHub OAuth application used as auth provider
16+
- `VAULT_GITHUB_OAUTH_OVERLAYS_APP_SECRET`- Client secret for GitHub OAuth application
17+
- `VAULT_GH_USER_ID` - GitHub user name
18+
- `VAULT_GH_USER_PASS` - GitHub user password
19+
- `VAULT_GH_2FA_SECRET` - GitHub user secret for 2 factor authentication
20+
- `VAULT_GITHUB_USER_TOKEN` - Github user token
21+
522
## [1.1.12] - Current
623

724
### Changed

docs/guide/deployment/authentication.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ Configuring github auth provider will populate the following variables from glob
171171
|----------|-------------|
172172
| `VAULT_GITHUB_OAUTH_OVERLAYS_APP_ID` | GitHub OAuth application ID |
173173
| `VAULT_GITHUB_OAUTH_OVERLAYS_APP_SECRET` | GitHub OAuth application client secret |
174-
| `VAULT_GITHUB_ORG` | GitHub test organization for the catalog provider |
175174
| `VAULT_GH_USER_ID` | GitHub test user |
176175
| `VAULT_GH_USER_PASS` | Password for GitHub test user |
177176
| `VAULT_GH_2FA_SECRET` | Two-factor auth secret for GitHub test user |
@@ -196,7 +195,6 @@ Package configs:
196195
│ └── secrets.yaml
197196
└── github/ # Applied when auth: "github"
198197
├── app-config.yaml
199-
├── dynamic-plugins.yaml
200198
└── secrets.yaml
201199
```
202200

docs/overlay/examples/basic-plugin.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ workspaces/<plugin>/e2e-tests/
6868
"eslint-plugin-check-file": "^3.3.1",
6969
"eslint-plugin-playwright": "^2.4.0",
7070
"prettier": "^3.7.4",
71-
"@red-hat-developer-hub/e2e-test-utils": "1.1.12",
71+
"@red-hat-developer-hub/e2e-test-utils": "1.1.13",
7272
"typescript": "^5.9.3",
7373
"typescript-eslint": "^8.50.0"
7474
}

docs/overlay/examples/tech-radar.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ workspaces/tech-radar/e2e-tests/
7171
"eslint-plugin-check-file": "^3.3.1",
7272
"eslint-plugin-playwright": "^2.4.0",
7373
"prettier": "^3.7.4",
74-
"@red-hat-developer-hub/e2e-test-utils": "1.1.12",
74+
"@red-hat-developer-hub/e2e-test-utils": "1.1.13",
7575
"typescript": "^5.9.3",
7676
"typescript-eslint": "^8.50.0"
7777
}

docs/overlay/test-structure/directory-layout.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Defines the test package with dependencies and scripts:
6868
"eslint-plugin-check-file": "^3.3.1",
6969
"eslint-plugin-playwright": "^2.4.0",
7070
"prettier": "^3.7.4",
71-
"@red-hat-developer-hub/e2e-test-utils": "1.1.12",
71+
"@red-hat-developer-hub/e2e-test-utils": "1.1.13",
7272
"typescript": "^5.9.3",
7373
"typescript-eslint": "^8.50.0"
7474
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@red-hat-developer-hub/e2e-test-utils",
3-
"version": "1.1.12",
3+
"version": "1.1.13",
44
"description": "Test utilities for RHDH E2E tests",
55
"license": "Apache-2.0",
66
"repository": {

src/deployment/rhdh/config/auth/github/dynamic-plugins.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/deployment/rhdh/config/auth/github/secrets.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ type: Opaque
66
stringData:
77
GITHUB_OAUTH_APP_ID: $VAULT_GITHUB_OAUTH_OVERLAYS_APP_ID
88
GITHUB_OAUTH_APP_SECRET: $VAULT_GITHUB_OAUTH_OVERLAYS_APP_SECRET
9-
GITHUB_ORG: $VAULT_GITHUB_ORG
10-
GITHUB_URL: https://github.com
119
GH_USER_ID: $VAULT_GH_USER_ID
1210
GH_USER_PASS: $VAULT_GH_USER_PASS
1311
GH_2FA_SECRET: $VAULT_GH_2FA_SECRET

src/deployment/rhdh/constants.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,7 @@ export const AUTH_CONFIG_PATHS: Record<
7272
PACKAGE_ROOT,
7373
"dist/deployment/rhdh/config/auth/github/secrets.yaml",
7474
),
75-
dynamicPlugins: path.join(
76-
PACKAGE_ROOT,
77-
"dist/deployment/rhdh/config/auth/github/dynamic-plugins.yaml",
78-
),
75+
dynamicPlugins: "",
7976
mergeStrategy: { arrayMergeStrategy: { byKey: "target" } },
8077
},
8178
};

0 commit comments

Comments
 (0)