[DeadCode] Skip remove cast (string) on substr as may return false on php 7.x on RecastingRemovalRector (#7442)

* [DeadCode] Skip remove cast (string) on substr as may return false on php 7.x

* fix fixture test

Author: samsonasik

rector.php

@@ -4,7 +4,6 @@
 
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
-use Rector\DeadCode\Rector\Cast\RecastingRemovalRector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 
@@ -53,9 +52,4 @@
             __DIR__ . '/src/Configuration/RectorConfigBuilder.php',
             __DIR__ . '/src/Console/Notifier.php',
         ],
-
-        // todo: properly handle, substr() can return false on php 7.x
-        RecastingRemovalRector::class => [
-            __DIR__ . '/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php',
-        ],
     ]);

rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_substr.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
+
+/**
+ * On PHP 7.4, substr() can returns false
+ */
+class SkipSubstr
+{
+    public function run(): string
+    {
+        $className = 'Exception';
+        return (string) substr($className, 0, -strlen($className) - 1);
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/Fixture/true_in_union_become_bool.php.inc

@@ -13,7 +13,7 @@ final class TrueInUnionBecomeBool
             return true;
         }
 
-        return substr('warning', 1);
+        return strtoupper('warning');
     }
 }
 
@@ -34,7 +34,7 @@ final class TrueInUnionBecomeBool
             return true;
         }
 
-        return substr('warning', 1);
+        return strtoupper('warning');
     }
 }
 

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/FixtureTrueInUnion/true_in_union.php.inc

@@ -13,7 +13,7 @@ final class TrueInUnion
             return true;
         }
 
-        return substr('warning', 1);
+        return strtoupper('warning');
     }
 }
 
@@ -34,7 +34,7 @@ final class TrueInUnion
             return true;
         }
 
-        return substr('warning', 1);
+        return strtoupper('warning');
     }
 }
 

src/NodeTypeResolver/NodeTypeResolver.php

@@ -39,6 +39,7 @@
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ObjectWithoutClassType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -620,6 +621,11 @@ private function resolveNativeTypeWithBuiltinMethodCallFallback(Expr $expr, Scop
                 return $scope->getNativeType($expr);
             }
 
+            // substr can return false on php 7.x
+            if ($this->nodeNameResolver->isName($expr, 'substr') && ! $expr->isFirstClassCallable()) {
+                return new UnionType([new StringType(), new ConstantBooleanType(false)]);
+            }
+
             return $scope->getType($expr);
         }