Directly check type of substr() on RecastingRemovalRector (#7446)

* Directly check type of substr() on RecastingRemovalRector

* update fixture

Author: samsonasik

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/Fixture/true_in_union_become_bool.php.inc

@@ -13,7 +13,7 @@ final class TrueInUnionBecomeBool
             return true;
         }
 
-        return strtoupper('warning');
+        return substr('warning', 1);
     }
 }
 
@@ -34,7 +34,7 @@ final class TrueInUnionBecomeBool
             return true;
         }
 
-        return strtoupper('warning');
+        return substr('warning', 1);
     }
 }
 

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/FixtureTrueInUnion/true_in_union.php.inc

@@ -13,7 +13,7 @@ final class TrueInUnion
             return true;
         }
 
-        return strtoupper('warning');
+        return substr('warning', 1);
     }
 }
 
@@ -34,7 +34,7 @@ final class TrueInUnion
             return true;
         }
 
-        return strtoupper('warning');
+        return substr('warning', 1);
     }
 }
 

rules/DeadCode/Rector/Cast/RecastingRemovalRector.php

@@ -13,12 +13,14 @@
 use PhpParser\Node\Expr\Cast\Int_;
 use PhpParser\Node\Expr\Cast\Object_;
 use PhpParser\Node\Expr\Cast\String_;
+use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PHPStan\Reflection\Php\PhpPropertyReflection;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantArrayType;
+use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
@@ -103,6 +105,13 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // substr can return false on php 7.x
+        if ($node->expr instanceof FuncCall
+            && $this->isName($node->expr, 'substr')
+            && ! $node->expr->isFirstClassCallable()) {
+            $nodeType = new UnionType([new StringType(), new ConstantBooleanType(false)]);
+        }
+
         if ($nodeType instanceof ConstantArrayType && $nodeClass === Array_::class) {
             if ($this->shouldSkip($node->expr)) {
                 return null;

src/NodeTypeResolver/NodeTypeResolver.php

@@ -39,7 +39,6 @@
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ObjectWithoutClassType;
-use PHPStan\Type\StringType;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -621,11 +620,6 @@ private function resolveNativeTypeWithBuiltinMethodCallFallback(Expr $expr, Scop
                 return $scope->getNativeType($expr);
             }
 
-            // substr can return false on php 7.x
-            if ($this->nodeNameResolver->isName($expr, 'substr') && ! $expr->isFirstClassCallable()) {
-                return new UnionType([new StringType(), new ConstantBooleanType(false)]);
-            }
-
             return $scope->getType($expr);
         }