[CodeQuality] Cover assertNotNull() in AssertEmptyNullableObjectToAssertInstanceofRector (#452)

* covert assertNotNull() in AssertEmptyNullableObjectToAssertInstanceofRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/include_assert_not_null.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class IncludeAssertNotNull extends TestCase
+{
+    public function test()
+    {
+        $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
+
+        $this->assertNotNull($someObject);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class IncludeAssertNotNull extends TestCase
+{
+    public function test()
+    {
+        $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
+
+        $this->assertInstanceOf(\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject::class, $someObject);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/include_assert_null.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class IncludeAssertNull extends TestCase
+{
+    public function test()
+    {
+        $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
+
+        $this->assertNull($someObject);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class IncludeAssertNull extends TestCase
+{
+    public function test()
+    {
+        $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
+
+        $this->assertNotInstanceOf(\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject::class, $someObject);
+    }
+}
+
+?>

rules/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector.php

@@ -30,9 +30,11 @@ public function __construct(
 
     public function getRuleDefinition(): RuleDefinition
     {
-        return new RuleDefinition('Change assertNotEmpty() on an object to more clear assertInstanceof()', [
-            new CodeSample(
-                <<<'CODE_SAMPLE'
+        return new RuleDefinition(
+            'Change assertNotEmpty() and assertNotNull() on an object to more clear assertInstanceof()',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
 use PHPUnit\Framework\TestCase;
 
 class SomeClass extends TestCase
@@ -46,8 +48,8 @@ public function test()
 }
 CODE_SAMPLE
 
-                ,
-                <<<'CODE_SAMPLE'
+                    ,
+                    <<<'CODE_SAMPLE'
 use PHPUnit\Framework\TestCase;
 
 class SomeClass extends TestCase
@@ -60,8 +62,10 @@ public function test()
     }
 }
 CODE_SAMPLE
-            ),
-        ]);
+                ),
+
+            ]
+        );
     }
 
     /**
@@ -81,7 +85,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! $this->isNames($node->name, ['assertNotEmpty', 'assertEmpty'])) {
+        if (! $this->isNames($node->name, ['assertNotEmpty', 'assertEmpty', 'assertNull', 'assertNotNull'])) {
             return null;
         }
 
@@ -105,7 +109,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $methodName = $this->isName($node->name, 'assertEmpty') ? 'assertNotInstanceOf' : 'assertInstanceOf';
+        $methodName = $this->isNames(
+            $node->name,
+            ['assertEmpty', 'assertNull']
+        ) ? 'assertNotInstanceOf' : 'assertInstanceOf';
 
         $node->name = new Identifier($methodName);