pass children as props to mount()

Author: rmorshea

docs/source/faq.rst

@@ -30,8 +30,7 @@ similar to those of standard event handlers (e.g. ``onClick``) will operate as e
 
 However, if you import a pre-built :ref:`Custom Javascript Component <Custom Javascript Components>`
 then, so long as the bundle has be defined appropriately, any component can be made to
-work, even those that don't rely on React. However these components cannot have
-children.
+work, even those that don't rely on React.
 
 
 How does IDOM communicate with the client?

src/idom/client/app/packages/idom-client-react/src/index.js

@@ -142,11 +142,11 @@ function mountImportSource(element, module, model, config) {
     if (model.children) {
       console.error("Mount function does not support children");
     }
-    module.mount(
-      element,
-      module[model.tagName],
-      elementAttributes(model, config.sendEvent)
-    );
+    const props = elementAttributes(model, config.sendEvent);
+    if (model.children) {
+      props.children = model.children;
+    }
+    module.mount(element, module[model.tagName], props);
   } else {
     reactDOM.render(
       react.createElement(

src/idom/client/module.py

@@ -134,7 +134,7 @@ def __init__(
     def declare(
         self,
         name: str,
-        has_children: Optional[bool] = None,
+        has_children: bool = True,
         fallback: Optional[str] = None,
     ) -> Import:
         """Return  an :class:`Import` for the given :class:`Module` and ``name``
@@ -189,7 +189,7 @@ def __init__(
         self,
         module: str,
         name: str,
-        has_children: Optional[bool] = None,
+        has_children: bool = True,
         has_mount: bool = False,
         fallback: Optional[str] = None,
     ) -> None:
@@ -200,17 +200,6 @@ def __init__(
             raise RuntimeError(
                 f"{IDOM_CLIENT_MODULES_MUST_HAVE_MOUNT} is set and {module} has no mount"
             )
-
-        if has_mount:
-            if has_children is True:
-                raise ValueError(
-                    f"Components of {module!r} do not support "
-                    "children because has_mount=True"
-                )
-            has_children = False
-        else:
-            has_children = bool(has_children)
-
         self._name = name
         self._constructor = make_vdom_constructor(name, has_children)
         self._import_source = ImportSourceDict(

tests/test_client/test_module.py

@@ -105,17 +105,6 @@ def test_idom_client_modules_must_have_mount():
         IDOM_CLIENT_MODULES_MUST_HAVE_MOUNT.current = old_opt
 
 
-def test_no_children_if_import_has_mount():
-    with pytest.raises(ValueError, match="do not support children"):
-        idom.Import(
-            "https://some.url",
-            "SomeComponent",
-            has_children=True,
-            has_mount=True,
-            fallback=None,
-        )
-
-
 def test_module_must_export_mount_if_has_mount_is_set():
     with pytest.raises(ValueError, match="does not export 'mount' but has_mount=True"):
         idom.Module(