Rename DrawCommandSpan to CanvasEffectSpan and remove UpdateAppearance

Summary:
Renames `DrawCommandSpan` to `CanvasEffectSpan` for consistency with the new
`AnimatedEffectSpan`, and removes the `UpdateAppearance` interface.

`UpdateAppearance` is a marker interface that tells Android's text layout system
the span affects text appearance (triggering re-measurement). Since
`CanvasEffectSpan` only draws on top of text during `PreparedLayoutTextView`'s
draw pass and never modifies paint state or text measurement, implementing
`UpdateAppearance` was incorrect — the same reasoning applied when designing
`AnimatedEffectSpan` without it.

Reviewed By: mdvacca

Differential Revision: D97399655

Author: andrewdacenko

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/PreparedLayoutTextView.kt

@@ -30,7 +30,7 @@ import com.facebook.react.uimanager.BackgroundStyleApplicator
 import com.facebook.react.uimanager.ReactCompoundView
 import com.facebook.react.uimanager.style.Overflow
 import com.facebook.react.views.text.internal.span.AnimatedEffectSpan
-import com.facebook.react.views.text.internal.span.DrawCommandSpan
+import com.facebook.react.views.text.internal.span.CanvasEffectSpan
 import com.facebook.react.views.text.internal.span.ReactFragmentIndexSpan
 import com.facebook.react.views.text.internal.span.ReactLinkSpan
 import kotlin.collections.ArrayList
@@ -134,11 +134,11 @@ internal class PreparedLayoutTextView(context: Context) : ViewGroup(context), Re
       }
 
       val spanned = text as? Spanned
-      val drawCommandSpans =
-          spanned?.getSpans(0, spanned.length, DrawCommandSpan::class.java) ?: emptyArray()
+      val canvasEffectSpans =
+          spanned?.getSpans(0, spanned.length, CanvasEffectSpan::class.java) ?: emptyArray()
 
       if (spanned != null) {
-        for (span in drawCommandSpans) {
+        for (span in canvasEffectSpans) {
           span.onPreDraw(
               spanned.getSpanStart(span),
               spanned.getSpanEnd(span),
@@ -155,7 +155,7 @@ internal class PreparedLayoutTextView(context: Context) : ViewGroup(context), Re
       }
 
       if (spanned != null) {
-        for (span in drawCommandSpans) {
+        for (span in canvasEffectSpans) {
           span.onDraw(
               spanned.getSpanStart(span),
               spanned.getSpanEnd(span),

…ws/text/internal/span/DrawCommandSpan.kt …s/text/internal/span/CanvasEffectSpan.ktpackages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/DrawCommandSpan.kt renamed to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/CanvasEffectSpan.kt packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/DrawCommandSpan.kt renamed to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/internal/span/CanvasEffectSpan.kt

@@ -9,13 +9,12 @@ package com.facebook.react.views.text.internal.span
 
 import android.graphics.Canvas
 import android.text.Layout
-import android.text.style.UpdateAppearance
 
 /**
- * May be overridden to implement character styles which are applied by [PreparedLayoutTextView]
- * during the drawing of text, against the underlying Android canvas
+ * A span which draws a static effect on top of text. [onPreDraw] and [onDraw] hooks are called
+ * during [PreparedLayoutTextView] drawing, providing glyph layout information for custom rendering.
  */
-public abstract class DrawCommandSpan : UpdateAppearance, ReactSpan {
+public abstract class CanvasEffectSpan {
   /**
    * Called before the text is drawn. This happens after the Paragraph component has drawn its
    * background, but may be called before text spans with their own background color are drawn.