Skip to content

Commit 170baaf

Browse files
authored
chore: fix contributing.md (#23)
chore: fix contributing.md
2 parents b844e81 + efd58e6 commit 170baaf

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ All work on React Native SegmentedControl happens directly on GitHub. Contributo
1313
Currently we use `flow` for typechecking, `eslint` with `prettier` for linting and formatting the code, and `jest` for unit testing. We also use `detox` for end-to-end testing. All of these are run on CircleCI for all opened pull requests, but you should use them locally when making changes.
1414

1515
* `yarn test`: Run all tests and validations.
16-
* `yarn validate:eslint`: Run `eslint`.
17-
* `yarn validate:eslint --fix`: Run `eslint` and automatically fix issues. This is useful for correcting code formatting.
18-
* `yarn validate:flow`: Run `flow` typechecking.
19-
* `yarn validate:typescript`: Run `typescript` typechecking.
20-
* `yarn test:jest`: Run unit tests with `jest`.
21-
* `yarn test:detox:<android|ios>:build:<debug|release>`: Build the `debug` or `release` app for end-to-end tests with `detox` on either `android` or `ios`. You need to run this before running the test command and whenever you make changes to the native code.
22-
* `yarn test:detox:<android|ios>:test:<debug|release>`: Run the `debug` or `release` end-to-end tests with `detox` on either `android` or `ios`.
16+
* `yarn lint`: Run `eslint`.
17+
* `yarn lint --fix`: Run `eslint` and automatically fix issues. This is useful for correcting code formatting.
18+
* `yarn flow`: Run `flow` typechecking.
19+
<!-- * `yarn validate:typescript`: Run `typescript` typechecking. -->
20+
<!-- * `yarn test:jest`: Run unit tests with `jest`. -->
21+
<!-- * `yarn test:detox:<android|ios>:build:<debug|release>`: Build the `debug` or `release` app for end-to-end tests with `detox` on either `android` or `ios`. You need to run this before running the test command and whenever you make changes to the native code. -->
22+
<!-- * `yarn test:detox:<android|ios>:test:<debug|release>`: Run the `debug` or `release` end-to-end tests with `detox` on either `android` or `ios`. -->
2323

2424
## Sending a pull request
2525
When you're sending a pull request:
@@ -45,7 +45,7 @@ We prefix our commit messages with one of the following to signify the kind of c
4545
We use [Semantic Release](http://semantic-release.org) to automatically release new versions of the library when changes are merged into master. Using the commit message convention described above, it will detect if we need to release a patch, minor, or major version of the library.
4646

4747
## Reporting issues
48-
You can report issues on our [bug tracker](https://github.com/react-native-community/react-native-netinfo/issues). Please search for existing issues and follow the issue template when opening an issue.
48+
You can report issues on our [bug tracker](https://github.com/react-native-community/react-native-segmented-control/issues). Please search for existing issues and follow the issue template when opening an issue.
4949

5050
## License
5151
By contributing to React Native Segmented Control, you agree that your contributions will be licensed under the **MIT** license.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"main": "js/index.js",
66
"scripts": {
77
"start": "node node_modules/react-native/local-cli/cli.js start",
8+
"test": "yarn flow && yarn lint",
89
"flow": "flow",
910
"lint": "eslint ."
1011
},

0 commit comments

Comments
 (0)