pio_encoding fixes + added PIO_VERSION to platform_defs.h#2958
Open
kilograham wants to merge 3 commits into
Open
pio_encoding fixes + added PIO_VERSION to platform_defs.h#2958kilograham wants to merge 3 commits into
kilograham wants to merge 3 commits into
Conversation
3 tasks
Contributor
Author
|
fixes #2754 |
Contributor
Maybe it's worth removing the |
lurch
reviewed
May 20, 2026
lurch
reviewed
May 20, 2026
lurch
reviewed
May 21, 2026
Co-authored-by: Andrew Scheller <lurch@durge.org>
will-v-pi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pio_encode_mov(pio_pindirs)was wrong because themovdestination for pindirs is a different valuepio_instructions.his included beforePICO_PIO_VERSIONis set; didn't want to make a circular include, and previously pio_instructions.h is somewhat standalone include-able, so decided to addPIO_VERSIONtoplatform_defs.h... TBH it should have been there already as the init ofPICO_PIO_VERSIONwas a bit of a hack. I doubt anyone wants to override PICO_PIO_VERSION anywaypio_exec_movandpio_exec_out- kept these for backwards compatibility, but decided to just allowpio_execand havepio_encode_movtake care of it. as i imagine most of uses ofpio_encode_movtake a constant arg, this isn't much of an overhead (the alternative would have been to encode the two different values in the enum value, which is fine, but likely going to lead to more code if done at runtime vs just the ifs)