fix: commit review fixes and add env var documentation

- Stage remaining cloudflare-specialist review changes (API rewrite, ideas removal, session cap, env vars)
- Add ACCOUNT_MAP_* env vars to .env.example

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: raphaeltm

apps/api/.env.example

@@ -319,6 +319,11 @@ BASE_DOMAIN=simple-agent-manager.org
 # ATTACHMENT_PRESIGN_EXPIRY_SECONDS=900              # Presigned URL expiry (15 min)
 # ATTACHMENT_TRANSFER_TIMEOUT_MS=60000               # Timeout per attachment transfer to workspace (60s)
 
+# Account Map visualization
+# ACCOUNT_MAP_MAX_ENTITIES=500                        # Max total entities returned (default: 500)
+# ACCOUNT_MAP_MAX_SESSIONS_PER_PROJECT=50             # Max sessions per project from DO fan-out (default: 50)
+# ACCOUNT_MAP_CACHE_TTL_SECONDS=30                    # KV cache TTL for account map data (default: 30s)
+
 # Notification Durable Object limits
 # MAX_NOTIFICATIONS_PER_USER=500                      # Max stored notifications per user before oldest auto-deleted
 # NOTIFICATION_AUTO_DELETE_AGE_MS=7776000000           # Auto-delete age (90 days)

apps/api/src/index.ts

@@ -171,6 +171,8 @@ export interface Env {
   ACP_MAX_RESTART_ATTEMPTS?: string;
   // Account Map configuration
   ACCOUNT_MAP_MAX_ENTITIES?: string;
+  ACCOUNT_MAP_MAX_SESSIONS_PER_PROJECT?: string;
+  ACCOUNT_MAP_CACHE_TTL_SECONDS?: string;
   // Dashboard configuration
   DASHBOARD_INACTIVE_THRESHOLD_MS?: string;
   // Boot log configuration

apps/api/src/routes/account-map.ts

@@ -2,8 +2,12 @@
  * Account Map API route.
  *
  * Returns aggregated entity data (projects, nodes, workspaces, sessions,
- * tasks, ideas) and their relationships for the authenticated user.
+ * tasks) and their relationships for the authenticated user.
  * Used by the Account Map visualization page.
+ *
+ * Performance note: this endpoint fans out to one ProjectData DO per project
+ * to fetch sessions. For accounts with many projects, this can be slow on
+ * cold DOs (~5-20ms each). KV caching (30s TTL) absorbs repeated reads.
  */
 import { Hono } from 'hono';
 import { eq } from 'drizzle-orm';
@@ -13,22 +17,61 @@ import * as schema from '../db/schema';
 import { getUserId, requireAuth, requireApproved } from '../middleware/auth';
 import * as projectDataService from '../services/project-data';
 
-/**
- * Default max entities per type. Configurable via ACCOUNT_MAP_MAX_ENTITIES env var.
- */
+/** Default max entities per type from D1. Configurable via ACCOUNT_MAP_MAX_ENTITIES. */
 const DEFAULT_MAX_ENTITIES = 200;
 
+/** Max sessions fetched per project from DO. Configurable via ACCOUNT_MAP_MAX_SESSIONS_PER_PROJECT. */
+const DEFAULT_MAX_SESSIONS_PER_PROJECT = 20;
+
+/** KV cache TTL in seconds. Configurable via ACCOUNT_MAP_CACHE_TTL_SECONDS. */
+const DEFAULT_CACHE_TTL_SECONDS = 30;
+
+interface SessionSummary {
+  id: string;
+  projectId: string;
+  topic: string | null;
+  status: string;
+  messageCount: number;
+  workspaceId: string | null;
+  taskId: string | null;
+}
+
+interface Relationship {
+  source: string;
+  target: string;
+  type: string;
+  active: boolean;
+}
+
 const accountMapRoutes = new Hono<{ Bindings: Env }>();
 
 accountMapRoutes.use('/*', requireAuth(), requireApproved());
 
 accountMapRoutes.get('/', async (c) => {
   const userId = getUserId(c);
+
+  const parsedMax = parseInt(c.env.ACCOUNT_MAP_MAX_ENTITIES ?? '', 10);
+  const maxEntities = Number.isFinite(parsedMax) && parsedMax > 0
+    ? parsedMax
+    : DEFAULT_MAX_ENTITIES;
+
+  const parsedSessionCap = parseInt(c.env.ACCOUNT_MAP_MAX_SESSIONS_PER_PROJECT ?? '', 10);
+  const maxSessionsPerProject = Number.isFinite(parsedSessionCap) && parsedSessionCap > 0
+    ? parsedSessionCap
+    : DEFAULT_MAX_SESSIONS_PER_PROJECT;
+
+  const cacheTtl = parseInt(c.env.ACCOUNT_MAP_CACHE_TTL_SECONDS ?? '', 10) || DEFAULT_CACHE_TTL_SECONDS;
+
+  // --- KV cache check ---
+  const cacheKey = `account-map:${userId}`;
+  const cached = await c.env.KV.get(cacheKey, 'json');
+  if (cached) {
+    return c.json(cached);
+  }
+
+  // --- D1 queries: projects, nodes, workspaces, tasks ---
   const db = drizzle(c.env.DATABASE, { schema });
-  const maxEntities =
-    parseInt(c.env.ACCOUNT_MAP_MAX_ENTITIES ?? '', 10) || DEFAULT_MAX_ENTITIES;
 
-  // --- D1 queries: projects, nodes, workspaces ---
   const [projectRows, nodeRows, workspaceRows, taskRows] = await Promise.all([
     db
       .select({
@@ -90,66 +133,40 @@ accountMapRoutes.get('/', async (c) => {
       .limit(maxEntities),
   ]);
 
-  // --- Fan out to ProjectData DOs for sessions and ideas ---
-  interface SessionSummary {
-    id: string;
-    projectId: string;
-    topic: string | null;
-    status: string;
-    messageCount: number;
-    workspaceId: string | null;
-    taskId: string | null;
-  }
-
-  interface IdeaSummary {
-    id: string;
-    projectId: string;
-    title: string;
-    status: string;
-    linkedSessionCount: number;
-  }
-
-  const allSessions: SessionSummary[] = [];
-  const allIdeas: IdeaSummary[] = [];
-
+  // --- Fan out to ProjectData DOs for sessions ---
+  // Each callback returns its sessions; collected after settlement to avoid shared-array mutation.
   const doResults = await Promise.allSettled(
     projectRows.map(async (project) => {
       const sessionsResult = await projectDataService.listSessions(
         c.env,
         project.id,
         null,
-        maxEntities,
+        maxSessionsPerProject,
         0
       );
 
-      for (const s of sessionsResult.sessions) {
-        allSessions.push({
-          id: s.id as string,
-          projectId: project.id,
-          topic: (s.topic as string) ?? null,
-          status: (s.status as string) ?? 'unknown',
-          messageCount: (s.messageCount as number) ?? 0,
-          workspaceId: (s.workspaceId as string) ?? null,
-          taskId: (s.taskId as string) ?? null,
-        });
-      }
+      return sessionsResult.sessions.map((s): SessionSummary => ({
+        id: s.id as string,
+        projectId: project.id,
+        topic: (s.topic as string) ?? null,
+        status: (s.status as string) ?? 'unknown',
+        messageCount: (s.messageCount as number) ?? 0,
+        workspaceId: (s.workspaceId as string) ?? null,
+        taskId: (s.taskId as string) ?? null,
+      }));
     })
   );
 
+  const allSessions: SessionSummary[] = [];
   for (const result of doResults) {
-    if (result.status === 'rejected') {
+    if (result.status === 'fulfilled') {
+      allSessions.push(...result.value);
+    } else {
       console.warn('AccountMap: failed to fetch DO data:', result.reason);
     }
   }
 
   // --- Build relationships ---
-  interface Relationship {
-    source: string;
-    target: string;
-    type: string;
-    active: boolean;
-  }
-
   const relationships: Relationship[] = [];
 
   // Project → Workspace
@@ -222,7 +239,7 @@ accountMapRoutes.get('/', async (c) => {
     }
   }
 
-  return c.json({
+  const payload = {
     projects: projectRows,
     nodes: nodeRows,
     workspaces: workspaceRows,
@@ -236,9 +253,14 @@ accountMapRoutes.get('/', async (c) => {
       executionStep: t.executionStep,
       priority: t.priority,
     })),
-    ideas: allIdeas,
     relationships,
-  });
+  };
+
+  // --- Cache in KV (fire-and-forget) ---
+  void c.env.KV.put(cacheKey, JSON.stringify(payload), { expirationTtl: cacheTtl })
+    .catch((err: unknown) => console.warn('AccountMap: KV cache write failed:', err));
+
+  return c.json(payload);
 });
 
 export { accountMapRoutes };

apps/api/tests/unit/routes/account-map.test.ts

@@ -84,6 +84,10 @@ const mockEnv = {
     idFromName: vi.fn().mockReturnValue({ toString: () => 'do-id' }),
     get: vi.fn(),
   },
+  KV: {
+    get: vi.fn().mockResolvedValue(null),
+    put: vi.fn().mockResolvedValue(undefined),
+  },
 } as unknown as Env;
 
 // ---------------------------------------------------------------------------
@@ -108,7 +112,7 @@ describe('GET /account-map', () => {
     expect(body.workspaces).toEqual([]);
     expect(body.sessions).toEqual([]);
     expect(body.tasks).toEqual([]);
-    expect(body.ideas).toEqual([]);
+
     expect(body.relationships).toEqual([]);
   });
 

apps/web/src/components/account-map/hooks/useAccountMapData.ts

@@ -25,7 +25,7 @@ interface UseAccountMapDataResult {
   loading: boolean;
   error: string | null;
   isEmpty: boolean;
-  stats: { projects: number; nodes: number; workspaces: number; sessions: number; tasks: number; ideas: number };
+  stats: { projects: number; nodes: number; workspaces: number; sessions: number; tasks: number };
   refresh: () => void;
   reorganize: () => void;
 }
@@ -58,7 +58,7 @@ export function useAccountMapData({ isMobile }: UseAccountMapDataOptions): UseAc
       return {
         nodes: [] as Node[],
         edges: [] as Edge[],
-        stats: { projects: 0, nodes: 0, workspaces: 0, sessions: 0, tasks: 0, ideas: 0 },
+        stats: { projects: 0, nodes: 0, workspaces: 0, sessions: 0, tasks: 0 },
         isEmpty: true,
       };
     }
@@ -170,21 +170,6 @@ export function useAccountMapData({ isMobile }: UseAccountMapDataOptions): UseAc
       });
     }
 
-    // Ideas
-    for (const idea of rawData.ideas) {
-      flowNodes.push({
-        id: idea.id,
-        type: 'ideaNode',
-        position: { x: 0, y: 0 },
-        data: {
-          label: idea.title,
-          status: idea.status,
-          linkedSessionCount: idea.linkedSessionCount,
-          isMobile,
-        },
-      });
-    }
-
     // Edges
     const flowEdges: Edge[] = rawData.relationships.map((rel, i) => ({
       id: `e-${rel.source}-${rel.target}-${i}`,
@@ -209,8 +194,7 @@ export function useAccountMapData({ isMobile }: UseAccountMapDataOptions): UseAc
       rawData.nodes.length +
       rawData.workspaces.length +
       rawData.sessions.length +
-      rawData.tasks.length +
-      rawData.ideas.length;
+      rawData.tasks.length;
 
     return {
       nodes: layoutedNodes,
@@ -221,7 +205,6 @@ export function useAccountMapData({ isMobile }: UseAccountMapDataOptions): UseAc
         workspaces: rawData.workspaces.length,
         sessions: rawData.sessions.length,
         tasks: rawData.tasks.length,
-        ideas: rawData.ideas.length,
       },
       isEmpty: totalEntities === 0,
     };

apps/web/src/components/account-map/hooks/useMapFilters.ts

@@ -30,7 +30,7 @@ interface UseMapFiltersResult {
   totalCount: number;
 }
 
-const ALL_TYPES: EntityType[] = ['project', 'node', 'workspace', 'session', 'task', 'idea'];
+const ALL_TYPES: EntityType[] = ['project', 'node', 'workspace', 'session', 'task'];
 
 export function useMapFilters({ nodes, edges }: UseMapFiltersOptions): UseMapFiltersResult {
   const [searchQuery, setSearchQuery] = useState('');

apps/web/src/lib/api.ts

@@ -294,13 +294,6 @@ export interface AccountMapResponse {
     executionStep: string | null;
     priority: number | null;
   }>;
-  ideas: Array<{
-    id: string;
-    projectId: string;
-    title: string;
-    status: string;
-    linkedSessionCount: number;
-  }>;
   relationships: Array<{
     source: string;
     target: string;