From ec22ca579db212128166bb52eb40ce3ef4a7fe29 Mon Sep 17 00:00:00 2001 From: Arda Nakisci Date: Mon, 23 Feb 2026 12:49:04 +0300 Subject: [PATCH 1/3] Re-enable vault balance chart disabled by Issue #1989 The VaultBalanceChart was disabled as collateral damage when performance metrics were refactored. The underlying API is unchanged and working. --- .../src/__tests__/VaultBalanceChart.test.ts | 52 ++++++++--------- .../charts/VaultBalanceChart.svelte | 58 ++++++++----------- .../lib/components/detail/VaultDetail.svelte | 14 ++--- .../[chainId]-[orderbook]-[id]/+page.svelte | 4 +- 4 files changed, 58 insertions(+), 70 deletions(-) diff --git a/packages/ui-components/src/__tests__/VaultBalanceChart.test.ts b/packages/ui-components/src/__tests__/VaultBalanceChart.test.ts index d8040c54e0..436c800587 100644 --- a/packages/ui-components/src/__tests__/VaultBalanceChart.test.ts +++ b/packages/ui-components/src/__tests__/VaultBalanceChart.test.ts @@ -1,32 +1,30 @@ -// TODO: Issue #1989 -// import { render } from '@testing-library/svelte'; -import { test } from 'vitest'; -// import { expect, test, vi } from 'vitest'; -// import { QueryClient } from '@tanstack/svelte-query'; -// import VaultBalanceChart from '../lib/components/charts/VaultBalanceChart.svelte'; -// import type { RaindexVault } from '@rainlanguage/orderbook'; -// import { writable } from 'svelte/store'; -// import type { ComponentProps } from 'svelte'; +import { render } from '@testing-library/svelte'; +import { expect, test, vi } from 'vitest'; +import { QueryClient } from '@tanstack/svelte-query'; +import VaultBalanceChart from '../lib/components/charts/VaultBalanceChart.svelte'; +import type { RaindexVault } from '@rainlanguage/orderbook'; +import { writable } from 'svelte/store'; +import type { ComponentProps } from 'svelte'; -// type VaultBalanceChartProps = ComponentProps; +type VaultBalanceChartProps = ComponentProps; -// vi.mock('../lib/components/charts/TanstackLightweightChartLine.svelte', async () => { -// const MockLightweightChart = (await import('../lib/__mocks__/MockComponent.svelte')).default; -// return { default: MockLightweightChart }; -// }); +vi.mock('../lib/components/charts/TanstackLightweightChartLine.svelte', async () => { + const MockLightweightChart = (await import('../lib/__mocks__/MockComponent.svelte')).default; + return { default: MockLightweightChart }; +}); test('calls getVaultBalanceChanges with correct arguments', async () => { - // const queryClient = new QueryClient(); - // const mockVault: RaindexVault = { - // id: 'vault1', - // getBalanceChanges: vi.fn() - // } as unknown as RaindexVault; - // render(VaultBalanceChart, { - // props: { - // vault: mockVault, - // lightweightChartsTheme: writable({}) - // } as VaultBalanceChartProps, - // context: new Map([['$$_queryClient', queryClient]]) - // }); - // expect(mockVault.getBalanceChanges).toHaveBeenCalledWith(1); + const queryClient = new QueryClient(); + const mockVault: RaindexVault = { + id: 'vault1', + getBalanceChanges: vi.fn() + } as unknown as RaindexVault; + render(VaultBalanceChart, { + props: { + vault: mockVault, + lightweightChartsTheme: writable({}) + } as VaultBalanceChartProps, + context: new Map([['$$_queryClient', queryClient]]) + }); + expect(mockVault.getBalanceChanges).toHaveBeenCalledWith(1); }); diff --git a/packages/ui-components/src/lib/components/charts/VaultBalanceChart.svelte b/packages/ui-components/src/lib/components/charts/VaultBalanceChart.svelte index d4869fb874..bd7bb44801 100644 --- a/packages/ui-components/src/lib/components/charts/VaultBalanceChart.svelte +++ b/packages/ui-components/src/lib/components/charts/VaultBalanceChart.svelte @@ -1,39 +1,31 @@ - - - -{#if false} -
TODO: Issue #1989
-{/if} + timestampSecondsToUTCTimestamp(BigInt(d.timestamp))} + valueTransform={(d) => parseFloat(d.formattedNewBalance)} + emptyMessage="No deposits or withdrawals found" + {lightweightChartsTheme} +/> diff --git a/packages/ui-components/src/lib/components/detail/VaultDetail.svelte b/packages/ui-components/src/lib/components/detail/VaultDetail.svelte index e95296072d..c864c2e47b 100644 --- a/packages/ui-components/src/lib/components/detail/VaultDetail.svelte +++ b/packages/ui-components/src/lib/components/detail/VaultDetail.svelte @@ -1,8 +1,7 @@