ci: drop setup-node, route npm through rust-node-shell#222
Conversation
Replaces actions/setup-node@v4 + the local default-shell test-js-bindings task with rainix#rust-node-shell. All npm calls (test/build/test in the bindings step, npm view/pack, npm version, final npm pack) now go through one consistent nix shell. Benefits: - PATH ordering and node-version drift between actions/setup-node and nix are gone; node is the same version nix pins for everyone. - Test JS/TS bindings step no longer needs the heavy local default shell (which pulled in everything via inputsFrom). - Single source of truth for the JS toolchain (nix), matching the rust and sol sides. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 52 minutes and 14 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Replaces actions/setup-node@v4 + local-default-shell test-js-bindings with rainix#rust-node-shell (landed in rainlanguage/rainix#177). All npm calls (test-js-bindings, NPM hashes, Bump NPM version, NPM pack) now go through one consistent nix shell.
Removes the PATH-ambiguity / node-version-drift risk we flagged earlier when setup-node and nix were both in play.