Optimize KeyFormatter on cache hits
#607
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #597. This PR optimizes the
KeyFormatterso that it doesn't lock the mutex on a cache hit by implementing the check-lock-check pattern, which gives us a fast non-locking path for the most likely case. This was inspired by howConcurrent::Mapis implemented.The mutex will only be locked when there is a cache miss, and while locked it will first attempt another read to account for the situation where another thread has already computed the value.
This small change results in a significant improvement on cache hits when running
Jbuilder::KeyFormatter#format.When using key formatting, this is one of the hotter code paths in
jbuilder. The following benchmarkShows a 1.29x improvement