Skip to content

Commit e624196

Browse files
committed
Updated deps, fixed clippy lints, fixed Java plugin bugs, fixed course refresher ignoring hidden files for no reason, improved docker stuff
1 parent 953f3af commit e624196

39 files changed

+394
-385
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -38,26 +38,11 @@ cargo test
3838

3939
## Building and testing with Docker
4040

41-
Build the binary in Docker and copy it to the current directory (this can be useful to create a binary linked with an older glibc):
42-
43-
```bash
44-
export DOCKER_BUILDKIT=1
45-
docker build . -f docker/Dockerfile -t tmc-langs-rust
46-
docker run --rm -v "$PWD":/build/out tmc-langs-rust bash -c "cargo build && cp /build/target/debug/tmc-langs-cli /build/out/"
47-
```
48-
49-
Run tests in Docker:
50-
51-
```bash
52-
export DOCKER_BUILDKIT=1
53-
docker build . -f docker/Dockerfile -t tmc-langs-rust
54-
docker run --rm -it tmc-langs-rust bash
55-
cargo test
56-
```
41+
The `docker.sh` script can be conveniently used to build and test the project. To build the binary and copy it out of the container to the project root, simply run `docker.sh`. To run tests, you can run `docker.sh "cargo test"`, or `docker.sh "cargo test -p tmc-langs-r"` and so on. The script also supports the special argument `interactive` to launch into an interactive bash shell inside the Docker container.
5742

5843
## Formatting and linting
5944

60-
Use `cargo fmt` and `cargo clippy` for formatting and linting. All crates should have the clippy lints `print_stdout` and `print_stderr` set to deny to allow the CLI to have total control over stdout and stderr. The CLI has one function where writing to stdout is allowed.
45+
Use `cargo +nightly fmt` and `cargo clippy` for formatting and linting. All crates should have the clippy lints `print_stdout` and `print_stderr` set to deny to allow the CLI to have total control over stdout and stderr. The CLI has one function where writing to stdout is allowed.
6146

6247
## Updating dependencies
6348

0 commit comments

Comments
 (0)