Merge pull request #123 from rage/more-refactoring

More refactoring

Author: Heliozoa

README.md

@@ -38,7 +38,7 @@ cargo run -p tmc-langs-cli help
 
 ## Development
 
-Format using `cargo fmt`, use `cargo clippy` for linting.
+Format using `cargo fmt`, use `cargo clippy` for linting. All crates should have the clippy lints `print_stdout` and `print_stderr` set to deny. The CLI has one function where writing to stdout is allowed.
 
 If using vscode and rust-analyzer, be sure to turn on the setting `loadOutDirsFromCheck` to avoid a spurious unresolved import error from `isolang`.
 

plugins/csharp/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! TMC language plugin for C#.
 
 mod cs_test_result;

plugins/csharp/src/plugin.rs

@@ -686,7 +686,7 @@ mod test {
     }
 
     #[test]
-    #[ignore = "requires newer version of C# runner that always includes all points in the tests"]
+    // #[ignore = "requires newer version of C# runner that always includes all points in the tests"]
     fn doesnt_give_points_unless_all_relevant_exercises_pass() {
         init();
 

plugins/java/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Java plugins for ant and maven
 
 mod ant_plugin;

plugins/make/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! TMC plugin for make.
 
 mod check_log;

plugins/notests/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr, clippy::unwrap_used)]
+
 //! Language plugin for no_tests exercises.
 
 mod plugin;

plugins/python3/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Implementation of LanguagePlugin for Python 3.
 
 mod error;

plugins/r/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Language plugin for the R language
 
 mod error;

tmc-client/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Used to communicate with the TMC server. See the TmcClient struct for more details.
 //!
 //! ```rust,no_run

tmc-client/src/tmc_client.rs

@@ -225,6 +225,12 @@ impl TmcClient {
             None,
         );
 
+        // for each exercise, check if there's already something on disk
+        // if yes, check if it needs updating
+        // if not, check if there's a previous submission
+        //   if yes, download it
+        //   if not, download the exercise template
+
         let thread_count = exercises_len.min(4); // max 4 threads
         let mut handles = vec![];
         let exercises = Arc::new(Mutex::new(exercises));
@@ -248,7 +254,7 @@ impl TmcClient {
                 // repeat until out of exercises
                 loop {
                     // acquiring mutex
-                    let mut exercises = exercises.lock().unwrap(); // the threads should never panic
+                    let mut exercises = exercises.lock().expect("the threads should never panic");
                     let (exercise_id, target) = if let Some((id, path)) = exercises.pop() {
                         (id, path)
                     } else {
@@ -319,8 +325,7 @@ impl TmcClient {
         let mut successful = vec![];
         let mut failed = vec![];
         for handle in handles {
-            // the threads should never panic
-            match handle.join().unwrap() {
+            match handle.join().expect("the threads should never panic") {
                 Ok(s) => successful.extend(s),
                 Err((s, f)) => {
                     successful.extend(s);
@@ -370,7 +375,7 @@ impl TmcClient {
 
     pub fn get_exercises_details(
         &self,
-        exercise_ids: Vec<usize>,
+        exercise_ids: &[usize],
     ) -> Result<Vec<ExercisesDetails>, ClientError> {
         self.core_exercise_details(exercise_ids)
     }