added clippy lints

Author: Heliozoa

README.md

@@ -38,7 +38,7 @@ cargo run -p tmc-langs-cli help
 
 ## Development
 
-Format using `cargo fmt`, use `cargo clippy` for linting.
+Format using `cargo fmt`, use `cargo clippy` for linting. All crates should have the clippy lints `print_stdout` and `print_stderr` set to deny. The CLI has one function where writing to stdout is allowed.
 
 If using vscode and rust-analyzer, be sure to turn on the setting `loadOutDirsFromCheck` to avoid a spurious unresolved import error from `isolang`.
 

plugins/csharp/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! TMC language plugin for C#.
 
 mod cs_test_result;

plugins/java/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Java plugins for ant and maven
 
 mod ant_plugin;

plugins/make/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! TMC plugin for make.
 
 mod check_log;

plugins/notests/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr, clippy::unwrap_used)]
+
 //! Language plugin for no_tests exercises.
 
 mod plugin;

plugins/python3/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Implementation of LanguagePlugin for Python 3.
 
 mod error;

plugins/r/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Language plugin for the R language
 
 mod error;

tmc-client/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! Used to communicate with the TMC server. See the TmcClient struct for more details.
 //!
 //! ```rust,no_run

tmc-client/src/tmc_client.rs

@@ -248,7 +248,7 @@ impl TmcClient {
                 // repeat until out of exercises
                 loop {
                     // acquiring mutex
-                    let mut exercises = exercises.lock().unwrap(); // the threads should never panic
+                    let mut exercises = exercises.lock().expect("the threads should never panic");
                     let (exercise_id, target) = if let Some((id, path)) = exercises.pop() {
                         (id, path)
                     } else {
@@ -319,8 +319,7 @@ impl TmcClient {
         let mut successful = vec![];
         let mut failed = vec![];
         for handle in handles {
-            // the threads should never panic
-            match handle.join().unwrap() {
+            match handle.join().expect("the threads should never panic") {
                 Ok(s) => successful.extend(s),
                 Err((s, f)) => {
                     successful.extend(s);

tmc-langs-cli/src/lib.rs

@@ -1,12 +1,11 @@
+#![deny(clippy::print_stdout, clippy::print_stderr)]
+
 //! CLI client for TMC
 
 mod app;
-mod config;
 mod error;
 mod output;
 
-use self::config::ProjectsConfig;
-use self::config::{CourseConfig, Credentials, Exercise, TmcConfig};
 use self::error::{DownloadsFailedError, InvalidTokenError, SandboxTestError};
 use self::output::{
     CombinedCourseData, Data, DownloadOrUpdateCourseExercise,
@@ -1568,6 +1567,7 @@ fn print_output(output: &Output, pretty: bool) -> Result<PrintToken> {
     print_output_with_file(output, pretty, None)
 }
 
+#[allow(clippy::clippy::print_stdout)] // this is the only function that should output to stdout/stderr across tmc-langs
 fn print_output_with_file(
     output: &Output,
     pretty: bool,