Use log4j2 instead of logback (for tests)

The project uses slf4j 1.7.x for best compatibility but this implies
using a unmaintained version of logback. Log4j2 is still maintained and
supports slf4j 1.7.x, so we pick it for the test suite.

Author: acogoluegnes

pom.xml

@@ -49,7 +49,6 @@
   <properties>
     <spotless.check.skip>true</spotless.check.skip>
     <slf4j.version>1.7.36</slf4j.version>
-    <logback.version>1.2.13</logback.version>
     <netty.version>4.2.7.Final</netty.version>
     <proton-j.version>0.34.1</proton-j.version>
     <metrics.version>4.2.37</metrics.version>
@@ -107,6 +106,7 @@
     <gpg.skip>true</gpg.skip>
     <jose4j.version>0.9.6</jose4j.version>
     <bucket4j.version>8.15.0</bucket4j.version>
+    <log4j.version>2.23.1</log4j.version>
   </properties>
 
   <dependencies>
@@ -313,6 +313,12 @@
       <artifactId>micrometer-docs-generator</artifactId>
       <version>${micrometer-docs-generator.version}</version>
       <scope>test</scope>
+        <exclusions>
+            <exclusion>
+                <groupId>ch.qos.logback</groupId>
+                <artifactId>*</artifactId>
+            </exclusion>
+        </exclusions>
     </dependency>
 
     <dependency>
@@ -341,12 +347,28 @@
       <version>${jmh.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>ch.qos.logback</groupId>
-      <artifactId>logback-classic</artifactId>
-      <version>${logback.version}</version>
-      <scope>test</scope>
-    </dependency>
+
+      <dependency>
+          <groupId>org.apache.logging.log4j</groupId>
+          <artifactId>log4j-slf4j-impl</artifactId>
+          <version>${log4j.version}</version>
+          <scope>test</scope>
+      </dependency>
+
+      <dependency>
+          <groupId>org.apache.logging.log4j</groupId>
+          <artifactId>log4j-core</artifactId>
+          <version>${log4j.version}</version>
+          <scope>test</scope>
+      </dependency>
+
+      <dependency>
+          <groupId>org.apache.logging.log4j</groupId>
+          <artifactId>log4j-api</artifactId>
+          <version>${log4j.version}</version>
+          <scope>test</scope>
+      </dependency>
+
     <!-- add explicitly to update automatically with dependabot -->
     <dependency>
       <groupId>com.google.googlejavaformat</groupId>

src/test/java/com/rabbitmq/stream/impl/RecoveryClusterTest.java

@@ -26,7 +26,6 @@
 import static java.util.stream.IntStream.range;
 import static org.assertj.core.api.Assertions.assertThat;
 
-import ch.qos.logback.classic.Level;
 import com.google.common.collect.Streams;
 import com.google.common.util.concurrent.RateLimiter;
 import com.rabbitmq.stream.BackOffDelayPolicy;
@@ -67,6 +66,7 @@
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.IntStream;
+import org.apache.logging.log4j.Level;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;

src/test/java/com/rabbitmq/stream/impl/TestUtils.java

@@ -22,7 +22,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.fail;
 
-import ch.qos.logback.classic.Level;
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
 import com.google.gson.JsonElement;
@@ -78,6 +77,9 @@
 import java.util.function.Predicate;
 import java.util.function.Supplier;
 import java.util.stream.IntStream;
+import org.apache.logging.log4j.Level;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.core.config.Configurator;
 import org.assertj.core.api.AssertDelegateTarget;
 import org.assertj.core.api.Assertions;
 import org.assertj.core.api.Condition;
@@ -1078,10 +1080,9 @@ void doesNotComplete(Duration timeout) {
   }
 
   static Level newLoggerLevel(Class<?> c, Level level) {
-    ch.qos.logback.classic.Logger logger =
-        (ch.qos.logback.classic.Logger) LoggerFactory.getLogger(c);
-    Level initialLevel = logger.getEffectiveLevel();
-    logger.setLevel(level);
+    org.apache.logging.log4j.Logger logger = LogManager.getLogger(c);
+    Level initialLevel = logger.getLevel();
+    Configurator.setLevel(c.getName(), level);
     return initialLevel;
   }
 

src/test/java/com/rabbitmq/stream/impl/TestUtilsTest.java

@@ -16,7 +16,6 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import java.util.concurrent.Executor;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
 
@@ -31,18 +30,4 @@ public class TestUtilsTest {
   void atLeastVersion(String expectedVersion, String currentVersion, boolean expected) {
     assertThat(TestUtils.atLeastVersion(expectedVersion, currentVersion)).isEqualTo(expected);
   }
-
-  private static class DelegatingExecutor implements Executor {
-
-    private final Executor delegate;
-
-    private DelegatingExecutor(Executor delegate) {
-      this.delegate = delegate;
-    }
-
-    @Override
-    public void execute(Runnable command) {
-      delegate.execute(command);
-    }
-  }
 }

src/test/resources/log4j2-test.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Configuration status="WARN">
+
+    <Appenders>
+        <Console name="STDOUT" target="SYSTEM_OUT">
+            <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %c{36} - %msg%n"/>
+        </Console>
+    </Appenders>
+
+    <Loggers>
+
+        <Logger name="com.rabbitmq.stream" level="warn" />
+        <Logger name="com.rabbitmq.stream.impl.Utils" level="warn" />
+        <Logger name="com.rabbitmq.stream.impl.StreamEnvironment" level="warn" />
+        <Logger name="com.rabbitmq.stream.impl.ConsumersCoordinator" level="warn" />
+        <Logger name="com.rabbitmq.stream.impl.ProducersCoordinator" level="warn" />
+        <Logger name="com.rabbitmq.stream.impl.RecoveryClusterTest" level="info" />
+        <Logger name="com.rabbitmq.stream.oauth2" level="warn" />
+        <Logger name="com.rabbitmq.stream.perf.Version" level="error" />
+
+        <Root level="info">
+            <AppenderRef ref="STDOUT"/>
+        </Root>
+
+    </Loggers>
+
+</Configuration>