QueueingConsumer.handle: Changed assert -> IllegalStateException for POISON sanity check.

aschmolck · aschmolck · commit 13d5b7ab5a84 · 2010-03-02T11:05:17.000Z
diff --git a/src/com/rabbitmq/client/QueueingConsumer.java b/src/com/rabbitmq/client/QueueingConsumer.java
@@ -137,7 +137,11 @@ private Delivery handle(Delivery delivery) {
             delivery == null && _shutdown != null) {
             if (delivery == POISON) {
                 _queue.add(POISON);
-                assert _shutdown != null;
+                if (_shutdown == null) {
+                    throw new IllegalStateException(
+                        "POISON in queue, but null _shutdown. " +
+                        "This should never happen, please report as a BUG");
+                }
             }
             throw Utility.fixStackTrace(_shutdown);
         }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,11 @@ private Delivery handle(Delivery delivery) {`
`137`	`137`	`delivery == null && _shutdown != null) {`
`138`	`138`	`if (delivery == POISON) {`
`139`	`139`	`_queue.add(POISON);`
`140`		`- assert _shutdown != null;`
	`140`	`+ if (_shutdown == null) {`
	`141`	`+ throw new IllegalStateException(`
	`142`	`+ "POISON in queue, but null _shutdown. " +`
	`143`	`+ "This should never happen, please report as a BUG");`
	`144`	`+ }`
`141`	`145`	`}`
`142`	`146`	`throw Utility.fixStackTrace(_shutdown);`
`143`	`147`	`}`