removed module leak in js_std_eval_binary()

past-due · Fabrice Bellard · bnoordhuis · commit d100933c49e3 · 2025-09-29T22:55:23.000+02:00
Port of bellard/quickjs@1fdc768 Co-authored-by: Fabrice Bellard <fabrice@bellard.org>
diff --git a/quickjs-libc.c b/quickjs-libc.c
@@ -4586,6 +4586,7 @@ void js_std_eval_binary(JSContext *ctx, const uint8_t *buf, size_t buf_len,
             if (js_module_set_import_meta(ctx, obj, false, false) < 0)
                 goto exception;
         }
+        JS_FreeValue(ctx, obj);
     } else {
         if (JS_VALUE_GET_TAG(obj) == JS_TAG_MODULE) {
             if (JS_ResolveModule(ctx, obj) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -4586,6 +4586,7 @@ void js_std_eval_binary(JSContext ctx, const uint8_t buf, size_t buf_len,`
`4586`	`4586`	`if (js_module_set_import_meta(ctx, obj, false, false) < 0)`
`4587`	`4587`	`goto exception;`
`4588`	`4588`	`}`
	`4589`	`+ JS_FreeValue(ctx, obj);`
`4589`	`4590`	`} else {`
`4590`	`4591`	`if (JS_VALUE_GET_TAG(obj) == JS_TAG_MODULE) {`
`4591`	`4592`	`if (JS_ResolveModule(ctx, obj) < 0) {`