SessionScheduleTest.java

/*******************************************************************************
 * Copyright (c) quickfixengine.org  All rights reserved.
 *
 * This file is part of the QuickFIX FIX Engine
 *
 * This file may be distributed under the terms of the quickfixengine.org
 * license as defined by quickfixengine.org and appearing in the file
 * LICENSE included in the packaging of this file.
 *
 * This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING
 * THE WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A
 * PARTICULAR PURPOSE.
 *
 * See http://www.quickfixengine.org/LICENSE for licensing information.
 *
 * Contact ask@quickfixengine.org if any conditions of this licensing
 * are not clear to you.
 ******************************************************************************/

package quickfix;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.text.DateFormat;
import java.text.DateFormatSymbols;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Calendar;
import java.util.Date;
import java.util.GregorianCalendar;
import java.util.Locale;
import java.util.TimeZone;

import org.junit.After;
import org.junit.Before;
import org.junit.Test;

import quickfix.field.converter.UtcTimeOnlyConverter;

public class SessionScheduleTest {
    private MockSystemTimeSource mockSystemTimeSource;
    private Locale defaultLocale;

    @Before
    public void setUp() throws Exception {
        mockSystemTimeSource = new MockSystemTimeSource();
        SystemTime.setTimeSource(mockSystemTimeSource);
        defaultLocale = Locale.getDefault();
        Locale.setDefault(Locale.GERMANY);
    }

    @After
    public void tearDown() throws Exception {
        SystemTime.setTimeSource(null);
        Locale.setDefault(defaultLocale);
    }

    @Test
    public void testSessionAlwaysActive() throws Exception {
        Calendar start = getUtcTime(0, 0, 0);
        Calendar end = getUtcTime(0, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);
        doIsSessionTimeTest(schedule, true, 2004, 10, 10, 10, 0, 0);
    }

    @Test
    public void testSessionTimeStartBeforeEnd() throws Exception {
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);
        doIsSessionTimeTest(schedule, true, 2004, 10, 10, 10, 0, 0);
        doIsSessionTimeTest(schedule, true, 2004, 10, 10, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2004, 10, 10, 2, 0, 0);
        doIsSessionTimeTest(schedule, false, 2004, 10, 10, 19, 0, 0);
        doIsSessionTimeTest(schedule, false, 2004, 10, 10, 18, 0, 1);
    }

    private SessionSchedule newSessionSchedule(Date startTime, Date endTime, int startDay,
            int endDay) throws Exception {
        SessionSettings settings = new SessionSettings();
        if (startDay >= 0) {
            settings.setString(Session.SETTING_START_DAY, DayConverter.toString(startDay));
        }
        if (endDay >= 0) {
            settings.setString(Session.SETTING_END_DAY, DayConverter.toString(endDay));
        }
        settings.setString(Session.SETTING_START_TIME, UtcTimeOnlyConverter.convert(startTime,
                false));
        settings.setString(Session.SETTING_END_TIME, UtcTimeOnlyConverter.convert(endTime, false));
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        return new DefaultSessionSchedule(settings, sessionID);
    }

    @Test
    public void testSessionTimeEndBeforeStart() throws Exception {
        Calendar start = getUtcTime(18, 0, 0);
        Calendar end = getUtcTime(3, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);
        doIsSessionTimeTest(schedule, true, 2000, Calendar.NOVEMBER, 10, 18, 0, 0);
        doIsSessionTimeTest(schedule, true, 2000, Calendar.NOVEMBER, 10, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2000, Calendar.NOVEMBER, 10, 4, 0, 0);
        doIsSessionTimeTest(schedule, false, 2004, Calendar.NOVEMBER, 10, 17, 0, 0);
    }

    @Test
    public void testShortSessionTestStartBeforeEnd() throws Exception {
        Calendar start = getUtcTime(18, 0, 0);
        Calendar end = getUtcTime(18, 30, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);
        doIsSessionTimeTest(schedule, false, 2000, 10, 10, 17, 15, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 18, 0, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 18, 15, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 18, 30, 0);
        doIsSessionTimeTest(schedule, false, 2000, 10, 10, 19, 30, 0);
    }

    @Test
    public void testShortSessionTestStartAfterEnd() throws Exception {
        Calendar start = getUtcTime(18, 30, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);
        doIsSessionTimeTest(schedule, false, 2000, 10, 10, 18, 15, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 18, 0, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 19, 15, 0);
        doIsSessionTimeTest(schedule, true, 2000, 10, 10, 18, 30, 0);
        doIsSessionTimeTest(schedule, false, 2000, 10, 10, 18, 25, 0);
    }

    private void doIsSessionTimeTest(SessionSchedule schedule, boolean expectedInSession, int year,
            int month, int day, int hour, int minute, int second) {
        doIsSessionTimeTest(schedule, expectedInSession, year, month, day, hour, minute, second,
                TimeZone.getTimeZone("UTC"));
    }

    private void doIsSessionTimeTest(SessionSchedule schedule, boolean expectedInSession, int year,
            int month, int day, int hour, int minute, int second, TimeZone timeZone) {
        mockSystemTimeSource
                .setTime(getTimeStamp(year, month, day, hour, minute, second, timeZone));
        assertEquals("in session expectation incorrect", expectedInSession, schedule
                .isSessionTime());
    }

    private void doIsSessionTimeTest(boolean expectedInSession, int year, int month, int day,
            int hour, int minute, int second, TimeZone timeZone, String scheduleStartDay,
            String scheduleEndDay) throws ConfigError, FieldConvertError {
        mockSystemTimeSource
                .setTime(getTimeStamp(year, month, day, hour, minute, second, timeZone));
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_DAY, scheduleStartDay);
        settings.setString(Session.SETTING_END_DAY, scheduleEndDay);
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertEquals("schedule is wrong", expectedInSession, schedule.isSessionTime());
    }

    private void doIsSessionTimeTest(SessionSettings settings, SessionID sessionID,
            boolean expectedInSession, int year, int month, int day, int hour, int minute,
            int second, String timeZoneID) throws ConfigError, FieldConvertError {
        mockSystemTimeSource.setTime(getTimeStamp(year, month, day, hour, minute, second, TimeZone
                .getTimeZone(timeZoneID)));
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertEquals("schedule is wrong", expectedInSession, schedule.isSessionTime());
    }

    @Test
    public void testSessionTimeWithDay() throws Exception {
        Calendar start = getUtcTime(18, 0, 0);
        Calendar end = getUtcTime(3, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(),
                Calendar.SATURDAY, Calendar.SATURDAY);

        // July 24, 2004 - Saturday
        // July 25, 2004 - Sunday
        // Schedule Saturday 18:00 to following Saturday 03:00
        doIsSessionTimeTest(schedule, false, 2004, Calendar.JULY, 24, 10, 0, 0);
        doIsSessionTimeTest(schedule, true, 2004, Calendar.JULY, 24, 18, 0, 0);
        doIsSessionTimeTest(schedule, true, 2004, Calendar.JULY, 24, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2004, Calendar.JULY, 24, 3, 0, 1);
        doIsSessionTimeTest(schedule, true, 2004, Calendar.JULY, 24, 18, 0, 1);
        doIsSessionTimeTest(schedule, true, 2004, Calendar.JULY, 25, 3, 0, 1);
        doIsSessionTimeTest(schedule, true, 2004, Calendar.JULY, 26, 18, 0, 1);
    }

    @Test
    public void testIsSameSessionWithoutDay() throws Exception {
        // =====================================================
        // start time is less than end time
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);

        // same time
        Calendar t1 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        Calendar t2 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 2 in same session but greater
        t1 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 11, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 2 in same session but less
        t1 = getUtcTimeStamp(2000, 10, 10, 11, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 1 not in session
        t1 = getUtcTimeStamp(2000, 10, 10, 19, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // time 2 not in session
        t1 = getUtcTimeStamp(2000, 10, 10, 10, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 2, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // same time (in session window) two different days
        t1 = getUtcTimeStamp(2000, 10, 10, 12, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 11, 12, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // =====================================================
        // start time is greater than end time
        start = getUtcTime(18, 0, 0);
        end = getUtcTime(13, 0, 0);
        schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);

        // same session same day
        t1 = getUtcTimeStamp(2000, 10, 10, 19, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 20, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // same time (in session window) two different days
        t1 = getUtcTimeStamp(2000, 10, 10, 19, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 11, 19, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // same session time 2 is in next day
        t1 = getUtcTimeStamp(2000, 10, 10, 19, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 11, 2, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // same session time 1 is in next day
        t1 = getUtcTimeStamp(2000, 10, 11, 2, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 19, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 1 is 25 hours greater than time 2
        t1 = getUtcTimeStamp(2000, 10, 11, 21, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 20, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // ------------

        start = getUtcTime(10, 0, 0);
        end = getUtcTime(2, 0, 0);
        schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);

        t1 = getUtcTimeStamp(2000, 10, 10, 17, 0, 0);
        t2 = getUtcTimeStamp(2000, 10, 10, 1, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);
        t2 = getUtcTimeStamp(2000, 10, 9, 23, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // =====================================================
        // start time is equal to end time
        start = getUtcTime(6, 0, 0);
        end = getUtcTime(6, 0, 0);
        schedule = newSessionSchedule(start.getTime(), end.getTime(), -1, -1);

        t1 = getUtcTimeStamp(2004, 1, 13, 19, 10, 0);
        t2 = getUtcTimeStamp(2004, 10, 14, 19, 6, 0);
        doIsSameSessionTest(schedule, t1, t2, false);
    }

    @Test
    public void testIsSameSessionWithDay() throws Exception {
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(),
                Calendar.MONDAY, Calendar.THURSDAY);

        Calendar t1 = getUtcTimeStamp(2004, Calendar.JULY, 27, 3, 0, 0);
        Calendar t2 = getUtcTimeStamp(2004, Calendar.JULY, 25, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 31, 3, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 27, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 27, 3, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 27, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 26, 10, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 27, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 27, 10, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 29, 2, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 27, 10, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 20, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 27, 2, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 20, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        t1 = getUtcTimeStamp(2004, Calendar.JULY, 26, 2, 0, 0);
        t2 = getUtcTimeStamp(2004, Calendar.JULY, 19, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // Reset start/end time so that they fall within an hour of midnight
        Calendar startTime = getUtcTime(0, 5, 0);
        Calendar endTime = getUtcTime(23, 45, 0);

        // Make it a week-long session
        int startDay = 1;
        int endDay = 7;
        schedule = newSessionSchedule(startTime.getTime(), endTime.getTime(), startDay, endDay);

        // Check that ST-->DST (Sunday is missing one hour) is handled
        t1 = getUtcTimeStamp(2006, Calendar.APRIL, 4, 0, 0, 0);
        t2 = getUtcTimeStamp(2006, Calendar.APRIL, 3, 1, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // Check that DST-->ST (Sunday has an extra hour) is handled
        t1 = getUtcTimeStamp(2006, Calendar.OCTOBER, 30, 1, 0, 0);
        t2 = getUtcTimeStamp(2006, Calendar.OCTOBER, 31, 1, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // Check that everything works across a year boundary
        t1 = getUtcTimeStamp(2006, Calendar.DECEMBER, 31, 10, 10, 10);
        t2 = getUtcTimeStamp(2007, Calendar.JANUARY, 1, 10, 10, 10);
        doIsSameSessionTest(schedule, t1, t2, true);
    }

    @Test
    public void testSessionStartInPreviousDayOfWeek() throws Exception {
        Locale.setDefault(new Locale("en", "AU"));

        final TimeZone tz = TimeZone.getTimeZone("Australia/Victoria");
        mockSystemTimeSource.setTime(getTimeStamp(2026, Calendar.FEBRUARY, 23, 10, 0, 0, tz));

        final SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "13:00:00 Australia/Victoria");

        // AU week starts on Sunday on Java 17 and below, but on Monday on Java 21 and above (not sure about in between).
        settings.setString(Session.SETTING_START_DAY, "Sunday");

        settings.setString(Session.SETTING_END_TIME, "17:00:00 America/New_York");
        settings.setString(Session.SETTING_END_DAY, "Saturday");

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        final SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);

        mockSystemTimeSource
                .setTime(getTimeStamp(2026, Calendar.FEBRUARY, 23, 10, 0, 0, tz));
        assertEquals("in session expectation incorrect", true, schedule
                .isSessionTime());
    }

    @Test
    public void testSettingsWithoutStartEndDay() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "01:00:00 ");
        settings.setString(Session.SETTING_END_TIME, " 05:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2002, 5, 5, 0, 30, 0);
        doIsSessionTimeTest(schedule, true, 2002, 7, 5, 1, 30, 0);
        doIsSessionTimeTest(schedule, false, 2003, 5, 5, 6, 30, 0);
    }

    @Test
    public void testSettingsWithStartEndDay() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.TUESDAY));
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "05:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2006, 1, 27, 0, 30, 0);
        doIsSessionTimeTest(schedule, false, 2006, 1, 27, 1, 30, 0);
        doIsSessionTimeTest(schedule, true, 2006, 1, 28, 1, 30, 0);
        doIsSessionTimeTest(schedule, true, 2006, 1, 28, 6, 30, 0);
        doIsSessionTimeTest(schedule, false, 2006, 2, 4, 4, 30, 0);
    }

    @Test
    // QFJ-228
    public void testSettingsWithStartEndDayWithDayRoll() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "America/Chicago");
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.MONDAY));
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        // The Friday day must roll over to Saturday when the time is converted to UTC
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "19:30:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, true, 2007, Calendar.AUGUST, 23, 0, 25, 0,
                TimeZone.getTimeZone("America/Chicago"));
    }

    @Test
    public void testSettingsWithoutStartEndDayWithTimeZone() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "  US/Eastern ");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        doIsSessionTimeTest(schedule, false, 2002, 5, 5, 0, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2002, 7, 5, 14, 30, 0, tz);
        doIsSessionTimeTest(schedule, false, 2003, 5, 5, 16, 30, 0, tz);
    }

    @Test
    public void testSettingsWithoutStartEndDayWithTimeZoneInTime() throws Exception {
        // This test is very susceptible to whether the system time starts
        // in daylight time or not, so we just force it that way.  Otherwise
        // the first time the mock time source gets set to a time with daylight time
        // then the schedule appears to change 1 hr.
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        mockSystemTimeSource.setTime(getTimeStamp(2002, 5, 5, 0, 0, 0, tz));
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "01:00:00 US/Eastern");
        settings.setString(Session.SETTING_END_TIME, "15:00:00 US/Central");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2002, 5, 5, 0, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2002, 7, 5, 14, 30, 0, tz);

        // The end time is actually 16:00 Eastern time but specified as
        // 15:00 Central time.
        doIsSessionTimeTest(schedule, true, 2003, 5, 5, 15, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2003, 5, 5, 16, 0, 0, tz);
        doIsSessionTimeTest(schedule, false, 2003, 5, 5, 16, 1, 0, tz);
    }

    @Test
    public void testSettingsWithStartEndDayAndTimeZone() throws Exception {
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        String scheduleStartDay = DayConverter.toString(Calendar.TUESDAY);
        String scheduleEndDay = DayConverter.toString(Calendar.FRIDAY);
        // Time interval is 1:00 - 15:00

        // Monday is out of session interval
        doIsSessionTimeTest(false, 2006, 1, 27, 0, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        // Monday is out of session interval, time is in.
        doIsSessionTimeTest(false, 2006, 1, 27, 1, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        // Tuesday is in interval, time is out.
        doIsSessionTimeTest(false, 2006, 1, 28, 0, 59, 0, tz, scheduleStartDay, scheduleEndDay);

        doIsSessionTimeTest(true, 2006, 1, 28, 14, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, 2, 1, 0, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, 2, 3, 14, 30, 0, tz, scheduleStartDay, scheduleEndDay);

        // Friday in interval, time is out
        doIsSessionTimeTest(false, 2006, 2, 3, 16, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        // Saturday is out of interval
        doIsSessionTimeTest(false, 2006, 2, 4, 16, 30, 0, TimeZone.getTimeZone("UTC"),
                scheduleStartDay, scheduleEndDay);
    }

    @Test
    public void testSettingsWithStartGreaterThanEndDayAndTimeZone() throws Exception {
        String scheduleStartDay = DayConverter.toString(Calendar.FRIDAY);
        String scheduleEndDay = DayConverter.toString(Calendar.MONDAY);
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        doIsSessionTimeTest(true, 2006, Calendar.FEBRUARY, 27, 0, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, Calendar.FEBRUARY, 27, 1, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(false, 2006, Calendar.FEBRUARY, 27, 16, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(false, 2006, Calendar.FEBRUARY, 28, 0, 59, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(false, 2006, Calendar.FEBRUARY, 28, 14, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(false, 2006, Calendar.MARCH, 1, 0, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(false, 2006, Calendar.MARCH, 3, 0, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, Calendar.MARCH, 3, 14, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, Calendar.MARCH, 3, 16, 30, 0, tz, scheduleStartDay, scheduleEndDay);
        doIsSessionTimeTest(true, 2006, Calendar.MARCH, 4, 16, 30, 0, TimeZone.getTimeZone("UTC"),
                scheduleStartDay, scheduleEndDay);
    }

    /**
     * From 1968 to 1971, GMT was an hour ahead of UTC. If we perform all our calculations in 1970,
     * someone in GMT (e.g. London) will see sessions ending an hour later than expected. This test
     * demonstrates the 1970 behavior and verifies that calculations on current dates give the proper results.
     *
     * <p/>
     * More details at:
     * <p/>
     * http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4644278
     * http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4832236
     */
    @Test
    public void testThatUTCAndGMTAreTheSameNow() throws ConfigError, FieldConvertError,
            ParseException {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "00:01:00");
        settings.setString(Session.SETTING_END_TIME, "21:50:00");

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        // In 1970, a session configured to end at 21:50 UTC would end at
        // 22:50 London time any time of year.
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JANUARY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JANUARY, 27, 22, 50, 1,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JULY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JULY, 27, 22, 50, 1,
                "Europe/London");

        // Now, at least in winter, it should end at 21:50 in both zones --
        // if the end time session setting is being parsed correctly.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.FEBRUARY, 27, 21, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.FEBRUARY, 27, 21, 50, 1,
                "Europe/London");

        // When summer time (BST) is in effect, London time will be an hour
        // ahead again, and the session will end at 22:50 there.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.JULY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.JULY, 27, 22, 50, 1,
                "Europe/London");

        settings.setString(Session.SETTING_TIMEZONE, "Europe/London");

        // In 1970, a session configured to end at 21:50 GMT would end at
        // 20:50 UTC any time of year.
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JANUARY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JANUARY, 27, 20, 50, 1,
                "UTC");
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JULY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JULY, 27, 20, 50, 1, "UTC");

        // Now, at least in winter, it should end at 21:50 in both zones --
        // if the end time session setting is being parsed correctly.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.FEBRUARY, 27, 21, 50, 0,
                "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.FEBRUARY, 27, 21, 50, 1,
                "UTC");

        // When summer time (BST) is in effect, London time will be an hour
        // ahead again, and the session will end at 20:50 UTC there.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.JULY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.JULY, 27, 20, 50, 1, "UTC");
    }

    @Test
    public void testBadDaySpecification() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_DAY, "BOGUS");
        settings.setString(Session.SETTING_END_DAY, "FARGLE");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        try {
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("invalid format"));
        }
    }

    @Test
    public void testBadTimeSpecification() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        try {
            settings.setString(Session.SETTING_START_TIME, "01:xx:00");
            settings.setString(Session.SETTING_END_TIME, "15:00:00");
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("could not parse"));
        }

        try {
            settings.setString(Session.SETTING_START_TIME, "01:00:00");
            settings.setString(Session.SETTING_END_TIME, "15:00:yy");
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("could not parse"));
        }
    }

    @Test
    public void testMissingStartOrEndDay() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        String[] dayNames = new DateFormatSymbols(Locale.getDefault()).getWeekdays();

        try {
            settings.setString(sessionID, Session.SETTING_START_DAY, dayNames[1]);
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("without EndDay"));
        }

        try {
            settings.removeSetting(sessionID, Session.SETTING_START_DAY);
            settings.setString(Session.SETTING_END_DAY, dayNames[1]);
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("without StartDay"));
        }
    }

    @Test
    public void testBadTimeZone() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/BOGUS");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        try {
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("Unrecognized time zone"));
        }
    }

    @Test
    public void testWeeklyToString() throws ConfigError, FieldConvertError {
        // Just be sure it doesn't throw exceptions
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.TUESDAY));
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertNotNull(schedule.toString());
    }

    @Test
    public void testDailyToString() throws ConfigError, FieldConvertError {
        // Just be sure it doesn't throw exceptions
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertNotNull(schedule.toString());
    }

    @Test
    public void testWeeklyIsSessionTimePeriodically() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_START_TIME, "16:00:00");
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "13:00:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        Calendar c = SystemTime.getUtcCalendar();
        c.set(Calendar.DAY_OF_WEEK, Calendar.FRIDAY);
        c.set(Calendar.HOUR_OF_DAY, 15);
        c.set(Calendar.MINUTE, 0);
        c.set(Calendar.SECOND, 0);
        mockSystemTimeSource.setTime(c);

        assertFalse(schedule.isSessionTime());

        int timeIncrement = 5; // seconds

        for (;;) {
            if (schedule.isSessionTime()) {
                c.set(Calendar.HOUR_OF_DAY, 16);
                c.set(Calendar.MINUTE, 0);
                Calendar actual = SystemTime.getUtcCalendar();
                assertEquals("wrong start time", c.getTime(), actual.getTime());
                break;
            }
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }

        for (;;) {
            if (!schedule.isSessionTime()) {
                c.add(Calendar.WEEK_OF_YEAR, 1);
                c.set(Calendar.HOUR_OF_DAY, 13);
                c.set(Calendar.MINUTE, 0);
                Calendar actual = SystemTime.getUtcCalendar();
                assertEquals("wrong end time", c.getTime(), actual.getTime());
                break;
            }
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }
    }

    @Test
    public void testWeeklyIsSameSessionPeriodically() throws Exception {
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.WEDNESDAY), "14:00:00", DayConverter.toString(Calendar.WEDNESDAY), "12:00:00");
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.WEDNESDAY), "14:00:00", DayConverter.toString(Calendar.TUESDAY), "18:00:00");
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.WEDNESDAY), "14:00:00", DayConverter.toString(Calendar.TUESDAY), "12:00:00");
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.WEDNESDAY), "14:00:00", DayConverter.toString(Calendar.FRIDAY), "18:00:00");
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.WEDNESDAY), "14:00:00", DayConverter.toString(Calendar.FRIDAY), "12:00:00");
        doWeeklyIsSameSessionTest(DayConverter.toString(Calendar.FRIDAY), "14:00:00", DayConverter.toString(Calendar.FRIDAY), "13:59:00");
    }

    @Test
    public void testSettingsWithDST() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "Europe/Zurich");
        settings.setString(Session.SETTING_START_TIME, "01:30:00");
        settings.setString(Session.SETTING_END_TIME, "03:15:00");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        //
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 20, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 20, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 27, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 27, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 28, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 28, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 29, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 29, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 30, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 30, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 31, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich")); // -> this is 03:16 !
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 31, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2013, Calendar.APRIL, 1, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.APRIL, 1, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
    }

    @Test
    public void testSettingsWithStartEndDayWithDST() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "America/New_York");
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.SUNDAY));
        settings.setString(Session.SETTING_START_TIME, "20:00:00");
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "17:00:00");

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);

        //System.out.println(schedule);

        // November,2 -> Sunday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 2, 20, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
        // November,7 -> Friday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 7, 17, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
    }

    @Test
    public void testSettingsWithStartEndDayWithDSTMocked() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "America/New_York");
        settings.setString(Session.SETTING_START_DAY, DayConverter.toString(Calendar.SUNDAY));
        settings.setString(Session.SETTING_START_TIME, "20:00:00");
        settings.setString(Session.SETTING_END_DAY, DayConverter.toString(Calendar.FRIDAY));
        settings.setString(Session.SETTING_END_TIME, "17:00:00");

        mockSystemTimeSource.setTime(getTimeStamp(2008, Calendar.NOVEMBER, 2, 18, 0, 0, TimeZone.getTimeZone("America/New_York")));

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);

        //System.out.println(schedule);

        // November,2 -> Sunday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 2, 20, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
        // November,7 -> Friday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 7, 17, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
    }

    @Test
    // QFJ-767
    public void testNonStopSession() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_NON_STOP_SESSION, "Y");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertTrue(schedule.isSameSession(null, null));
    }

    private void doWeeklyIsSameSessionTest(String startDay, String startTimeString, String endDay,
            String endTimeString) throws ConfigError, FieldConvertError, ParseException {
        DateFormat timeFormat = new SimpleDateFormat("HH:mm:ss");
        timeFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
        Calendar startTime = parseTime(startTimeString, timeFormat);
        Calendar endTime = parseTime(endTimeString, timeFormat);

        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_DAY, startDay);
        settings.setString(Session.SETTING_START_TIME, startTimeString);
        settings.setString(Session.SETTING_END_DAY, endDay);
        settings.setString(Session.SETTING_END_TIME, endTimeString);
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);

        Calendar sessionCreateTime = SystemTime.getUtcCalendar();

        Calendar scheduleStartTime = SystemTime.getUtcCalendar();
        scheduleStartTime.set(Calendar.DAY_OF_WEEK, DayConverter.toInteger(startDay));
        scheduleStartTime.set(Calendar.HOUR_OF_DAY, startTime.get(Calendar.HOUR_OF_DAY));
        scheduleStartTime.set(Calendar.MINUTE, startTime.get(Calendar.MINUTE));
        scheduleStartTime.set(Calendar.SECOND, startTime.get(Calendar.SECOND));
        scheduleStartTime.set(Calendar.MILLISECOND, 0);

        Calendar scheduleEndTime = SystemTime.getUtcCalendar();
        scheduleEndTime.set(Calendar.DAY_OF_WEEK, DayConverter.toInteger(endDay));
        scheduleEndTime.set(Calendar.HOUR_OF_DAY, endTime.get(Calendar.HOUR_OF_DAY));
        scheduleEndTime.set(Calendar.MINUTE, endTime.get(Calendar.MINUTE));
        scheduleEndTime.set(Calendar.SECOND, endTime.get(Calendar.SECOND));
        scheduleEndTime.set(Calendar.MILLISECOND, 0);
        if (scheduleStartTime.after(scheduleEndTime)) {
            scheduleEndTime.add(Calendar.DATE, 7); // one week later
        }

        sessionCreateTime.setTime(scheduleStartTime.getTime());
        while (sessionCreateTime.before(scheduleEndTime)) {
            //System.out.println(formatCalendar(sessionCreateTime));
            doWeeklyIsSameSessionTest(schedule, sessionCreateTime, (Calendar) scheduleStartTime
                    .clone(), (Calendar) scheduleEndTime.clone());
            sessionCreateTime.add(Calendar.MINUTE, 23);
            sessionCreateTime.add(Calendar.SECOND, 11);
        }
    }

    private Calendar parseTime(String time, DateFormat timeFormat) throws ParseException {
        Calendar start = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
        start.setTime(timeFormat.parse(time));
        return start;
    }

    private void doWeeklyIsSameSessionTest(SessionSchedule schedule, Calendar sessionCreateTime,
            Calendar scheduleStartTime, Calendar scheduleEndTime) {
        Calendar initialSystemTime = SystemTime.getUtcCalendar();
        initialSystemTime.set(Calendar.DAY_OF_WEEK, Calendar.FRIDAY);
        initialSystemTime.set(Calendar.HOUR_OF_DAY, 15);
        initialSystemTime.set(Calendar.MINUTE, 0);
        initialSystemTime.set(Calendar.SECOND, 0);
        mockSystemTimeSource.setTime(initialSystemTime);

        int timeIncrement = 17; // seconds

        while (beforeSession(scheduleStartTime)) {
            assertFalse(formatErrorMessage("before session", sessionCreateTime), schedule
                    .isSameSession(sessionCreateTime, SystemTime.getUtcCalendar()));
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }

        while (withinSession(scheduleStartTime, scheduleEndTime)
                && SystemTime.getUtcCalendar().before(sessionCreateTime)) {
            // This should be an impossible situation. "Now" should always be
            // after the session create time.
            assertFalse(formatErrorMessage("before create", sessionCreateTime), schedule
                    .isSameSession(sessionCreateTime, SystemTime.getUtcCalendar()));
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }

        while (withinSession(scheduleStartTime, scheduleEndTime)) {
            assertTrue(formatErrorMessage("within", sessionCreateTime), schedule.isSameSession(
                    sessionCreateTime, SystemTime.getUtcCalendar()));
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }

        scheduleStartTime.add(Calendar.DATE, 7);
        scheduleEndTime.add(Calendar.DATE, 7);

        while (beforeSession(scheduleStartTime)) {
            assertFalse(formatErrorMessage("after", sessionCreateTime), schedule.isSameSession(
                    sessionCreateTime, SystemTime.getUtcCalendar()));
            mockSystemTimeSource.increment(timeIncrement * 1000L);
        }
    }

    private final SimpleDateFormat dateFormat = new SimpleDateFormat("E M/d HH:mm:ss");
    
    {
        dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
    }

    protected String formatCalendar(Calendar c) {
        return dateFormat.format(c.getTime());
    }

    private String formatErrorMessage(String label, Calendar sessionCreateTime) {
        return label + " -- Created: " + formatCalendar(sessionCreateTime) + ", Now: "
                + formatCalendar(SystemTime.getUtcCalendar());
    }

    private boolean withinSession(Calendar start, Calendar end) {
        Calendar now = SystemTime.getUtcCalendar();
        return (now.after(start) || now.equals(start)) && (now.before(end) || now.equals(end));
    }

    private boolean beforeSession(Calendar start) {
        return SystemTime.getUtcCalendar().before(start);
    }

    private void doIsSameSessionTest(SessionSchedule schedule, Calendar time1, Calendar time2,
            boolean isSameSession) {
        assertEquals("isSameSession is wrong", isSameSession, schedule.isSameSession(time1, time2));
        assertEquals("isSameSession is wrong", isSameSession, schedule.isSameSession(time2, time1));
    }

    private Calendar getTimeStamp(int year, int month, int day, int hour, int minute, int second,
            TimeZone timeZone) {
        Calendar c = new GregorianCalendar(year, month, day, hour, minute, second);
        c.setTimeZone(timeZone);
        return c;
    }

    private Calendar getUtcTimeStamp(int year, int month, int day, int hour, int minute, int second) {
        return getTimeStamp(year, month, day, hour, minute, second, TimeZone.getTimeZone("UTC"));
    }

    private Calendar getUtcTime(int hour, int minute, int second) {
        Calendar c = new GregorianCalendar(2006, 0, 1, hour, minute, second);
        c.setTimeZone(TimeZone.getTimeZone("UTC"));
        return c;
    }

    private SessionSchedule newSessionSchedule(Date startTime, Date endTime, String weekdays) throws Exception {
        SessionSettings settings = new SessionSettings();
        if (weekdays != null && weekdays.length() > 0) {
            settings.setString(Session.SETTING_WEEKDAYS, weekdays);
        }
        if (startTime != null) {
            settings.setString(Session.SETTING_START_TIME, UtcTimeOnlyConverter.convert(startTime, false));
        }
        if (endTime != null) {
            settings.setString(Session.SETTING_END_TIME, UtcTimeOnlyConverter.convert(endTime, false));
        }
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        return new DefaultSessionSchedule(settings, sessionID);
    }

    @Test
    public void testMissingStartTime() throws Exception {
        Calendar end = getUtcTime(18, 0, 0);
        try {
            newSessionSchedule(null, end.getTime(), "Mon");
            fail("no exception");
        } catch (ConfigError e) {
            // do nothing
        }
    }

    @Test
    public void testMissingEndTime() throws Exception {
        Calendar start = getUtcTime(3, 0, 0);
        try {
            newSessionSchedule(start.getTime(), null, "Mon");
            fail("no exception");
        } catch (ConfigError e) {
            // do nothing
        }
    }

    @Test
    public void testInvalidWeekdays1() throws Exception {
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        try {
            newSessionSchedule(start.getTime(), end.getTime(), "AAA");
            fail("no exception");
        } catch (ConfigError e) {
            // do nothing
        }
    }

    @Test
    public void testSessionTimeStartBeforeEndUsingWeekdays() throws Exception {
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), "Mon,Tue,Wed,Thu,Fri");
        // Sunday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 2, 59, 59);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 18, 0, 1);
        // Monday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 2, 2, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 2, 3, 0, 0);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 2, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 2, 18, 0, 1);
        // Tuesday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 3, 2, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 3, 3, 0, 0);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 3, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 3, 18, 0, 1);
        // Wednesday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 4, 2, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 4, 3, 0, 0);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 4, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 4, 18, 0, 1);
        // Thursday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 5, 2, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 5, 3, 0, 0);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 5, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 5, 18, 0, 1);
        // Friday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 6, 2, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 6, 3, 0, 0);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 6, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 6, 18, 0, 1);
        // Saturday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 2, 59, 59);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 18, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 18, 0, 1);
    }

    @Test
    public void testSessionTimeEndBeforeStartUsingWeekdays() throws Exception {
        Calendar start = getUtcTime(18, 0, 0);
        Calendar end = getUtcTime(3, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), "Mon,Tue,Wed,Thu,Fri");
        // Sunday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 17, 59, 59);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 1, 18, 0, 0);
        // Monday
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 2, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 2, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 2, 17, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 2, 18, 0, 0);
        // Tuesday
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 3, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 3, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 3, 17, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 3, 18, 0, 0);
        // Wednesday
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 4, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 4, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 4, 17, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 4, 18, 0, 0);
        // Thursday
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 5, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 5, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 5, 17, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 5, 18, 0, 0);
        // Friday
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 6, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 6, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 6, 17, 59, 59);
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 6, 18, 0, 0);
        // Saturday
        doIsSessionTimeTest(schedule, true, 2017, Calendar.JANUARY, 7, 3, 0, 0);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 3, 0, 1);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 17, 59, 59);
        doIsSessionTimeTest(schedule, false, 2017, Calendar.JANUARY, 7, 18, 0, 0);
    }

    @Test
    public void testIsSameSessionUsingWeekdays() throws Exception {
        // =====================================================
        // start time is less than end time
        Calendar start = getUtcTime(3, 0, 0);
        Calendar end = getUtcTime(18, 0, 0);
        SessionSchedule schedule = newSessionSchedule(start.getTime(), end.getTime(), "Mon,Tue,Wed,Thu,Fri");

        // same time
        Calendar t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        Calendar t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 2 in same session but greater
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 2 in same session but less
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 1 not in session
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 1);
        doIsSameSessionTest(schedule, t1, t2, false);

        // time 2 not in session
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 1);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // same time (in session window) two different days
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 3, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // =====================================================
        // start time is greater than end time
        start = getUtcTime(18, 0, 0);
        end = getUtcTime(13, 0, 0);
        schedule = newSessionSchedule(start.getTime(), end.getTime(), "Mon,Tue,Wed,Thu,Fri");

        // same session same day
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 19, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // same time (in session window) two different days
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 18, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // same session time 2 is in next day
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 3, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // same session time 1 is in next day
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 3, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, true);

        // time 1 is 25 hours greater than time 2
        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 19, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);

        // =====================================================
        // start time is equal to end time
        start = getUtcTime(6, 0, 0);
        end = getUtcTime(6, 0, 0);
        schedule = newSessionSchedule(start.getTime(), end.getTime(), "Mon,Tue,Wed,Thu,Fri");

        t1 = getUtcTimeStamp(2017, Calendar.JANUARY, 3, 18, 0, 0);
        t2 = getUtcTimeStamp(2017, Calendar.JANUARY, 2, 18, 0, 0);
        doIsSameSessionTest(schedule, t1, t2, false);
    }

    @Test
    public void testSettingsWithoutStartEndDayWithTimeZoneUsingWeekdays() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "  US/Eastern ");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        doIsSessionTimeTest(schedule, false, 2002, 5, 5, 0, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2002, 7, 5, 14, 30, 0, tz);
        doIsSessionTimeTest(schedule, false, 2003, 5, 5, 16, 30, 0, tz);
    }

    @Test
    public void testSettingsWithTimeZoneInTimeUsingWeekdays() throws Exception {
        // This test is very susceptible to whether the system time starts
        // in daylight time or not, so we just force it that way.  Otherwise
        // the first time the mock time source gets set to a time with daylight time
        // then the schedule appears to change 1 hr.
        TimeZone tz = TimeZone.getTimeZone("US/Eastern");
        mockSystemTimeSource.setTime(getTimeStamp(2002, 5, 5, 0, 0, 0, tz));
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "01:00:00 US/Eastern");
        settings.setString(Session.SETTING_END_TIME, "15:00:00 US/Central");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2002, 5, 5, 0, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2002, 7, 5, 14, 30, 0, tz);

        // The end time is actually 16:00 Eastern time but specified as
        // 15:00 Central time.
        doIsSessionTimeTest(schedule, true, 2003, 5, 5, 15, 59, 0, tz);
        doIsSessionTimeTest(schedule, true, 2003, 5, 5, 16, 0, 0, tz);
        doIsSessionTimeTest(schedule, false, 2003, 5, 5, 16, 1, 0, tz);
    }

    /**
     * From 1968 to 1971, GMT was an hour ahead of UTC. If we perform all our calculations in 1970,
     * someone in GMT (e.g. London) will see sessions ending an hour later than expected. This test
     * demonstrates the 1970 behavior and verifies that calculations on current dates give the proper results.
     *
     * <p/>
     * More details at:
     * <p/>
     * http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4644278
     * http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4832236
     */
    @Test
    public void testThatUTCAndGMTAreTheSameNowUsingWeekdays() throws ConfigError, FieldConvertError,
            ParseException {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "00:01:00");
        settings.setString(Session.SETTING_END_TIME, "21:50:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri,Sat,Sun");

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        // In 1970, a session configured to end at 21:50 UTC would end at
        // 22:50 London time any time of year.
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JANUARY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JANUARY, 27, 22, 50, 1,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JULY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JULY, 27, 22, 50, 1,
                "Europe/London");

        // Now, at least in winter, it should end at 21:50 in both zones --
        // if the end time session setting is being parsed correctly.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.FEBRUARY, 27, 21, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.FEBRUARY, 27, 21, 50, 1,
                "Europe/London");

        // When summer time (BST) is in effect, London time will be an hour
        // ahead again, and the session will end at 22:50 there.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.JULY, 27, 22, 50, 0,
                "Europe/London");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.JULY, 27, 22, 50, 1,
                "Europe/London");

        settings.setString(Session.SETTING_TIMEZONE, "Europe/London");

        // In 1970, a session configured to end at 21:50 GMT would end at
        // 20:50 UTC any time of year.
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JANUARY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JANUARY, 27, 20, 50, 1,
                "UTC");
        doIsSessionTimeTest(settings, sessionID, true, 1970, Calendar.JULY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 1970, Calendar.JULY, 27, 20, 50, 1, "UTC");

        // Now, at least in winter, it should end at 21:50 in both zones --
        // if the end time session setting is being parsed correctly.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.FEBRUARY, 27, 21, 50, 0,
                "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.FEBRUARY, 27, 21, 50, 1,
                "UTC");

        // When summer time (BST) is in effect, London time will be an hour
        // ahead again, and the session will end at 20:50 UTC there.
        doIsSessionTimeTest(settings, sessionID, true, 2006, Calendar.JULY, 27, 20, 50, 0, "UTC");
        doIsSessionTimeTest(settings, sessionID, false, 2006, Calendar.JULY, 27, 20, 50, 1, "UTC");
    }

    @Test
    public void testBadTimeSpecificationUsingWeekdays() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        try {
            settings.setString(Session.SETTING_START_TIME, "01:xx:00");
            settings.setString(Session.SETTING_END_TIME, "15:00:00");
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("could not parse"));
        }

        try {
            settings.setString(Session.SETTING_START_TIME, "01:00:00");
            settings.setString(Session.SETTING_END_TIME, "15:00:yy");
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("could not parse"));
        }
    }

    @Test
    public void testBadTimeZoneUsingWeekdays() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/BOGUS");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");

        try {
            new DefaultSessionSchedule(settings, sessionID);
            fail("no exception");
        } catch (ConfigError e) {
            assertTrue(e.getMessage().contains("Unrecognized time zone"));
        }
    }

    @Test
    public void testWeekdayToString() throws ConfigError, FieldConvertError {
        // Just be sure it doesn't throw exceptions
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "US/Eastern");
        settings.setString(Session.SETTING_START_TIME, "01:00:00");
        settings.setString(Session.SETTING_END_TIME, "15:00:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        assertNotNull(schedule.toString());
    }

    @Test
    public void testSettingsWithDSTUsingWeekdays() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "Europe/Zurich");
        settings.setString(Session.SETTING_START_TIME, "01:30:00");
        settings.setString(Session.SETTING_END_TIME, "03:15:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri,Sat,Sun");
        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        //
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 20, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 20, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 20, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 27, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 27, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 27, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 28, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 28, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 28, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 29, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2012, Calendar.OCTOBER, 29, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2012, Calendar.OCTOBER, 29, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        schedule = new DefaultSessionSchedule(settings, sessionID);
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 30, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 30, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 30, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 31, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich")); // -> this is 03:16 !
        doIsSessionTimeTest(schedule, true, 2013, Calendar.MARCH, 31, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.MARCH, 31, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        //
        doIsSessionTimeTest(schedule, false, 2013, Calendar.APRIL, 1, 1, 29, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 1, 31, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 2, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, true, 2013, Calendar.APRIL, 1, 3, 14, 0, TimeZone.getTimeZone("Europe/Zurich"));
        doIsSessionTimeTest(schedule, false, 2013, Calendar.APRIL, 1, 3, 16, 0, TimeZone.getTimeZone("Europe/Zurich"));
    }

    @Test
    public void testSettingsWithStartEndDayWithDSTMockedUsingWeekdays() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_TIMEZONE, "America/New_York");
        settings.setString(Session.SETTING_START_TIME, "20:00:00");
        settings.setString(Session.SETTING_END_TIME, "17:00:00");
        settings.setString(Session.SETTING_WEEKDAYS, "Mon,Tue,Wed,Thu,Fri,Sat,Sun");

        mockSystemTimeSource.setTime(getTimeStamp(2008, Calendar.NOVEMBER, 2, 18, 0, 0, TimeZone.getTimeZone("America/New_York")));

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);

        // November,2 -> Sunday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 2, 20, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
        // November,7 -> Friday
        doIsSessionTimeTest(schedule, true, 2008, Calendar.NOVEMBER, 7, 17, 0, 0,
                TimeZone.getTimeZone("America/New_York"));
    }

    // https://github.com/quickfix-j/quickfixj/issues/486
    @Test
    public void testSessionTimeEndBeforeStartUsingWeekdaysDifferentTimeZones() throws Exception {
        SessionSettings settings = new SessionSettings();
        settings.setString(Session.SETTING_START_TIME, "23:55:00 Europe/Madrid");
        settings.setString(Session.SETTING_END_TIME, "17:05:00 America/New_York");
        settings.setString(Session.SETTING_WEEKDAYS, "Sun,Mon,Tue,Wed,Thu");

        mockSystemTimeSource.setTime(getTimeStamp(2008, Calendar.NOVEMBER, 2, 18, 0, 0, TimeZone.getTimeZone("America/New_York")));

        SessionID sessionID = new SessionID("FIX.4.2", "SENDER", "TARGET");
        SessionSchedule schedule = new DefaultSessionSchedule(settings, sessionID);
        // Schedule should be (assuming daylight savings time):
        // 23:55 Sunday Madrid to 17:05 Monday NY // 21:55 Sunday UTC to 21:05 Monday UTC
        // 23:55 Monday Madrid to 17:05 Tuesday NY // 21:55 Monday UTC to 21:05 Tuesday UTC
        // 23:55 Tuesday Madrid to 17:05 Wednesday NY // 21:55 Tuesday UTC to 21:05 Wednesday UTC
        // 23:55 Wednesday Madrid to 17:05 Thursday NY // 21:55 Wednesday UTC to 21:05 Thursday UTC
        // 23:55 Thursday Madrid to 17:05 Friday NY // 21:55 Thursday UTC to 21:05 Friday UTC

        // Saturday
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 16, 21, 0, 0); // 23:00 Madrid
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 16, 22, 0, 0); // 00:00 Madrid next day
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 16, 22, 1, 0); // 00:01 Madrid next day
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 16, 23, 0, 0); // 01:00 Madrid next day

        // Sunday
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 17, 0, 1, 0); // 19:01 Madrid
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 17, 21, 54, 59);// 23:54 Madrid
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 17, 21, 55, 00); // 23:55 Madrid. Correct opening time
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 17, 21, 57, 0); // 23:57 Madrid
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 17, 22, 00, 0); // 00:00 Madrid next day.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 17, 23, 57, 0); // 01:57 Madrid next day.

        // Monday
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 0, 1, 0); // 02:01 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 3, 0, 1); // 05:00 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 3, 59, 59); // 05:59 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 4, 00, 59); // 06:00 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 17, 00, 59); // 19:00 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 21, 00, 00); // 23:00 Madrid / 17:00 NY
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 21, 4, 59); // 23:04:59 Madrid / 17:04:59 NY
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 21, 5, 0); // 23:05:00 Madrid / 17:05 NY
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 18, 21, 5, 1); // 23:05:01 Madrid / 17:05:01 NY. Correct close time
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 18, 21, 54, 0); // 23:54:00 Madrid.
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 21, 55, 00); // 23:55 Madrid. Correct opening time
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 21, 57, 0); // 23:57 Madrid
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 22, 56, 0); //
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 23, 6, 0); //
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 23, 54, 0); //
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 18, 23, 56, 0); //
        // Tuesday
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 19, 0, 1, 0); //
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 19, 3, 0, 1); //
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 19, 17, 00, 59);
        doIsSessionTimeTest(schedule, true, 2022, Calendar.APRIL, 19, 21, 00, 00);
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 19, 21, 6, 0);
        doIsSessionTimeTest(schedule, false, 2022, Calendar.APRIL, 19, 21, 54, 0);
    }

}