Skip to content

Commit c82a29e

Browse files
emrberkclaude
andcommitted
Fix parser bugs for quoted table names, nd-arrays, extractMaybeString, and resumeWal toSql
- Use stringOrQualifiedName subrule in INSERT, CREATE TABLE, and RENAME TABLE for quoted table names - Group array subscripts by bracket pair for correct nd-array vs chained access - Fix extractMaybeString to handle identifier subrule and IdentifierKeyword token - Fix resumeWalToSql dual emission with else-if - Fix arrayAccessToSql to combine subscripts as [s1, s2] for nd-arrays - Add typecheck CI step, sort grammar lists alphabetically - Add tests and proof tests for all fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 62f0dba commit c82a29e

File tree

14 files changed

+899
-434
lines changed

14 files changed

+899
-434
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ jobs:
1919

2020
- run: yarn
2121

22+
- run: yarn typecheck
23+
2224
- run: yarn build
2325

2426
- run: yarn lint

src/grammar/constants.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
/**
2-
* SQL Constants - Literal constants and named values
3-
* Used for: constant.language highlighting in Monaco editor
4-
*
5-
* These get a distinct color from keywords in the editor.
6-
* Includes: boolean literals, time units, compression formats,
7-
* protocol names, and other named constants.
8-
*/
91
export const constants: string[] = [
102
"asc",
113
"brotli",

src/grammar/dataTypes.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
/**
2-
* SQL Data Types - Type names used in column definitions
3-
* Used for: dataType highlighting in Monaco editor
4-
*/
51
export const dataTypes: string[] = [
62
"binary",
73
"boolean",

0 commit comments

Comments
 (0)