SADeprecationWarning - Implement an import_dbapi()

[PRICEKRAKEN]

SADeprecationWarning: The dbapi() classmethod on dialect classes has been renamed to import_dbapi(). Implement an import_dbapi() classmethod directly on class <class 'questdb_connect.dialect.QuestDBDialect'> to remove this warning; the old .dbapi() classmethod may be maintained for backwards compatibility.

[PRICEKRAKEN]

https://docs.sqlalchemy.org/en/20/core/internals.html#sqlalchemy.engine.default.DefaultDialect.import_dbapi

[PRICEKRAKEN]

#10

[PRICEKRAKEN]

I see this project has requirement:

SQLAlchemy ('SQLAlchemy<=1.4.47')

After this merge it would be
SQLAlchemy ('SQLAlchemy >= 2.0')

I run the questdb-connect module already with SQLAlchemy 2.0.
Except the SADeprecationWarning i had no issues so far.

Can we work to bring this thing to SQLAlchemy 2.0 and onwards?
Or would it break to much?

[jerrinot]

@PRICEKRAKEN I am afraid raising hard-requirment to 2.0 is a no-go. Since there are still users of 1.4. I believe the latest stable version of Apache Superset still uses 1.4 too: https://github.com/apache/superset/blob/4.1.1/requirements/base.txt#L336