From 1e7c606e858da6db1b453dd36f330d6e834d274e Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Thu, 16 Apr 2026 09:46:07 +0530 Subject: [PATCH 1/9] ASoC: dt-bindings: qcom: Add Shikra rx and va macro codecs Add bindings for Qualcomm shikra rx and va macro codec. Signed-off-by: Mohammad Rafi Shaik --- Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 1 + Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml index 2eed2277511f8..07fe0dc51801b 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml @@ -19,6 +19,7 @@ properties: - qcom,sm8450-lpass-rx-macro - qcom,sm8550-lpass-rx-macro - qcom,sc8280xp-lpass-rx-macro + - qcom,shikra-lpass-rx-macro - items: - enum: - qcom,kaanapali-lpass-rx-macro diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml index 5c42b2b323ee4..d43adaa2fbff9 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml @@ -19,6 +19,7 @@ properties: - qcom,sm8450-lpass-va-macro - qcom,sm8550-lpass-va-macro - qcom,sc8280xp-lpass-va-macro + - qcom,shikra-lpass-va-macro - items: - enum: - qcom,glymur-lpass-va-macro From d67b30213bfcd380e8f113eef22867b8c81b10ae Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Tue, 26 May 2026 11:00:15 +0530 Subject: [PATCH 2/9] ASoC: qcom: lpass-macro: Add LPASS codec v4.0 support for Shikra Shikra (QCM2290) carries a Bolero v4.0 LPASS codec that extends the existing VA and RX macro hardware in several ways. Wire up the new platform while keeping all changes strictly gated so that no existing platform is affected. VA macro changes: - Add LPASS_CODEC_VERSION_4_0 to the version enum and version-string helper in lpass-macro-common.h. - Introduce a dedicated shikra_va_data match-data struct that pre-sets codec version to 4.0 and marks bypass_fs_control, avoiding the need to read the version from hardware registers before clocks are up. - Add new register definitions for v4.0-only hardware blocks: * SWR GP-IN/GP-OUT channel registers (0x00E0-0x00FC) * Extended ADC MUX4-7 CFG0/1 (0x0120-0x013C) for 8-DMIC support * ADC MUXx CFG2 extension for all 8 muxes (0x0140-0x015C) * SWR INTR_CTRL registers (0x0340-0x03D0) * TX PATH CFG2 per decimator (0x0430/0x04B0/0x0530/0x05B0) * Adaptive filter blocks ADPT0-3 (0x0800-0x09A4) * ALT TOP configuration registers (0x1000-0x1140) - Split register defaults: common defaults stay in va_defaults[]; all v4.0-only defaults move to a new va_4_0_defaults[] array. The probe function builds the regmap config dynamically (mirroring rx-macro), merging va_4_0_defaults only for v4.0 and setting max_register to VA_MAX_OFFSET (0x1240) vs VA_MAX_OFFSET_PRE_4_0 (0x07A8) accordingly. - Guard va_is_rw_register() and va_is_volatile_register() so the new INTR_CTRL, MUX4-7, CFG2, TX_PATH_CFG2, ADPT, and ALT_TOP cases are only reachable when the codec version is 4.0. - Add bypass_fs_control bool to va_macro_data and va_macro structs. Gate the FS counter bit[7] toggle in va_clk_rsc_fs_gen_request() behind va->bypass_fs_control instead of a version comparison. - Add fsgen_gate_ops_4_0 clk_ops with recalc_rate (parent/2) used only for v4.0; the base fsgen_gate_ops is unchanged for all other platforms. - Fix a pre-existing bug where the TX1 and TX3 reg_default entries for TX_PATH_CFG2 incorrectly referenced CDC_VA_TX0_TX_PATH_CFG2 (0x0430) instead of their own addresses (0x04B0 and 0x05B0 respectively). RX macro changes: - Add LPASS_CODEC_VERSION_4_0 fall-through to the v2.5 register-set, control, widget, and probe stride/defaults selection paths, since the RX macro register layout is compatible with the 2.5 variant. - Add bypass_fs_control bool to rx_macro struct; set it from the new LPASS_MACRO_FLAG_BYPASS_FS_CONTROL flag in rx_macro_probe(). - Gate the FS counter bit[7] toggle in rx_macro_mclk_enable() behind rx->bypass_fs_control instead of a version comparison. - Add qcom,shikra-lpass-rx-macro DT match entry with both LPASS_MACRO_FLAG_HAS_NPL_CLOCK and LPASS_MACRO_FLAG_BYPASS_FS_CONTROL. Common header changes: - Add LPASS_MACRO_FLAG_BYPASS_FS_CONTROL BIT(2) to lpass-macro-common.h to signal that the FS counter control bit[7] must be toggled during mclk enable. This is a platform capability flag, not a version check, so it can be set independently of codec version in future platforms. Signed-off-by: Mohammad Rafi Shaik --- sound/soc/codecs/lpass-macro-common.h | 5 + sound/soc/codecs/lpass-rx-macro.c | 14 + sound/soc/codecs/lpass-va-macro.c | 358 +++++++++++++++++++++++++- 3 files changed, 366 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h index 10ad682019fa7..0afcb2dce5d91 100644 --- a/sound/soc/codecs/lpass-macro-common.h +++ b/sound/soc/codecs/lpass-macro-common.h @@ -10,6 +10,8 @@ #define LPASS_MACRO_FLAG_HAS_NPL_CLOCK BIT(0) /* The soundwire block should be internally reset at probe */ #define LPASS_MACRO_FLAG_RESET_SWR BIT(1) +/* FS counter control bit[7] must be toggled (Shikra / v4.0) */ +#define LPASS_MACRO_FLAG_BYPASS_FS_CONTROL BIT(2) enum lpass_version { LPASS_VER_9_0_0, @@ -30,6 +32,7 @@ enum lpass_codec_version { LPASS_CODEC_VERSION_2_7, LPASS_CODEC_VERSION_2_8, LPASS_CODEC_VERSION_2_9, + LPASS_CODEC_VERSION_4_0, }; struct lpass_macro { @@ -68,6 +71,8 @@ static inline const char *lpass_macro_get_codec_version_string(int version) return "v2.7"; case LPASS_CODEC_VERSION_2_8: return "v2.8"; + case LPASS_CODEC_VERSION_4_0: + return "v4.0"; default: break; } diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index 6233aa9f5bc6d..3a3dec6b14cda 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -646,6 +646,7 @@ struct rx_macro { int clsh_users; int rx_mclk_cnt; enum lpass_codec_version codec_version; + bool bypass_fs_control; int rxn_reg_stride; int rxn_reg_stride2; bool is_ear_mode_on; @@ -1612,6 +1613,7 @@ static bool rx_is_rw_register(struct device *dev, unsigned int reg) case LPASS_CODEC_VERSION_2_6: case LPASS_CODEC_VERSION_2_7: case LPASS_CODEC_VERSION_2_8: + case LPASS_CODEC_VERSION_4_0: return rx_2_5_is_rw_register(dev, reg); default: break; @@ -2043,6 +2045,11 @@ static void rx_macro_mclk_enable(struct rx_macro *rx, bool mclk_enable) CDC_RX_CLK_MCLK2_ENABLE); regmap_update_bits(regmap, CDC_RX_CLK_RST_CTRL_FS_CNT_CONTROL, CDC_RX_FS_MCLK_CNT_CLR_MASK, 0x00); + + if (rx->bypass_fs_control) + regmap_update_bits(regmap, + CDC_RX_CLK_RST_CTRL_FS_CNT_CONTROL, + 0x80, 0x80); regmap_update_bits(regmap, CDC_RX_CLK_RST_CTRL_FS_CNT_CONTROL, CDC_RX_FS_MCLK_CNT_EN_MASK, CDC_RX_FS_MCLK_CNT_ENABLE); @@ -3648,6 +3655,7 @@ static int rx_macro_component_probe(struct snd_soc_component *component) case LPASS_CODEC_VERSION_2_6: case LPASS_CODEC_VERSION_2_7: case LPASS_CODEC_VERSION_2_8: + case LPASS_CODEC_VERSION_4_0: controls = rx_macro_2_5_snd_controls; num_controls = ARRAY_SIZE(rx_macro_2_5_snd_controls); widgets = rx_macro_2_5_dapm_widgets; @@ -3809,6 +3817,7 @@ static int rx_macro_probe(struct platform_device *pdev) return PTR_ERR(base); rx->codec_version = lpass_macro_get_codec_version(); + rx->bypass_fs_control = !!(flags & LPASS_MACRO_FLAG_BYPASS_FS_CONTROL); struct reg_default *reg_defaults __free(kfree) = NULL; switch (rx->codec_version) { @@ -3831,6 +3840,7 @@ static int rx_macro_probe(struct platform_device *pdev) case LPASS_CODEC_VERSION_2_6: case LPASS_CODEC_VERSION_2_7: case LPASS_CODEC_VERSION_2_8: + case LPASS_CODEC_VERSION_4_0: rx->rxn_reg_stride = 0xc0; rx->rxn_reg_stride2 = 0x0; def_count = ARRAY_SIZE(rx_defaults) + ARRAY_SIZE(rx_2_5_defaults); @@ -3961,6 +3971,10 @@ static const struct of_device_id rx_macro_dt_match[] = { }, { .compatible = "qcom,sc8280xp-lpass-rx-macro", .data = (void *)LPASS_MACRO_FLAG_HAS_NPL_CLOCK, + }, { + .compatible = "qcom,shikra-lpass-rx-macro", + .data = (void *)(LPASS_MACRO_FLAG_HAS_NPL_CLOCK | + LPASS_MACRO_FLAG_BYPASS_FS_CONTROL), }, { } }; diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 528d5b167ecff..0d4d94adf121c 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -81,6 +81,14 @@ #define CDC_VA_SWR_MIC_CLK_SEL_0_1_MASK (0xEE) #define CDC_VA_SWR_MIC_CLK_SEL_0_1_DIV1 (0xCC) #define CDC_VA_TOP_CSR_SWR_CTRL (0x00DC) + +#define CDC_VA_TOP_CSR_SWR_GPIN_CH0 (0x00E0) +#define CDC_VA_TOP_CSR_SWR_GPIN_CH1 (0x00E4) +#define CDC_VA_TOP_CSR_TOP_CFG2 (0x00EC) +#define CDC_VA_TOP_CSR_TOP_CFG3 (0x00F0) +#define CDC_VA_TOP_CSR_SWR_GPOUT_CH0 (0x00F8) +#define CDC_VA_TOP_CSR_SWR_GPOUT_CH1 (0x00FC) + #define CDC_VA_INP_MUX_ADC_MUX0_CFG0 (0x0100) #define CDC_VA_INP_MUX_ADC_MUX0_CFG1 (0x0104) #define CDC_VA_INP_MUX_ADC_MUX1_CFG0 (0x0108) @@ -89,6 +97,40 @@ #define CDC_VA_INP_MUX_ADC_MUX2_CFG1 (0x0114) #define CDC_VA_INP_MUX_ADC_MUX3_CFG0 (0x0118) #define CDC_VA_INP_MUX_ADC_MUX3_CFG1 (0x011C) + +/* ADC MUX4-7 CFG0/1 - Bolero V4 extended decimator mux (up to 8 DMICs) */ +#define CDC_VA_INP_MUX_ADC_MUX4_CFG0 (0x0120) +#define CDC_VA_INP_MUX_ADC_MUX4_CFG1 (0x0124) +#define CDC_VA_INP_MUX_ADC_MUX5_CFG0 (0x0128) +#define CDC_VA_INP_MUX_ADC_MUX5_CFG1 (0x012C) +#define CDC_VA_INP_MUX_ADC_MUX6_CFG0 (0x0130) +#define CDC_VA_INP_MUX_ADC_MUX6_CFG1 (0x0134) +#define CDC_VA_INP_MUX_ADC_MUX7_CFG0 (0x0138) +#define CDC_VA_INP_MUX_ADC_MUX7_CFG1 (0x013C) + +/* ADC MUXx CFG2 - Bolero V4 CFG2 extension for all 8 MUXes */ +#define CDC_VA_INP_MUX_ADC_MUX0_CFG2 (0x0140) +#define CDC_VA_INP_MUX_ADC_MUX1_CFG2 (0x0144) +#define CDC_VA_INP_MUX_ADC_MUX2_CFG2 (0x0148) +#define CDC_VA_INP_MUX_ADC_MUX3_CFG2 (0x014C) +#define CDC_VA_INP_MUX_ADC_MUX4_CFG2 (0x0150) +#define CDC_VA_INP_MUX_ADC_MUX5_CFG2 (0x0154) +#define CDC_VA_INP_MUX_ADC_MUX6_CFG2 (0x0158) +#define CDC_VA_INP_MUX_ADC_MUX7_CFG2 (0x015C) + +/* INTR_CTRL registers - SWR interrupt controller (VA macro owns SWR0 on QCM2290) */ +#define CDC_VA_MACRO_INTR_CTRL_CFG (0x0340) +#define CDC_VA_MACRO_INTR_CTRL_CLR_COMMIT (0x0344) +#define CDC_VA_MACRO_INTR_CTRL_PIN1_MASK0 (0x0360) +#define CDC_VA_MACRO_INTR_CTRL_PIN1_STATUS0 (0x0368) +#define CDC_VA_MACRO_INTR_CTRL_PIN1_CLEAR0 (0x0370) +#define CDC_VA_MACRO_INTR_CTRL_PIN2_MASK0 (0x0380) +#define CDC_VA_MACRO_INTR_CTRL_PIN2_STATUS0 (0x0388) +#define CDC_VA_MACRO_INTR_CTRL_PIN2_CLEAR0 (0x0390) +#define CDC_VA_MACRO_INTR_CTRL_LEVEL0 (0x03C0) +#define CDC_VA_MACRO_INTR_CTRL_BYPASS0 (0x03C8) +#define CDC_VA_MACRO_INTR_CTRL_SET0 (0x03D0) + #define CDC_VA_TX0_TX_PATH_CTL (0x0400) #define CDC_VA_TX_PATH_CLK_EN_MASK BIT(5) #define CDC_VA_TX_PATH_CLK_EN BIT(5) @@ -118,6 +160,9 @@ #define CDC_VA_TX0_TX_PATH_SEC5 (0x0424) #define CDC_VA_TX0_TX_PATH_SEC6 (0x0428) #define CDC_VA_TX0_TX_PATH_SEC7 (0x042C) + +#define CDC_VA_TX0_TX_PATH_CFG2 (0x0430) + #define CDC_VA_TX1_TX_PATH_CTL (0x0480) #define CDC_VA_TX1_TX_PATH_CFG0 (0x0484) #define CDC_VA_TX1_TX_PATH_CFG1 (0x0488) @@ -129,6 +174,9 @@ #define CDC_VA_TX1_TX_PATH_SEC4 (0x04A0) #define CDC_VA_TX1_TX_PATH_SEC5 (0x04A4) #define CDC_VA_TX1_TX_PATH_SEC6 (0x04A8) + +#define CDC_VA_TX1_TX_PATH_CFG2 (0x04B0) + #define CDC_VA_TX2_TX_PATH_CTL (0x0500) #define CDC_VA_TX2_TX_PATH_CFG0 (0x0504) #define CDC_VA_TX2_TX_PATH_CFG1 (0x0508) @@ -140,6 +188,9 @@ #define CDC_VA_TX2_TX_PATH_SEC4 (0x0520) #define CDC_VA_TX2_TX_PATH_SEC5 (0x0524) #define CDC_VA_TX2_TX_PATH_SEC6 (0x0528) + +#define CDC_VA_TX2_TX_PATH_CFG2 (0x0530) + #define CDC_VA_TX3_TX_PATH_CTL (0x0580) #define CDC_VA_TX3_TX_PATH_CFG0 (0x0584) #define CDC_VA_TX_PATH_ADC_DMIC_SEL_MASK BIT(7) @@ -155,7 +206,66 @@ #define CDC_VA_TX3_TX_PATH_SEC5 (0x05A4) #define CDC_VA_TX3_TX_PATH_SEC6 (0x05A8) -#define VA_MAX_OFFSET (0x07A8) +#define CDC_VA_TX3_TX_PATH_CFG2 (0x05B0) + +#define CDC_VA_CDC_ADPT0_ADPT_CTRL (0x0800) +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_0 (0x0804) +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_1 (0x0808) +#define CDC_VA_CDC_ADPT0_DH_FSM_CTRL (0x080C) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_0 (0x0810) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_1 (0x0814) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_2 (0x0818) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_3 (0x081C) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_4 (0x0820) +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_5 (0x0824) + +#define CDC_VA_CDC_ADPT1_ADPT_CTRL (0x0880) +#define CDC_VA_CDC_ADPT1_ADPT_GAIN_0 (0x0884) +#define CDC_VA_CDC_ADPT1_ADPT_GAIN_1 (0x0888) +#define CDC_VA_CDC_ADPT1_DH_FSM_CTRL (0x088C) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_0 (0x0890) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_1 (0x0894) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_2 (0x0898) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_3 (0x089C) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_4 (0x08A0) +#define CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_5 (0x08A4) +#define CDC_VA_CDC_ADPT1_DBG_CTRL (0x08B0) +#define CDC_VA_CDC_ADPT1_DBG_PDM_RATE_CTRL_0 (0x08B2) +#define CDC_VA_CDC_ADPT1_DBG_PDM_RATE_CTRL_1 (0x08B4) +#define CDC_VA_CDC_ADPT1_SPARE0 (0x08B8) + +#define CDC_VA_CDC_ADPT2_ADPT_CTRL (0x0900) +#define CDC_VA_CDC_ADPT2_ADPT_GAIN_0 (0x0904) +#define CDC_VA_CDC_ADPT2_ADPT_GAIN_1 (0x0908) +#define CDC_VA_CDC_ADPT2_DH_FSM_CTRL (0x090C) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_0 (0x0910) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_1 (0x0914) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_2 (0x0918) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_3 (0x091C) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_4 (0x0920) +#define CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_5 (0x0924) + +#define CDC_VA_CDC_ADPT3_ADPT_CTRL (0x0980) +#define CDC_VA_CDC_ADPT3_ADPT_GAIN_0 (0x0984) +#define CDC_VA_CDC_ADPT3_ADPT_GAIN_1 (0x0988) +#define CDC_VA_CDC_ADPT3_DH_FSM_CTRL (0x098C) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_0 (0x0990) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_1 (0x0994) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_2 (0x0998) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_3 (0x099C) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_4 (0x09A0) +#define CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_5 (0x09A4) + +/* VA ALT TOP registers - Bolero V4 alternate top config */ +#define CDC_VA_ALT_TOP_VA_CFG0 0x1000 +#define CDC_VA_ALT_TOP_RX_CFG0 0x1040 +#define CDC_VA_ALT_TOP_WSA1_CFG0 0x1080 +#define CDC_VA_ALT_TOP_WSA2_CFG0 0x10C0 +#define CDC_VA_ALT_TOP_WSA3_CFG0 0x1100 +#define CDC_VA_ALT_TOP_WSA4_CFG0 0x1140 + +#define VA_MAX_OFFSET (0x1240) +#define VA_MAX_OFFSET_PRE_4_0 (0x07A8) #define VA_MACRO_NUM_DECIMATORS 4 #define VA_MACRO_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\ @@ -209,6 +319,8 @@ struct va_macro { u16 dmic_clk_div; bool has_swr_master; bool has_npl_clk; + bool bypass_fs_control; + enum lpass_codec_version codec_version; int dec_mode[VA_MACRO_NUM_DECIMATORS]; struct regmap *regmap; @@ -235,6 +347,7 @@ struct va_macro { struct va_macro_data { bool has_swr_master; bool has_npl_clk; + bool bypass_fs_control; int version; }; @@ -249,6 +362,13 @@ static const struct va_macro_data sm8450_va_data = { .has_npl_clk = true, }; +static const struct va_macro_data shikra_va_data = { + .has_swr_master = true, + .has_npl_clk = true, + .bypass_fs_control = true, + .version = LPASS_CODEC_VERSION_4_0, +}; + static const struct va_macro_data sm8550_va_data = { .has_swr_master = true, .has_npl_clk = false, @@ -266,7 +386,23 @@ static bool va_is_volatile_register(struct device *dev, unsigned int reg) case CDC_VA_TOP_CSR_DMIC2_CTL: case CDC_VA_TOP_CSR_DMIC3_CTL: return true; + default: + break; } + + if (lpass_macro_get_codec_version() == LPASS_CODEC_VERSION_4_0) { + switch (reg) { + case CDC_VA_MACRO_INTR_CTRL_PIN1_STATUS0: + case CDC_VA_MACRO_INTR_CTRL_PIN1_CLEAR0: + case CDC_VA_MACRO_INTR_CTRL_PIN2_STATUS0: + case CDC_VA_MACRO_INTR_CTRL_PIN2_CLEAR0: + case CDC_VA_MACRO_INTR_CTRL_CLR_COMMIT: + return true; + default: + break; + } + } + return false; } @@ -304,6 +440,7 @@ static const struct reg_default va_defaults[] = { { CDC_VA_INP_MUX_ADC_MUX2_CFG1, 0x00}, { CDC_VA_INP_MUX_ADC_MUX3_CFG0, 0x00}, { CDC_VA_INP_MUX_ADC_MUX3_CFG1, 0x00}, + { CDC_VA_TX0_TX_PATH_CTL, 0x04}, { CDC_VA_TX0_TX_PATH_CFG0, 0x10}, { CDC_VA_TX0_TX_PATH_CFG1, 0x0B}, @@ -351,6 +488,101 @@ static const struct reg_default va_defaults[] = { { CDC_VA_TX3_TX_PATH_SEC6, 0x00}, }; +/* Register defaults specific to LPASS codec v4.0 (Shikra) */ +static const struct reg_default va_4_0_defaults[] = { + /* ADC MUX4-7 CFG0/1 - 8-DMIC support */ + { CDC_VA_INP_MUX_ADC_MUX4_CFG0, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX4_CFG1, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX5_CFG0, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX5_CFG1, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX6_CFG0, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX6_CFG1, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX7_CFG0, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX7_CFG1, 0x00 }, + + /* ADC MUXx CFG2 extension */ + { CDC_VA_INP_MUX_ADC_MUX0_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX1_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX2_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX3_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX4_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX5_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX6_CFG2, 0x00 }, + { CDC_VA_INP_MUX_ADC_MUX7_CFG2, 0x00 }, + + /* INTR_CTRL: SWR interrupt masking registers */ + { CDC_VA_MACRO_INTR_CTRL_CFG, 0x00 }, + { CDC_VA_MACRO_INTR_CTRL_PIN1_MASK0, 0xFF }, + { CDC_VA_MACRO_INTR_CTRL_PIN1_STATUS0, 0x00 }, + { CDC_VA_MACRO_INTR_CTRL_PIN2_MASK0, 0xFF }, + { CDC_VA_MACRO_INTR_CTRL_PIN2_STATUS0, 0x00 }, + { CDC_VA_MACRO_INTR_CTRL_LEVEL0, 0x00 }, + { CDC_VA_MACRO_INTR_CTRL_BYPASS0, 0x00 }, + { CDC_VA_MACRO_INTR_CTRL_SET0, 0x00 }, + + /* TX PATH CFG2 per decimator */ + { CDC_VA_TX0_TX_PATH_CFG2, 0x03 }, + { CDC_VA_TX1_TX_PATH_CFG2, 0x03 }, + { CDC_VA_TX2_TX_PATH_CFG2, 0x03 }, + { CDC_VA_TX3_TX_PATH_CFG2, 0x03 }, + + /* CDC ADPT0 - adaptive filter */ + { CDC_VA_CDC_ADPT0_ADPT_CTRL, 0x51 }, + { CDC_VA_CDC_ADPT0_ADPT_GAIN_0, 0x11 }, + { CDC_VA_CDC_ADPT0_ADPT_GAIN_1, 0x01 }, + { CDC_VA_CDC_ADPT0_DH_FSM_CTRL, 0x02 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_0, 0x77 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_1, 0x64 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_2, 0x00 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_3, 0x41 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_4, 0x04 }, + { CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_5, 0x01 }, + + /* CDC ADPT1 */ + { CDC_VA_CDC_ADPT1_ADPT_CTRL, 0x51 }, + { CDC_VA_CDC_ADPT1_ADPT_GAIN_0, 0x11 }, + { CDC_VA_CDC_ADPT1_ADPT_GAIN_1, 0x01 }, + { CDC_VA_CDC_ADPT1_DH_FSM_CTRL, 0x02 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_0, 0x77 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_1, 0x64 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_2, 0x00 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_3, 0x41 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_4, 0x04 }, + { CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_5, 0x01 }, + + /* CDC ADPT2 */ + { CDC_VA_CDC_ADPT2_ADPT_CTRL, 0x51 }, + { CDC_VA_CDC_ADPT2_ADPT_GAIN_0, 0x11 }, + { CDC_VA_CDC_ADPT2_ADPT_GAIN_1, 0x01 }, + { CDC_VA_CDC_ADPT2_DH_FSM_CTRL, 0x02 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_0, 0x77 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_1, 0x64 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_2, 0x00 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_3, 0x41 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_4, 0x04 }, + { CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_5, 0x01 }, + + /* CDC ADPT3 */ + { CDC_VA_CDC_ADPT3_ADPT_CTRL, 0x51 }, + { CDC_VA_CDC_ADPT3_ADPT_GAIN_0, 0x11 }, + { CDC_VA_CDC_ADPT3_ADPT_GAIN_1, 0x01 }, + { CDC_VA_CDC_ADPT3_DH_FSM_CTRL, 0x02 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_0, 0x77 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_1, 0x64 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_2, 0x00 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_3, 0x41 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_4, 0x04 }, + { CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_5, 0x01 }, + + /* VA ALT TOP */ + { CDC_VA_ALT_TOP_VA_CFG0, 0x00 }, + { CDC_VA_ALT_TOP_RX_CFG0, 0x00 }, + { CDC_VA_ALT_TOP_WSA1_CFG0, 0x00 }, + { CDC_VA_ALT_TOP_WSA2_CFG0, 0x00 }, + { CDC_VA_ALT_TOP_WSA3_CFG0, 0x00 }, + { CDC_VA_ALT_TOP_WSA4_CFG0, 0x00 }, +}; + static bool va_is_rw_register(struct device *dev, unsigned int reg) { switch (reg) { @@ -425,6 +657,41 @@ static bool va_is_rw_register(struct device *dev, unsigned int reg) case CDC_VA_TX3_TX_PATH_SEC5: case CDC_VA_TX3_TX_PATH_SEC6: return true; + default: + break; + } + + if (lpass_macro_get_codec_version() == LPASS_CODEC_VERSION_4_0) { + switch (reg) { + case CDC_VA_MACRO_INTR_CTRL_CFG: + case CDC_VA_MACRO_INTR_CTRL_CLR_COMMIT: + case CDC_VA_MACRO_INTR_CTRL_PIN1_MASK0: + case CDC_VA_MACRO_INTR_CTRL_PIN1_CLEAR0: + case CDC_VA_MACRO_INTR_CTRL_PIN2_MASK0: + case CDC_VA_MACRO_INTR_CTRL_PIN2_CLEAR0: + case CDC_VA_MACRO_INTR_CTRL_LEVEL0: + case CDC_VA_MACRO_INTR_CTRL_BYPASS0: + case CDC_VA_MACRO_INTR_CTRL_SET0: + case CDC_VA_INP_MUX_ADC_MUX4_CFG0 ... CDC_VA_INP_MUX_ADC_MUX7_CFG1: + case CDC_VA_INP_MUX_ADC_MUX0_CFG2 ... CDC_VA_INP_MUX_ADC_MUX7_CFG2: + case CDC_VA_TX0_TX_PATH_CFG2: + case CDC_VA_TX1_TX_PATH_CFG2: + case CDC_VA_TX2_TX_PATH_CFG2: + case CDC_VA_TX3_TX_PATH_CFG2: + case CDC_VA_ALT_TOP_VA_CFG0: + case CDC_VA_ALT_TOP_RX_CFG0: + case CDC_VA_ALT_TOP_WSA1_CFG0: + case CDC_VA_ALT_TOP_WSA2_CFG0: + case CDC_VA_ALT_TOP_WSA3_CFG0: + case CDC_VA_ALT_TOP_WSA4_CFG0: + case CDC_VA_CDC_ADPT0_ADPT_CTRL ... CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_5: + case CDC_VA_CDC_ADPT1_ADPT_CTRL ... CDC_VA_CDC_ADPT1_CUTOFF_FSM_CTRL_5: + case CDC_VA_CDC_ADPT2_ADPT_CTRL ... CDC_VA_CDC_ADPT2_CUTOFF_FSM_CTRL_5: + case CDC_VA_CDC_ADPT3_ADPT_CTRL ... CDC_VA_CDC_ADPT3_CUTOFF_FSM_CTRL_5: + return true; + default: + break; + } } return false; @@ -449,9 +716,6 @@ static const struct regmap_config va_regmap_config = { .val_bits = 32, .reg_stride = 4, .cache_type = REGCACHE_FLAT, - .reg_defaults = va_defaults, - .num_reg_defaults = ARRAY_SIZE(va_defaults), - .max_register = VA_MAX_OFFSET, .volatile_reg = va_is_volatile_register, .readable_reg = va_is_readable_register, .writeable_reg = va_is_rw_register, @@ -469,6 +733,10 @@ static int va_clk_rsc_fs_gen_request(struct va_macro *va, bool enable) regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, CDC_VA_FS_CONTROL_EN | CDC_VA_FS_COUNTER_CLR, CDC_VA_FS_CONTROL_EN | CDC_VA_FS_COUNTER_CLR); + + if (va->bypass_fs_control) + regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, + 0x80, 0x80); regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, CDC_VA_FS_CONTROL_EN | CDC_VA_FS_COUNTER_CLR, CDC_VA_FS_CONTROL_EN); @@ -1386,12 +1654,25 @@ static int fsgen_gate_is_enabled(struct clk_hw *hw) return !!(val & CDC_VA_FS_BROADCAST_EN); } +static unsigned long fsgen_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + return parent_rate / 2; +} + static const struct clk_ops fsgen_gate_ops = { .prepare = fsgen_gate_enable, .unprepare = fsgen_gate_disable, .is_enabled = fsgen_gate_is_enabled, }; +static const struct clk_ops fsgen_gate_ops_4_0 = { + .prepare = fsgen_gate_enable, + .unprepare = fsgen_gate_disable, + .is_enabled = fsgen_gate_is_enabled, + .recalc_rate = fsgen_recalc_rate, +}; + static int va_macro_register_fsgen_output(struct va_macro *va) { struct clk *parent = va->mclk; @@ -1410,7 +1691,8 @@ static int va_macro_register_fsgen_output(struct va_macro *va) of_property_read_string(np, "clock-output-names", &clk_name); init.name = clk_name; - init.ops = &fsgen_gate_ops; + init.ops = (va->codec_version == LPASS_CODEC_VERSION_4_0) + ? &fsgen_gate_ops_4_0 : &fsgen_gate_ops; init.flags = 0; init.parent_names = &parent_clk_name; init.num_parents = 1; @@ -1511,6 +1793,14 @@ static int va_macro_set_lpass_codec_version(struct va_macro *va) default: break; } + } else if (maj == 4) { + switch (min) { + case 0: + version = LPASS_CODEC_VERSION_4_0; + break; + default: + break; + } } if (version == LPASS_CODEC_VERSION_UNKNOWN) { @@ -1520,6 +1810,7 @@ static int va_macro_set_lpass_codec_version(struct va_macro *va) } lpass_macro_set_codec_version(version); + va->codec_version = version; dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version)); @@ -1576,18 +1867,61 @@ static int va_macro_probe(struct platform_device *pdev) goto err; } - va->regmap = devm_regmap_init_mmio(dev, base, &va_regmap_config); + data = of_device_get_match_data(dev); + va->has_swr_master = data->has_swr_master; + va->has_npl_clk = data->has_npl_clk; + va->bypass_fs_control = data->bypass_fs_control; + + /* + * Use the version from match data if available; for platforms that + * detect version from registers, clocks must be enabled first, so + * the full detection is deferred to after clk_prepare_enable below. + */ + va->codec_version = data->version ? data->version : LPASS_CODEC_VERSION_UNKNOWN; + + int def_count; + struct reg_default *reg_defaults_buf __free(kfree) = NULL; + + if (va->codec_version == LPASS_CODEC_VERSION_4_0) { + def_count = ARRAY_SIZE(va_defaults) + ARRAY_SIZE(va_4_0_defaults); + reg_defaults_buf = kmalloc_objs(struct reg_default, def_count); + if (!reg_defaults_buf) { + ret = -ENOMEM; + goto err; + } + memcpy(®_defaults_buf[0], va_defaults, sizeof(va_defaults)); + memcpy(®_defaults_buf[ARRAY_SIZE(va_defaults)], + va_4_0_defaults, sizeof(va_4_0_defaults)); + } else { + def_count = ARRAY_SIZE(va_defaults); + reg_defaults_buf = kmalloc_objs(struct reg_default, def_count); + if (!reg_defaults_buf) { + ret = -ENOMEM; + goto err; + } + memcpy(reg_defaults_buf, va_defaults, sizeof(va_defaults)); + } + + struct regmap_config *reg_config __free(kfree) = + kmemdup(&va_regmap_config, sizeof(va_regmap_config), GFP_KERNEL); + if (!reg_config) { + ret = -ENOMEM; + goto err; + } + + reg_config->reg_defaults = reg_defaults_buf; + reg_config->num_reg_defaults = def_count; + reg_config->max_register = (va->codec_version == LPASS_CODEC_VERSION_4_0) + ? VA_MAX_OFFSET : VA_MAX_OFFSET_PRE_4_0; + + va->regmap = devm_regmap_init_mmio(dev, base, reg_config); if (IS_ERR(va->regmap)) { - ret = -EINVAL; + ret = PTR_ERR(va->regmap); goto err; } dev_set_drvdata(dev, va); - data = of_device_get_match_data(dev); - va->has_swr_master = data->has_swr_master; - va->has_npl_clk = data->has_npl_clk; - /* mclk rate */ clk_set_rate(va->mclk, 2 * VA_MACRO_MCLK_FREQ); @@ -1625,6 +1959,7 @@ static int va_macro_probe(struct platform_device *pdev) */ if (data->version) { lpass_macro_set_codec_version(data->version); + va->codec_version = data->version; } else { /* read version from register */ ret = va_macro_set_lpass_codec_version(va); @@ -1761,6 +2096,7 @@ static const struct of_device_id va_macro_dt_match[] = { { .compatible = "qcom,sm8450-lpass-va-macro", .data = &sm8450_va_data }, { .compatible = "qcom,sm8550-lpass-va-macro", .data = &sm8550_va_data }, { .compatible = "qcom,sc8280xp-lpass-va-macro", .data = &sm8450_va_data }, + { .compatible = "qcom,shikra-lpass-va-macro", .data = &shikra_va_data }, {} }; MODULE_DEVICE_TABLE(of, va_macro_dt_match); From 3688afe0fdedac04dd169a86afd349a5cb515cea Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Tue, 26 May 2026 11:20:37 +0530 Subject: [PATCH 3/9] dt-bindings: soundwire: qcom: add qcom,swr-master-ee-val property Add documentation for the qcom,swr-master-ee-val Device Tree property used by Qualcomm SoundWire masters to describe the execution-environment value for interrupt routing. This property allows platform DTs to specify the EE value used to direct SoundWire master interrupts to the appropriate CPU target. Signed-off-by: Mohammad Rafi Shaik --- .../devicetree/bindings/soundwire/qcom,soundwire.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml index 9447a2f371b56..5b06cc1a5f781 100644 --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml @@ -215,6 +215,12 @@ properties: maximum: 4 - const: 0xff + qcom,swr-master-ee-val: + $ref: /schemas/types.yaml#/definitions/uint8-array + description: + Execution-environment value used to route SoundWire master + interrupts to CPU0 or CPU1. + label: maxItems: 1 From 1d04871d113e15b38b3b35f1f0991cf09039b68f Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Tue, 26 May 2026 11:30:31 +0530 Subject: [PATCH 4/9] soundwire: qcom: add EE-aware register layout and cpu selection Some Qualcomm SoundWire masters expose interrupt, FIFO and status registers in EE-specific register windows on v2.0 and newer hardware. Add support for selecting the SoundWire execution environment from DT and use it to program the correct register window for the active EE. The driver now reads the EE value from the new qcom,swr-master-ee-val property, with qcom,ee as a fallback for backward compatibility. For v2.0+ hardware, the IRQ/FIFO/status register layout is adjusted by the EE window stride so the driver programs the correct bank for the selected EE. The interrupt enable path is also updated to always use the selected EE window. This change allows SoundWire interrupt routing and register accesses to work correctly on platforms where the master is not mapped to the default EE1 window. Signed-off-by: Mohammad Rafi Shaik --- drivers/soundwire/qcom.c | 103 +++++++++++++++++++++++++++++---------- 1 file changed, 77 insertions(+), 26 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 3d8f5a81eff19..5ad8aaaa3de44 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -26,6 +26,7 @@ #define SWRM_COMP_STATUS 0x014 #define SWRM_LINK_MANAGER_EE 0x018 #define SWRM_EE_CPU 1 +#define SWRM_MAX_EE 1 #define SWRM_FRM_GEN_ENABLED BIT(0) #define SWRM_VERSION_1_3_0 0x01030000 #define SWRM_VERSION_1_5_1 0x01050001 @@ -118,6 +119,7 @@ #define SWRM_V2_0_CLK_CTRL 0x5060 #define SWRM_V2_0_CLK_CTRL_CLK_START BIT(0) #define SWRM_V2_0_LINK_STATUS 0x5064 +#define SWRM_V2_REG_EE_STRIDE 0x1000 #define SWRM_DP_PORT_CTRL_EN_CHAN_SHFT 0x18 #define SWRM_DP_PORT_CTRL_OFFSET2_SHFT 0x10 @@ -202,6 +204,7 @@ struct qcom_swrm_ctrl { struct mutex port_lock; struct clk *hclk; int irq; + u32 ee; unsigned int version; int wake_irq; int num_din_ports; @@ -222,6 +225,7 @@ struct qcom_swrm_ctrl { u32 slave_status; u32 wr_fifo_depth; bool clock_stop_not_supported; + unsigned int reg_layout_local[SWRM_OFFSET_DP_SAMPLECTRL2_BANK + 1]; }; struct qcom_swrm_data { @@ -328,6 +332,36 @@ static const struct qcom_swrm_data swrm_v3_0_data = { }; #define to_qcom_sdw(b) container_of(b, struct qcom_swrm_ctrl, bus) +static void qcom_swrm_set_ee_register_layout(struct qcom_swrm_ctrl *ctrl, + const struct qcom_swrm_data *data) +{ + int ee_offset; + + memcpy(ctrl->reg_layout_local, data->reg_layout, + sizeof(ctrl->reg_layout_local)); + ctrl->reg_layout = ctrl->reg_layout_local; + + if (ctrl->version < SWRM_VERSION_2_0_0) + return; + + /* + * Current register constants map EE1. For EE0, use the EE register + * window stride to access status/IRQ/FIFO registers. + */ + ee_offset = ((int)ctrl->ee - SWRM_EE_CPU) * SWRM_V2_REG_EE_STRIDE; + if (!ee_offset) + return; + + ctrl->reg_layout_local[SWRM_REG_FRAME_GEN_ENABLED] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_INTERRUPT_STATUS] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_INTERRUPT_CLEAR] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_INTERRUPT_CPU_EN] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_CMD_FIFO_WR_CMD] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_CMD_FIFO_RD_CMD] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_CMD_FIFO_STATUS] += ee_offset; + ctrl->reg_layout_local[SWRM_REG_CMD_FIFO_RD_FIFO_ADDR] += ee_offset; +} + static int qcom_swrm_ahb_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, u32 *val) { @@ -904,12 +938,13 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl) ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val); if (ctrl->version == SWRM_VERSION_1_7_0) { - ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU); + ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, ctrl->ee); ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, - SWRM_MCP_BUS_CLK_START << SWRM_EE_CPU); + SWRM_MCP_BUS_CLK_START << ctrl->ee); } else if (ctrl->version >= SWRM_VERSION_2_0_0) { - ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU); - ctrl->reg_write(ctrl, SWRM_V2_0_CLK_CTRL, + ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, ctrl->ee); + ctrl->reg_write(ctrl, SWRM_V2_0_CLK_CTRL + + ((int)ctrl->ee - SWRM_EE_CPU) * SWRM_V2_REG_EE_STRIDE, SWRM_V2_0_CLK_CTRL_CLK_START); } else { ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START); @@ -935,11 +970,9 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl) ctrl->reg_write(ctrl, ctrl->reg_layout[SWRM_REG_INTERRUPT_CLEAR], 0xFFFFFFFF); - /* enable CPU IRQs */ - if (ctrl->mmio) { - ctrl->reg_write(ctrl, ctrl->reg_layout[SWRM_REG_INTERRUPT_CPU_EN], - SWRM_INTERRUPT_STATUS_RMSK); - } + /* enable CPU IRQs for the selected EE window */ + ctrl->reg_write(ctrl, ctrl->reg_layout[SWRM_REG_INTERRUPT_CPU_EN], + SWRM_INTERRUPT_STATUS_RMSK); /* Set IRQ to PULSE */ ctrl->reg_write(ctrl, SWRM_COMP_CFG_ADDR, @@ -1545,7 +1578,22 @@ static int qcom_swrm_probe(struct platform_device *pdev) return -ENOMEM; data = of_device_get_match_data(dev); + ctrl->ee = SWRM_EE_CPU; + ret = of_property_read_u32(dev->of_node, "qcom,swr-master-ee-val", &ctrl->ee); + if (ret) + ret = of_property_read_u32(dev->of_node, "qcom,ee", &ctrl->ee); + if (ret) + ctrl->ee = SWRM_EE_CPU; + if (ctrl->ee > SWRM_MAX_EE) { + dev_warn(dev, "invalid SoundWire EE %u, using EE%u\n", + ctrl->ee, SWRM_EE_CPU); + ctrl->ee = SWRM_EE_CPU; + } ctrl->max_reg = data->max_reg; + /* + * Defer EE register window selection until HW version is known. + * For v2.0+ the IRQ/FIFO window is EE-banked. + */ ctrl->reg_layout = data->reg_layout; ctrl->rows_index = sdw_find_row_index(data->default_rows); ctrl->cols_index = sdw_find_col_index(data->default_cols); @@ -1623,6 +1671,7 @@ static int qcom_swrm_probe(struct platform_device *pdev) prop->default_row = data->default_rows; ctrl->reg_read(ctrl, SWRM_COMP_HW_VERSION, &ctrl->version); + qcom_swrm_set_ee_register_layout(ctrl, data); ret = devm_request_threaded_irq(dev, ctrl->irq, NULL, qcom_swrm_irq_handler, @@ -1724,24 +1773,26 @@ static int __maybe_unused swrm_runtime_resume(struct device *dev) if (!swrm_wait_for_frame_gen_enabled(ctrl)) dev_err(ctrl->dev, "link failed to connect\n"); - /* wait for hw enumeration to complete */ - wait_for_completion_timeout(&ctrl->enumeration, - msecs_to_jiffies(TIMEOUT_MS)); - qcom_swrm_get_device_status(ctrl); - sdw_handle_slave_status(&ctrl->bus, ctrl->status); - } else { - reset_control_reset(ctrl->audio_cgcr); - - if (ctrl->version == SWRM_VERSION_1_7_0) { - ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU); - ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, - SWRM_MCP_BUS_CLK_START << SWRM_EE_CPU); - } else if (ctrl->version >= SWRM_VERSION_2_0_0) { - ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU); - ctrl->reg_write(ctrl, SWRM_V2_0_CLK_CTRL, - SWRM_V2_0_CLK_CTRL_CLK_START); + /* wait for hw enumeration to complete */ + wait_for_completion_timeout(&ctrl->enumeration, + msecs_to_jiffies(TIMEOUT_MS)); + qcom_swrm_get_device_status(ctrl); + sdw_handle_slave_status(&ctrl->bus, ctrl->status); } else { - ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START); + reset_control_reset(ctrl->audio_cgcr); + + if (ctrl->version == SWRM_VERSION_1_7_0) { + ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, ctrl->ee); + ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, + SWRM_MCP_BUS_CLK_START << ctrl->ee); + } else if (ctrl->version >= SWRM_VERSION_2_0_0) { + ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, ctrl->ee); + ctrl->reg_write(ctrl, SWRM_V2_0_CLK_CTRL + + ((int)ctrl->ee - SWRM_EE_CPU) * + SWRM_V2_REG_EE_STRIDE, + SWRM_V2_0_CLK_CTRL_CLK_START); + } else { + ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START); } ctrl->reg_write(ctrl, ctrl->reg_layout[SWRM_REG_INTERRUPT_CLEAR], SWRM_INTERRUPT_STATUS_MASTER_CLASH_DET); From 2d81cb23bd33fa2ffa9abdf5ea0e89626c51ed38 Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Mon, 11 May 2026 12:22:04 +0530 Subject: [PATCH 5/9] ASoC: dt-bindings: qcom,sm8250: Add shikra sound card Add bindings for shikra sound card, which looks fully compatible with existing shikra. Signed-off-by: Mohammad Rafi Shaik --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 15f38622b98b9..7f52902fcf9d4 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -47,6 +47,7 @@ properties: - qcom,sdm845-sndcard - qcom,sm8250-sndcard - qcom,sm8450-sndcard + - qcom,shikra-sndcard - qcom,x1e80100-sndcard audio-routing: From f49b499638bdab2ba7c9c001d740c5bcb6fd13a5 Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Mon, 11 May 2026 12:23:13 +0530 Subject: [PATCH 6/9] ASoC: qcom: sc8280xp: Add support for shikra Add compatible for sound card on Qualcomm shikra boards. Signed-off-by: Mohammad Rafi Shaik --- sound/soc/qcom/sc8280xp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index 7925aa3f63ba0..c6544820efbb2 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -176,6 +176,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = { {.compatible = "qcom,sm8550-sndcard", "sm8550"}, {.compatible = "qcom,sm8650-sndcard", "sm8650"}, {.compatible = "qcom,sm8750-sndcard", "sm8750"}, + {.compatible = "qcom,shikra-sndcard", "shikra"}, {} }; From 3aaa6a73ebebb3cbb6d9cdfafc0da8fddd60b53d Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Tue, 26 May 2026 12:51:51 +0530 Subject: [PATCH 7/9] ASoC: codecs: wsa885x-i2c: make TDM control sequence slot-aware Pass the requested TDM slot count into reg_update_sequence() and program DIG_CTRL1_I2S_TDM_CTL0 based on 2-, 4-, or 8-slot modes. This allows the WSA885x I2C codec driver to configure TDM control registers correctly for different slot configurations instead of using a fixed value. Signed-off-by: Mohammad Rafi Shaik --- sound/soc/codecs/wsa885x-i2c.c | 118 +++++++++++++++++++++++++++++++-- 1 file changed, 111 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wsa885x-i2c.c b/sound/soc/codecs/wsa885x-i2c.c index 2ace3a0956b25..1d40761106177 100644 --- a/sound/soc/codecs/wsa885x-i2c.c +++ b/sound/soc/codecs/wsa885x-i2c.c @@ -196,6 +196,11 @@ #define FU21_VOL_STEPS 124 static const DECLARE_TLV_DB_SCALE(fu21_digital_gain, -8400, 100, 0); +/*TDM Slots*/ +#define WSA885X_TDM8 0X08 +#define WSA885X_TDM4 0X04 +#define WSA885X_TDM2 0X02 + static const char *const supply_name[] = { "vdd-io", "vdd-1p8", @@ -408,13 +413,21 @@ static int wsa885x_gpio_set(struct wsa885x_i2c_priv *wsa885x, bool val) return ret; } -static void reg_update_sequence(struct regmap *regmap) +static void reg_update_sequence(struct regmap *regmap, int slots) { regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL1, 0x15); regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL1, 0x11); /* Configure TDM control register 0 */ - regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL0, 0x04); + if (slots == WSA885X_TDM2) + regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL0, 0x0); + else if (slots == WSA885X_TDM4) + regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL0, 0x04); + else if (slots == WSA885X_TDM8) + regmap_write(regmap, DIG_CTRL1_I2S_TDM_CTL0, 0xC); + else + pr_warn("Invalid TDM slot count: %d, expected 2, 4, or 8\n", slots); + regmap_update_bits(regmap, DIG_CTRL1_I2S_TDM_CTL0, 0x01, 0x01); /* Configure TDM transmit channel settings */ @@ -616,7 +629,7 @@ static int codec_set_tdm_slot(struct snd_soc_dai *dai, regmap_update_bits(wsa885x->regmap, DIG_CTRL1_I2S_CFG1_TDM_TX, 0x60, 0x60); /* Apply TDM control sequence */ - reg_update_sequence(wsa885x->regmap); + reg_update_sequence(wsa885x->regmap, slots); /* Enable transmit channels */ regmap_update_bits(wsa885x->regmap, DIG_CTRL1_I2S_TDM_CH_TX, 0x04, 0x04); @@ -630,7 +643,7 @@ static int codec_set_tdm_slot(struct snd_soc_dai *dai, /* Configure slot1 for current protection sense 0 */ regmap_update_bits(wsa885x->regmap, DIG_CTRL1_I2S_CFG0_TDM_TX, 0x50, 0x50); - reg_update_sequence(wsa885x->regmap); + reg_update_sequence(wsa885x->regmap, slots); } else if (wsa885x->rx_slot_mask == WSA885X_CHANNEL_MONO_RIGHT) { /* Mono right channel configuration */ /* Configure slot0 for I-sense channel 1 */ @@ -639,7 +652,7 @@ static int codec_set_tdm_slot(struct snd_soc_dai *dai, /* Configure slot1 for current protection sense 1 */ regmap_update_bits(wsa885x->regmap, DIG_CTRL1_I2S_CFG0_TDM_TX, 0x60, 0x60); - reg_update_sequence(wsa885x->regmap); + reg_update_sequence(wsa885x->regmap, slots); } /* Enable I2S control */ @@ -719,6 +732,93 @@ static int codec_set_sysclk(struct snd_soc_dai *dai, int clk_id, return 0; } +static int wsa885x_handle_ssr_reset(struct wsa885x_i2c_priv *wsa885x) +{ + int ret; + + /* + * Re-toggle shutdown GPIO to force codec out of a potential SSR/fault + * state, then keep PA FSM disabled until power-up reconfiguration. + */ + if (wsa885x->sd_n) { + dev_dbg(wsa885x->component->dev, "%s: asserting powerdown gpio\n", + __func__); + ret = wsa885x_gpio_set(wsa885x, true); + if (ret) { + dev_err(wsa885x->component->dev, + "%s: failed to assert powerdown gpio: %d\n", + __func__, ret); + return ret; + } + + usleep_range(1000, 1500); + + dev_dbg(wsa885x->component->dev, "%s: deasserting powerdown gpio\n", + __func__); + ret = wsa885x_gpio_set(wsa885x, false); + if (ret) { + dev_err(wsa885x->component->dev, + "%s: failed to deassert powerdown gpio: %d\n", + __func__, ret); + return ret; + } + + usleep_range(2000, 2500); + } else { + dev_dbg(wsa885x->component->dev, + "%s: no powerdown gpio, skip gpio reset sequence\n", __func__); + } + + regmap_write(wsa885x->regmap, DIG_CTRL0_PA_FSM_CTL, 0x00); + dev_dbg(wsa885x->component->dev, "%s: PA FSM disabled\n", __func__); + return 0; +} + +static int reinit_wsa885x_powerup(struct wsa885x_i2c_priv *wsa885x) +{ + int ret = 0; + int ps = 0; + + ret = wsa885x_handle_ssr_reset(wsa885x); + if (ret) { + dev_err(wsa885x->component->dev, "SSR reset failed: %d\n", ret); + return ret; + } + + dev_dbg(wsa885x->component->dev, "%s: programming reinit sequence\n", + __func__); + regmap_write(wsa885x->regmap, DIG_CTRL0_PA_FSM_CTL, 0x00); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_OT23_USAGE, + wsa885x->usage_mode); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_IT21_CLUSERINDEX, 0x01); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_PPU21_POSTURENUMBER, 0x01); + + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_FU21_CH_VOL_CH2X0_MSB, + wsa885x->stereo_voldB); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_FU21_CH_VOL_CH2X0_LSB, 0x00); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_FU21_CH_VOL_CH2X1_MSB, + wsa885x->stereo_voldB); + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_FU21_CH_VOL_CH2X1_LSB, 0x00); + regmap_write(wsa885x->regmap, DIG_CTRL0_SDCA_COMMIT, 0x01); + dev_dbg(wsa885x->component->dev, + "%s: committed usage=%u vol_db=%d cluster=1 posture=1\n", + __func__, wsa885x->usage_mode, wsa885x->stereo_voldB); + + regmap_write(wsa885x->regmap, SMP_AMP_CTRL_STEREO_PDE23_REQ_PS, 0x00); + dev_dbg(wsa885x->component->dev, "%s: requested PS%d\n", __func__, ps); + + ret = wait_for_pde_state(wsa885x, ps, SMP_AMP_CTRL_STEREO_PDE23_ACT_PS); + if (!ret) { + dev_dbg(wsa885x->component->dev, + "Successfully transitioned to power state %d\n", ps); + } else { + dev_err(wsa885x->component->dev, + "Failed transitioned to power state %d\n", ps); + } + + return ret; +} + static int codec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) { struct wsa885x_i2c_priv *wsa885x = snd_soc_dai_get_drvdata(dai); @@ -771,7 +871,9 @@ static int codec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) "Successfully transitioned to power state %d\n", ps0); } else { dev_err(wsa885x->component->dev, "PS0 request failed\n"); - goto exit; + ret = reinit_wsa885x_powerup(wsa885x); + if (ret) + goto exit; } /* Configure power amplifier based on channel configuration */ @@ -1047,7 +1149,7 @@ static const struct snd_kcontrol_new wsa885x_snd_controls[] = { wsa885x_stereo_gain_offset_put, fu21_digital_gain), - SOC_SINGLE_EXT("Rx Slot Mask", SND_SOC_NOPM, 0, 4, 0, + SOC_SINGLE_EXT("Rx Slot Mask", SND_SOC_NOPM, 0, 3, 0, wsa885x_i2c_rx_slot_mask_get, wsa885x_i2c_rx_slot_mask_put), }; @@ -1337,6 +1439,8 @@ static const struct of_device_id wsa885x_i2c_dt_match[] = { }, {}}; +MODULE_DEVICE_TABLE(of, wsa885x_i2c_dt_match); + static const struct i2c_device_id wsa885x_id_i2c[] = { {"wsa885x_i2c", 0}, {} From d85827f6e991dc53cc28ca0443578ce35e5184ca Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Thu, 28 May 2026 01:24:41 +0530 Subject: [PATCH 8/9] ASoC: qcom: sc8280xp: Fix the sc8280xp driver to support Shikra cqm Fix the sc8280xp driver to support Shikra cqm Signed-off-by: Mohammad Rafi Shaik --- include/dt-bindings/sound/qcom,lpass.h | 2 ++ sound/soc/qcom/common.c | 2 ++ sound/soc/qcom/sc8280xp.c | 4 +++- sound/soc/qcom/sdw.c | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/sound/qcom,lpass.h b/include/dt-bindings/sound/qcom,lpass.h index a9404c3b8884c..e2c29416e2b98 100644 --- a/include/dt-bindings/sound/qcom,lpass.h +++ b/include/dt-bindings/sound/qcom,lpass.h @@ -41,6 +41,8 @@ #define LPASS_CDC_DMA_VA_TX7 32 #define LPASS_CDC_DMA_VA_TX8 33 +#define MI2S_SENARY 34 + #define LPASS_MCLK0 0 #endif /* __DT_QCOM_LPASS_H */ diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index cf1f3a767ceef..697d44d76e476 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -2,6 +2,7 @@ // Copyright (c) 2018, Linaro Limited. // Copyright (c) 2018, The Linux Foundation. All rights reserved. +#include #include #include #include @@ -236,6 +237,7 @@ int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd, case TX_CODEC_DMA_TX_1: case TX_CODEC_DMA_TX_2: case TX_CODEC_DMA_TX_3: + case LPASS_CDC_DMA_VA_TX1: for_each_rtd_codec_dais(rtd, i, codec_dai) { rval = snd_soc_component_set_jack(codec_dai->component, jack, NULL); diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index c6544820efbb2..f821e4201f51c 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2022, Linaro Limited +#include #include #include #include @@ -86,6 +87,7 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, case TX_CODEC_DMA_TX_1: case TX_CODEC_DMA_TX_2: case TX_CODEC_DMA_TX_3: + case LPASS_CDC_DMA_VA_TX1: channels->min = 1; break; default: @@ -127,7 +129,7 @@ static void sc8280xp_add_be_ops(struct snd_soc_card *card) int i; for_each_card_prelinks(card, i, link) { - if (link->no_pcm == 1) { + if (link->no_pcm == 1 || link->num_codecs > 0) { link->init = sc8280xp_snd_init; link->be_hw_params_fixup = sc8280xp_be_hw_params_fixup; link->ops = &sc8280xp_be_ops; diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c index 6576b47a4c8c3..cf70ffec71c17 100644 --- a/sound/soc/qcom/sdw.c +++ b/sound/soc/qcom/sdw.c @@ -41,6 +41,7 @@ static bool qcom_snd_is_sdw_dai(int id) switch (id) { case LPASS_CDC_DMA_TX3: case LPASS_CDC_DMA_RX0: + case LPASS_CDC_DMA_VA_TX1: return true; default: break; From 7427c9b45ca17088535949d0fb72ec9ed27ff1af Mon Sep 17 00:00:00 2001 From: Mohammad Rafi Shaik Date: Wed, 27 May 2026 23:05:34 +0530 Subject: [PATCH 9/9] SoC: codecs: lpass-va-macro: Add soundwire mic support Add soundwire Amic support on VA macro. Signed-off-by: Mohammad Rafi Shaik --- sound/soc/codecs/lpass-va-macro.c | 78 ++++++++++++++++++++++++------- 1 file changed, 62 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 0d4d94adf121c..22a4ab0f89c80 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -310,6 +310,11 @@ enum { VA_MACRO_CLK_DIV_16, }; +enum { + MSM_DMIC, + SWR_MIC, +}; + #define VA_NUM_CLKS_MAX 3 struct va_macro { @@ -820,14 +825,32 @@ static int va_macro_put_dec_enum(struct snd_kcontrol *kcontrol, return -EINVAL; } - if (val != 0) - snd_soc_component_update_bits(component, mic_sel_reg, - CDC_VA_TX_PATH_ADC_DMIC_SEL_MASK, - CDC_VA_TX_PATH_ADC_DMIC_SEL_DMIC); + if (val != 0) { + if (strnstr(widget->name, "SMIC", strlen(widget->name))) + snd_soc_component_update_bits(component, mic_sel_reg, + CDC_VA_TX_PATH_ADC_DMIC_SEL_MASK, 0); + else + snd_soc_component_update_bits(component, mic_sel_reg, + CDC_VA_TX_PATH_ADC_DMIC_SEL_MASK, + CDC_VA_TX_PATH_ADC_DMIC_SEL_DMIC); + } return snd_soc_dapm_put_enum_double(kcontrol, ucontrol); } +static bool is_amic_enabled(struct snd_soc_component *comp, int decimator) +{ + u16 adc_mux_reg = 0; + bool ret = false; + + adc_mux_reg = CDC_VA_INP_MUX_ADC_MUX0_CFG1 + + VA_MACRO_ADC_MUX_CFG_OFFSET * decimator; + if (snd_soc_component_read(comp, adc_mux_reg) & SWR_MIC) + return true; + + return ret; +} + static int va_macro_tx_mixer_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -1012,6 +1035,8 @@ static int va_macro_enable_dec(struct snd_soc_dapm_widget *w, u16 tx_vol_ctl_reg, dec_cfg_reg, hpf_gate_reg; u16 tx_gain_ctl_reg; u8 hpf_cut_off_freq; + u16 adc_mux0_reg = 0; + u16 adapt_ctrl = 0; struct va_macro *va = snd_soc_component_get_drvdata(comp); @@ -1025,6 +1050,10 @@ static int va_macro_enable_dec(struct snd_soc_dapm_widget *w, VA_MACRO_TX_PATH_OFFSET * decimator; tx_gain_ctl_reg = CDC_VA_TX0_TX_VOL_CTL + VA_MACRO_TX_PATH_OFFSET * decimator; + adc_mux0_reg = CDC_VA_INP_MUX_ADC_MUX0_CFG0 + + VA_MACRO_ADC_MUX_CFG_OFFSET * decimator; + adapt_ctrl = CDC_VA_CDC_ADPT0_ADPT_CTRL + + VA_MACRO_TX_PATH_OFFSET *decimator; switch (event) { case SND_SOC_DAPM_PRE_PMU: @@ -1034,6 +1063,9 @@ static int va_macro_enable_dec(struct snd_soc_dapm_widget *w, /* Enable TX PGA Mute */ break; case SND_SOC_DAPM_POST_PMU: + if (va->codec_version == LPASS_CODEC_VERSION_4_0) + snd_soc_component_update_bits(comp, adapt_ctrl, 0xFF, 0x00); + /* Enable TX CLK */ snd_soc_component_update_bits(comp, tx_vol_ctl_reg, CDC_VA_TX_PATH_CLK_EN_MASK, @@ -1042,7 +1074,13 @@ static int va_macro_enable_dec(struct snd_soc_dapm_widget *w, CDC_VA_TX_HPF_ZERO_GATE_MASK, CDC_VA_TX_HPF_ZERO_GATE); - usleep_range(1000, 1010); + if (!is_amic_enabled(comp, decimator)) { + snd_soc_component_update_bits(comp, hpf_gate_reg, + CDC_VA_TX_HPF_ZERO_GATE_MASK, + CDC_VA_TX_HPF_ZERO_GATE); + usleep_range(1000, 1010); + } + hpf_cut_off_freq = (snd_soc_component_read(comp, dec_cfg_reg) & TX_HPF_CUT_OFF_FREQ_MASK) >> 5; @@ -1050,23 +1088,25 @@ static int va_macro_enable_dec(struct snd_soc_dapm_widget *w, snd_soc_component_update_bits(comp, dec_cfg_reg, TX_HPF_CUT_OFF_FREQ_MASK, CF_MIN_3DB_150HZ << 5); + } - snd_soc_component_update_bits(comp, hpf_gate_reg, - CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_MASK, - CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_REQ); + snd_soc_component_update_bits(comp, hpf_gate_reg, + CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_MASK, + CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_REQ); - /* - * Minimum 1 clk cycle delay is required as per HW spec - */ - usleep_range(1000, 1010); + /* + * Minimum 1 clk cycle delay is required as per HW spec + */ + usleep_range(1000, 1010); + + if (!is_amic_enabled(comp, decimator)) { snd_soc_component_update_bits(comp, - hpf_gate_reg, - CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_MASK, - 0x0); + hpf_gate_reg, + CDC_VA_TX_HPF_CUTOFF_FREQ_CHANGE_MASK, + 0x0); } - usleep_range(1000, 1010); snd_soc_component_update_bits(comp, hpf_gate_reg, CDC_VA_TX_HPF_ZERO_GATE_MASK, @@ -1545,6 +1585,12 @@ static const struct snd_soc_dapm_route va_audio_map[] = { {"VA DMIC MUX3", "DMIC6", "VA DMIC6"}, {"VA DMIC MUX3", "DMIC7", "VA DMIC7"}, + /* SWR_MIC routes: connect each VA DECx MUX to its SWR_MIC input */ + {"VA DEC0 MUX", "SWR_MIC", "VA SWR_MIC0"}, + {"VA DEC1 MUX", "SWR_MIC", "VA SWR_MIC1"}, + {"VA DEC2 MUX", "SWR_MIC", "VA SWR_MIC2"}, + {"VA DEC3 MUX", "SWR_MIC", "VA SWR_MIC3"}, + { "VA DMIC0", NULL, "DMIC0 Pin" }, { "VA DMIC1", NULL, "DMIC1 Pin" }, { "VA DMIC2", NULL, "DMIC2 Pin" },