Skip to content

[ExecuTorch][WebGPU] SDPA test suite: replay + dynamic input_pos + in-graph KV cache#20087

Open
JulianCloudNTH wants to merge 5 commits into
gh/JulianCloudNTH/20/basefrom
gh/JulianCloudNTH/20/head
Open

[ExecuTorch][WebGPU] SDPA test suite: replay + dynamic input_pos + in-graph KV cache#20087
JulianCloudNTH wants to merge 5 commits into
gh/JulianCloudNTH/20/basefrom
gh/JulianCloudNTH/20/head

Conversation

@JulianCloudNTH

@JulianCloudNTH JulianCloudNTH commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Adds the WebGPU SDPA test coverage as its own diff, stacked on the SDPA op (which already carries the dynamic-input_pos consumption) and the SymInt mechanism below it: multi-step prefill->mt->decode replay, runtime-dynamic input_pos (autoregressive decode), and an in-graph mutable KV cache, each compared against a torch F.scaled_dot_product_attention golden.

  • test/ops/sdpa/test_sdpa.py: ReplaySeq/REPLAY_SEQS + per-step replay export/golden; DynamicSdpaModule + export_dynamic_decode (one .pte, input_pos supplied at runtime as a SymInt); DecodeCacheModule + export_incache_decode (KV cache as register_buffer mutable buffers, so the cache persists in-graph and forward() feeds only the new token + input_pos).
  • test/test_webgpu_native.cpp: test_sdpa_replay, test_sdpa_dynamic_decode (+ negative control: a pinned input_pos diverges), test_sdpa_incache_decode (+ static control: a fresh Module per step diverges, proving in-graph accumulation is real), test_symint_roundtrip, test_resize_hook; shared per-element tolerance sdpa_within_tol (abs 1e-4 OR rel 1e-3).
  • test/test_build_webgpu.sh: export the replay / dynamic / in-graph-cache models for the native test.
    @exported-using-ghexport

Differential Revision: D107595144

Differential Revision: D107595144

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20087

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Unclassified Failure

As of commit 9656d0e with merge base ff2bf9c (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2026
@JulianCloudNTH JulianCloudNTH reopened this Jun 9, 2026
[ghstack-poisoned]
JulianCloudNTH added a commit that referenced this pull request Jun 9, 2026
…-graph KV cache

Pull Request resolved: #20087

Adds the WebGPU SDPA test coverage as its own diff, stacked on the SDPA op (which already carries the dynamic-`input_pos` consumption) and the SymInt mechanism below it: multi-step prefill->mt->decode replay, runtime-dynamic `input_pos` (autoregressive decode), and an in-graph mutable KV cache, each compared against a torch `F.scaled_dot_product_attention` golden.

- `test/ops/sdpa/test_sdpa.py`: `ReplaySeq`/`REPLAY_SEQS` + per-step replay export/golden; `DynamicSdpaModule` + `export_dynamic_decode` (one `.pte`, `input_pos` supplied at runtime as a SymInt); `DecodeCacheModule` + `export_incache_decode` (KV cache as `register_buffer` mutable buffers, so the cache persists in-graph and forward() feeds only the new token + `input_pos`).
- `test/test_webgpu_native.cpp`: `test_sdpa_replay`, `test_sdpa_dynamic_decode` (+ negative control: a pinned `input_pos` diverges), `test_sdpa_incache_decode` (+ static control: a fresh Module per step diverges, proving in-graph accumulation is real), `test_symint_roundtrip`, `test_resize_hook`; shared per-element tolerance `sdpa_within_tol` (abs 1e-4 OR rel 1e-3).
- `test/test_build_webgpu.sh`: export the replay / dynamic / in-graph-cache models for the native test.
ghstack-source-id: 391352764
@exported-using-ghexport

Differential Revision: [D107595144](https://our.internmc.facebook.com/intern/diff/D107595144/)
[ghstack-poisoned]
JulianCloudNTH added a commit that referenced this pull request Jun 9, 2026
…-graph KV cache

Pull Request resolved: #20087

Adds the WebGPU SDPA test coverage as its own diff, stacked on the SDPA op (which already carries the dynamic-`input_pos` consumption) and the SymInt mechanism below it: multi-step prefill->mt->decode replay, runtime-dynamic `input_pos` (autoregressive decode), and an in-graph mutable KV cache, each compared against a torch `F.scaled_dot_product_attention` golden.

- `test/ops/sdpa/test_sdpa.py`: `ReplaySeq`/`REPLAY_SEQS` + per-step replay export/golden; `DynamicSdpaModule` + `export_dynamic_decode` (one `.pte`, `input_pos` supplied at runtime as a SymInt); `DecodeCacheModule` + `export_incache_decode` (KV cache as `register_buffer` mutable buffers, so the cache persists in-graph and forward() feeds only the new token + `input_pos`).
- `test/test_webgpu_native.cpp`: `test_sdpa_replay`, `test_sdpa_dynamic_decode` (+ negative control: a pinned `input_pos` diverges), `test_sdpa_incache_decode` (+ static control: a fresh Module per step diverges, proving in-graph accumulation is real), `test_symint_roundtrip`, `test_resize_hook`; shared per-element tolerance `sdpa_within_tol` (abs 1e-4 OR rel 1e-3).
- `test/test_build_webgpu.sh`: export the replay / dynamic / in-graph-cache models for the native test.
ghstack-source-id: 391352764
@exported-using-ghexport

Differential Revision: [D107595144](https://our.internmc.facebook.com/intern/diff/D107595144/)
[ghstack-poisoned]
JulianCloudNTH added a commit that referenced this pull request Jun 9, 2026
…-graph KV cache

Pull Request resolved: #20087

Adds the WebGPU SDPA test coverage as its own diff, stacked on the SDPA op (which already carries the dynamic-`input_pos` consumption) and the SymInt mechanism below it: multi-step prefill->mt->decode replay, runtime-dynamic `input_pos` (autoregressive decode), and an in-graph mutable KV cache, each compared against a torch `F.scaled_dot_product_attention` golden.

- `test/ops/sdpa/test_sdpa.py`: `ReplaySeq`/`REPLAY_SEQS` + per-step replay export/golden; `DynamicSdpaModule` + `export_dynamic_decode` (one `.pte`, `input_pos` supplied at runtime as a SymInt); `DecodeCacheModule` + `export_incache_decode` (KV cache as `register_buffer` mutable buffers, so the cache persists in-graph and forward() feeds only the new token + `input_pos`).
- `test/test_webgpu_native.cpp`: `test_sdpa_replay`, `test_sdpa_dynamic_decode` (+ negative control: a pinned `input_pos` diverges), `test_sdpa_incache_decode` (+ static control: a fresh Module per step diverges, proving in-graph accumulation is real), `test_symint_roundtrip`, `test_resize_hook`; shared per-element tolerance `sdpa_within_tol` (abs 1e-4 OR rel 1e-3).
- `test/test_build_webgpu.sh`: export the replay / dynamic / in-graph-cache models for the native test.
ghstack-source-id: 391373155
@exported-using-ghexport

Differential Revision: [D107595144](https://our.internmc.facebook.com/intern/diff/D107595144/)
[ghstack-poisoned]
JulianCloudNTH added a commit that referenced this pull request Jun 9, 2026
…-graph KV cache

Pull Request resolved: #20087

Adds the WebGPU SDPA test coverage as its own diff, stacked on the SDPA op (which already carries the dynamic-`input_pos` consumption) and the SymInt mechanism below it: multi-step prefill->mt->decode replay, runtime-dynamic `input_pos` (autoregressive decode), and an in-graph mutable KV cache, each compared against a torch `F.scaled_dot_product_attention` golden.

- `test/ops/sdpa/test_sdpa.py`: `ReplaySeq`/`REPLAY_SEQS` + per-step replay export/golden; `DynamicSdpaModule` + `export_dynamic_decode` (one `.pte`, `input_pos` supplied at runtime as a SymInt); `DecodeCacheModule` + `export_incache_decode` (KV cache as `register_buffer` mutable buffers, so the cache persists in-graph and forward() feeds only the new token + `input_pos`).
- `test/test_webgpu_native.cpp`: `test_sdpa_replay`, `test_sdpa_dynamic_decode` (+ negative control: a pinned `input_pos` diverges), `test_sdpa_incache_decode` (+ static control: a fresh Module per step diverges, proving in-graph accumulation is real), `test_symint_roundtrip`, `test_resize_hook`; shared per-element tolerance `sdpa_within_tol` (abs 1e-4 OR rel 1e-3).
- `test/test_build_webgpu.sh`: export the replay / dynamic / in-graph-cache models for the native test.
ghstack-source-id: 391378806
@exported-using-ghexport

Differential Revision: [D107595144](https://our.internmc.facebook.com/intern/diff/D107595144/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant