Skip to content

Commit 4ea0c2f

Browse files
Raahul Kalyaan Jakkafacebook-github-bot
authored andcommitted
Adding returnKVTensorMetaData flag to Staging Read Strategy (#5200)
Summary: X-link: facebookresearch/FBGEMM#2196 **Context:** When using SSD Offloaded Tensors during Training, we create a Partially Materialized Tensor (i.e., tensor-like) structure to be used for post-training (checkpointing and publishing) In this diff, we add a new flag "returnKVTensorMetaData" to the Staging Read Strategy, which helps us to read only the metadata of the KVTensor and not the KVTensor itself Reviewed By: chunzhao Differential Revision: D86634084
1 parent 055dbbc commit 4ea0c2f

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

fbgemm_gpu/src/ssd_split_embeddings_cache/kv_tensor_wrapper_cpu.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,10 @@ std::string KVTensorWrapper::layout_str() {
108108
oss << options_.layout();
109109
return oss.str();
110110
}
111+
112+
std::vector<std::string> KVTensorWrapper::get_kvtensor_serializable_metadata()
113+
const {
114+
FBEXCEPTION("Not implemented");
115+
return std::vector<std::string>{};
116+
}
111117
} // namespace ssd

fbgemm_gpu/src/ssd_split_embeddings_cache/ssd_split_table_batched_embeddings.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,10 @@ std::string KVTensorWrapper::serialize() const {
415415
std::vector<std::string> KVTensorWrapper::get_kvtensor_serializable_metadata()
416416
const {
417417
std::vector<std::string> metadata;
418+
// Return empty metadata if checkpoint_handle_ is not initialized yet
419+
if (checkpoint_handle_ == nullptr) {
420+
return metadata;
421+
}
418422
auto* db = dynamic_cast<EmbeddingRocksDB*>(db_.get());
419423
auto checkpoint_paths = db->get_checkpoints(checkpoint_handle_->uuid);
420424
metadata.push_back(std::to_string(checkpoint_paths.size()));

0 commit comments

Comments
 (0)