Skip to content

Commit dad7fd5

Browse files
committed
linting, formatting, and fixing reference location for default projector
1 parent 1146c2b commit dad7fd5

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

arcade/camera/default.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
from pyglet.window.key import F
99
from typing_extensions import Self
1010

11+
from arcade.camera.data_types import DEFAULT_FAR, DEFAULT_NEAR_ORTHO
1112
from arcade.types import LBWH, Point, Rect
1213
from arcade.window_commands import get_window
13-
from arcade.camera.data_types import DEFAULT_NEAR_ORTHO, DEFAULT_FAR
1414

1515
if TYPE_CHECKING:
1616
from arcade.context import ArcadeContext
@@ -51,12 +51,14 @@ def update_viewport(self):
5151
setting the viewport to match the size of the active
5252
framebuffer sets the viewport to None.
5353
"""
54+
5455
# If another camera is active then the viewport was probably set
5556
# by camera.use()
5657
if self._ctx.current_camera != self or self._updating:
5758
return
5859
self._updating = True
5960

61+
if (
6062
self._ctx.viewport[2] != self._ctx.fbo.width
6163
or self._ctx.viewport[3] != self._ctx.fbo.height
6264
):
@@ -106,7 +108,6 @@ def width(self) -> int:
106108
def height(self) -> int:
107109
if self._viewport is not None:
108110
return int(self._viewport.height)
109-
return self._ctx.active_framebuffer.height
110111
return self._ctx.fbo.height
111112

112113
def get_current_viewport(self) -> tuple[int, int, int, int]:

arcade/camera/viewport.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
from pyglet.math import Mat4, Vec2, Vec3
88
from typing_extensions import Self
99

10+
from arcade.camera.data_types import DEFAULT_FAR, DEFAULT_NEAR_ORTHO
1011
from arcade.types import LBWH, Point, Rect
1112
from arcade.window_commands import get_window
12-
from arcade.camera.data_types import DEFAULT_NEAR_ORTHO, DEFAULT_FAR
1313

1414
if TYPE_CHECKING:
1515
from arcade.context import ArcadeContext

tests/unit/camera/test_viewport_projector.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88

99
@pytest.mark.parametrize("wrld_pos", [Vec2(100, 150), Vec2(1280, 720), Vec3(500, 500, -10)])
1010
def test_viewport_projector_project(window: Window, wrld_pos: Point):
11-
cam = camera.default.ViewportProjector()
11+
cam = camera.ViewportProjector()
1212
assert cam.project(wrld_pos) == wrld_pos.xy
1313

1414

1515
@pytest.mark.parametrize("wrld_pos", [Vec2(100, 150), Vec2(1280, 720), Vec3(500, 500, -10)])
1616
def test_viewport_projector_unproject(window: Window, wrld_pos: Point):
17-
cam = camera.default.ViewportProjector()
17+
cam = camera.ViewportProjector()
1818
x, y, *z = wrld_pos
1919

2020
assert cam.unproject(wrld_pos) == Vec3(x, y, 0.0 if not z else z[0])
@@ -24,7 +24,7 @@ def test_viewport_projector_unproject(window: Window, wrld_pos: Point):
2424
"viewport", [LBWH(0.0, 0.0, 100, 200), LBWH(100, 100, 20, 40), LBWH(300, 20, 20, 700)]
2525
)
2626
def test_viewport_projector_viewport(window: Window, viewport: Rect):
27-
cam = camera.default.ViewportProjector()
27+
cam = camera.ViewportProjector()
2828
assert cam.viewport.lbwh_int == window.ctx.viewport
2929
cam.viewport = viewport
3030
assert cam.viewport == viewport

0 commit comments

Comments
 (0)