Disallow passing filemode, encoding, or errors without filename

Author: brianschubert

stdlib/@tests/test_cases/check_logging.py

@@ -42,7 +42,13 @@ def record_factory(*args: Any, **kwargs: Any) -> logging.LogRecord:
 logging.basicConfig(filename="foo.log", filemode="w", handlers=None)
 logging.basicConfig(stream=None)
 logging.basicConfig(stream=None, handlers=None)
-# 'filemode' is inert when 'filename' is not passed, but is accepted if 'handlers=None'.
-logging.basicConfig(filemode="w", stream=None)
 # dubious but accepted, has same meaning as 'stream=None'.
 logging.basicConfig(filename=None)
+# These are technically accepted at runtime, but are forbidden in the stubs to help
+# prevent user mistakes. Passing 'filemode' / 'encoding' / 'errors' does nothing
+# if 'filename' is not specified.
+logging.basicConfig(stream=None, filemode="w")  # type: ignore
+logging.basicConfig(stream=None, encoding="utf-8")  # type: ignore
+logging.basicConfig(stream=None, errors="strict")  # type: ignore
+logging.basicConfig(handlers=[], encoding="utf-8")  # type: ignore
+logging.basicConfig(handlers=[], errors="strict")  # type: ignore

stdlib/logging/__init__.pyi

@@ -585,8 +585,6 @@ def basicConfig(
     level: _Level | None = None,
     handlers: Iterable[Handler],
     force: bool | None = False,
-    encoding: str | None = None,
-    errors: str | None = "backslashreplace",
 ) -> None: ...
 @overload  # handlers is None, filename is passed (but possibly None)
 def basicConfig(
@@ -605,16 +603,13 @@ def basicConfig(
 @overload  # handlers is None, filename is not passed
 def basicConfig(
     *,
-    filemode: str = "a",
     format: str = ...,  # default value depends on the value of `style`
     datefmt: str | None = None,
     style: _FormatStyle = "%",
     level: _Level | None = None,
     stream: SupportsWrite[str] | None = None,
     handlers: None = None,
     force: bool | None = False,
-    encoding: str | None = None,
-    errors: str | None = "backslashreplace",
 ) -> None: ...
 def shutdown(handlerList: Sequence[Any] = ...) -> None: ...  # handlerList is undocumented
 def setLoggerClass(klass: type[Logger]) -> None: ...