Skip to content

Commit e3b1e9c

Browse files
committed
Extract get_stats_with_defaults for readability
Signed-off-by: Stefan Marr <git@stefan-marr.de>
1 parent 7341205 commit e3b1e9c

1 file changed

Lines changed: 17 additions & 12 deletions

File tree

codespeed/views.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -306,18 +306,7 @@ def gettimelinedata(request):
306306
results = []
307307
for res in resultquery:
308308
if bench.data_type == 'M':
309-
val_min = ""
310-
if res.val_min is not None:
311-
val_min = res.val_min
312-
val_max = ""
313-
if res.val_max is not None:
314-
val_max = res.val_max
315-
q1 = ""
316-
if res.q1 is not None:
317-
q1 = res.q1
318-
q3 = ""
319-
if res.q3 is not None:
320-
q3 = res.q3
309+
q1, q3, val_max, val_min = get_stats_with_defaults(res)
321310
results.append(
322311
[
323312
res.revision.date.strftime('%Y/%m/%d %H:%M:%S %z'),
@@ -373,6 +362,22 @@ def gettimelinedata(request):
373362
return HttpResponse(json.dumps(timeline_list))
374363

375364

365+
def get_stats_with_defaults(res):
366+
val_min = ""
367+
if res.val_min is not None:
368+
val_min = res.val_min
369+
val_max = ""
370+
if res.val_max is not None:
371+
val_max = res.val_max
372+
q1 = ""
373+
if res.q1 is not None:
374+
q1 = res.q1
375+
q3 = ""
376+
if res.q3 is not None:
377+
q3 = res.q3
378+
return q1, q3, val_max, val_min
379+
380+
376381
@require_GET
377382
def timeline(request):
378383
data = request.GET

0 commit comments

Comments
 (0)