Skip to content

Commit 872e78a

Browse files
committed
protect against empty normalization
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent d7a4123 commit 872e78a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

codespeed/static/js/comparison.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function getConfiguration() {
2222
ben: readCheckbox("input[name='benchmarks']:checked"),
2323
env: readCheckbox("input[name='environments']:checked"),
2424
hor: $("input[name='direction']").is(':checked'),
25-
bas: $("#baseline option:selected").val(),
25+
bas: $("#baseline option:selected").val() || "none",
2626
chart: $("#chart_type option:selected").val()
2727
};
2828
}
@@ -145,6 +145,7 @@ function loadData() {
145145

146146
function renderComparisonPlot(plotid, unit, benchmarks, exes, enviros, baseline, chart, horizontal) {
147147
// baseline may be "exe_key" or "exe_key:env_id" (for cross-env normalization)
148+
if (!baseline) { baseline = "none"; }
148149
var baselineExe = baseline, baselineEnv = null;
149150
if (baseline !== "none" && baseline.indexOf(':') !== -1) {
150151
var bparts = baseline.split(':');

0 commit comments

Comments
 (0)