Skip to content

Commit 7b74d53

Browse files
authored
Merge pull request tobami#264 from ctk21/feature/ctk21/single_update_on_add_json_results
Single update to the repo when doing add_json_results (issue tobami#237)
2 parents cb39a69 + 94a6963 commit 7b74d53

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

codespeed/results.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def validate_result(item):
4747
return "Environment %(environment)s not found" % item, error
4848

4949

50-
def save_result(data):
50+
def save_result(data, update_repo=True):
5151
res, error = validate_result(data)
5252
if error:
5353
return res, True
@@ -87,7 +87,7 @@ def save_result(data):
8787
return str(e), True
8888
if p.repo_type not in ("N", ""):
8989
try:
90-
commit_logs = commits.get_logs(rev, rev, update=True)
90+
commit_logs = commits.get_logs(rev, rev, update=update_repo)
9191
except commits.exceptions.CommitLogError as e:
9292
logger.warning("unable to save revision %s info: %s", rev, e,
9393
exc_info=True)

codespeed/views.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -819,11 +819,9 @@ def add_json_results(request):
819819
logger.info("add_json_results request with %d entries." % len(data))
820820

821821
unique_reports = set()
822-
i = 0
823-
for result in data:
824-
i += 1
822+
for (i, result) in enumerate(data):
825823
logger.debug("add_json_results: save item %d." % i)
826-
response, error = save_result(result)
824+
response, error = save_result(result, update_repo=(i==0))
827825
if error:
828826
logger.debug(
829827
"add_json_results: could not save item %d because %s" % (

0 commit comments

Comments
 (0)